From: Christoph Hellwig <hch@infradead.org>
To: Nathan Huckleberry <nhuck@google.com>
Cc: yamada.masahiro@socionext.com, michal.lkml@markovi.net,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH] kbuild: Change fallthrough comments to attributes
Date: Tue, 13 Aug 2019 00:15:20 -0700 [thread overview]
Message-ID: <20190813071520.GA5075@infradead.org> (raw)
In-Reply-To: <20190812214711.83710-1-nhuck@google.com>
On Mon, Aug 12, 2019 at 02:47:11PM -0700, Nathan Huckleberry wrote:
> Clang does not support the use of comments to label
> intentional fallthrough. This patch replaces some uses
> of comments to attributesto cut down a significant number
> of warnings on clang (from ~50000 to ~200). Only comments
> in commonly used header files have been replaced.
>
> Since there is still quite a bit of noise, this
> patch moves -Wimplicit-fallthrough to
> Makefile.extrawarn if you are compiling with
> clang.
That __attribute__ crap looks like a cat barfed over the keyboard.
Please fix up clang and keep the kernel source sane.
next prev parent reply other threads:[~2019-08-13 7:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 21:47 [PATCH] kbuild: Change fallthrough comments to attributes Nathan Huckleberry
2019-08-12 22:14 ` [PATCH v2] " Nathan Huckleberry
2019-08-12 22:40 ` Joe Perches
2019-08-12 23:11 ` Nick Desaulniers
2019-08-12 23:23 ` Joe Perches
2019-08-13 6:33 ` Nathan Chancellor
2019-08-13 7:04 ` Joe Perches
2019-08-13 7:43 ` Joe Perches
2019-08-13 9:48 ` David Laight
2019-08-12 23:06 ` [PATCH] " Nick Desaulniers
2019-08-13 7:15 ` Christoph Hellwig [this message]
2019-08-15 21:07 ` kbuild test robot
2019-08-15 21:07 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813071520.GA5075@infradead.org \
--to=hch@infradead.org \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=michal.lkml@markovi.net \
--cc=nhuck@google.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.