From: Nishka Dasgupta <nishkadg.linux@gmail.com>
To: tony@atomide.com, rogerq@ti.com, linux-kernel@vger.kernel.org
Cc: Nishka Dasgupta <nishkadg.linux@gmail.com>
Subject: [PATCH v3 2/2] bus: ti-sysc: sysc_check_children(): Change return type to void
Date: Tue, 13 Aug 2019 13:25:53 +0530 [thread overview]
Message-ID: <20190813075553.2354-2-nishkadg.linux@gmail.com> (raw)
In-Reply-To: <20190813075553.2354-1-nishkadg.linux@gmail.com>
Change return type of function sysc_check_children() from int to void as
it always returns 0. Remove its return statement as well.
At call site, remove the variable that was used to store the return
value, as well as the check on the return value.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
---
- This is a new patch; labelled v3 only because it is in the same series
as the previous patch.
drivers/bus/ti-sysc.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
index 9c6d3e121d37..a2eae8f36ef8 100644
--- a/drivers/bus/ti-sysc.c
+++ b/drivers/bus/ti-sysc.c
@@ -628,14 +628,12 @@ static void sysc_check_one_child(struct sysc *ddata,
sysc_parse_dts_quirks(ddata, np, true);
}
-static int sysc_check_children(struct sysc *ddata)
+static void sysc_check_children(struct sysc *ddata)
{
struct device_node *child;
for_each_child_of_node(ddata->dev->of_node, child)
sysc_check_one_child(ddata, child);
-
- return 0;
}
/*
@@ -788,9 +786,7 @@ static int sysc_map_and_check_registers(struct sysc *ddata)
if (error)
return error;
- error = sysc_check_children(ddata);
- if (error)
- return error;
+ sysc_check_children(ddata);
error = sysc_parse_registers(ddata);
if (error)
--
2.19.1
next prev parent reply other threads:[~2019-08-13 7:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 7:17 [PATCH v2] bus: ti-sysc: sysc_check_one_child(): Change return type to void Nishka Dasgupta
2019-08-13 7:28 ` Roger Quadros
2019-08-13 7:37 ` Nishka Dasgupta
2019-08-13 7:43 ` Roger Quadros
2019-08-13 7:55 ` [PATCH v3 1/2] " Nishka Dasgupta
2019-08-13 7:55 ` Nishka Dasgupta [this message]
2019-08-13 11:13 ` [PATCH v3 2/2] bus: ti-sysc: sysc_check_children(): " Roger Quadros
2019-08-13 11:42 ` Tony Lindgren
2019-08-15 5:46 ` [PATCH v4] bus: ti-sysc: Change return types of functions Nishka Dasgupta
2019-08-15 13:02 ` Roger Quadros
2019-08-26 15:31 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813075553.2354-2-nishkadg.linux@gmail.com \
--to=nishkadg.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.