From: Nishka Dasgupta <nishkadg.linux@gmail.com>
To: axboe@kernel.dk, linux-block@vger.kernel.org
Cc: Nishka Dasgupta <nishkadg.linux@gmail.com>
Subject: [PATCH] blk-sysfs: Make structure queue_attr_group constant
Date: Tue, 13 Aug 2019 14:25:41 +0530 [thread overview]
Message-ID: <20190813085541.7856-1-nishkadg.linux@gmail.com> (raw)
The static structure queue_attr_group is used only once, when it is
passed as the second argument to the function sysfs_create_group().
However, the second parameter of sysfs_create_group() is already defined
as constant. Hence make queue_attr_group itself constant, as it is never
modified.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
---
block/blk-sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
index 977c659dcd18..9401b0cc2e29 100644
--- a/block/blk-sysfs.c
+++ b/block/blk-sysfs.c
@@ -783,7 +783,7 @@ static umode_t queue_attr_visible(struct kobject *kobj, struct attribute *attr,
return attr->mode;
}
-static struct attribute_group queue_attr_group = {
+static const struct attribute_group queue_attr_group = {
.attrs = queue_attrs,
.is_visible = queue_attr_visible,
};
--
2.19.1
reply other threads:[~2019-08-13 8:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813085541.7856-1-nishkadg.linux@gmail.com \
--to=nishkadg.linux@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.