From: Tony Lindgren <tony@atomide.com>
To: Andreas Klinger <ak@it-klinger.de>
Cc: linux-omap@vger.kernel.org, bcousson@baylibre.com,
robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: am335x-wega.dtsi: fix wrong card detect pin level
Date: Tue, 13 Aug 2019 03:17:19 -0700 [thread overview]
Message-ID: <20190813101719.GG52127@atomide.com> (raw)
In-Reply-To: <20190709183209.y64keopah5rkismc@arbad>
* Andreas Klinger <ak@it-klinger.de> [190709 11:32]:
> mmc cards on mmc1 are not detected because of wrong card detect (cd) level.
>
> Change cd from GPIO_ACTIVE_HIGH to GPIO_ACTIVE_LOW.
>
> This is necessary because of commit e63201f19438 ("mmc: omap_hsmmc:
> Delete platform data GPIO CD and WP")
>
> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
> ---
> arch/arm/boot/dts/am335x-wega.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/am335x-wega.dtsi b/arch/arm/boot/dts/am335x-wega.dtsi
> index b7d28a20341f..84581fed3d06 100644
> --- a/arch/arm/boot/dts/am335x-wega.dtsi
> +++ b/arch/arm/boot/dts/am335x-wega.dtsi
> @@ -157,7 +157,7 @@
> bus-width = <4>;
> pinctrl-names = "default";
> pinctrl-0 = <&mmc1_pins>;
> - cd-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>;
> + cd-gpios = <&gpio0 6 GPIO_ACTIVE_LOW>;
> status = "okay";
> };
>
Looks like this already got fixed with an earlier commit 8a0098c05a27
("ARM: dts: am335x phytec boards: Fix cd-gpios active level").
Regards,
Tony
prev parent reply other threads:[~2019-08-13 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 18:32 [PATCH] ARM: dts: am335x-wega.dtsi: fix wrong card detect pin level Andreas Klinger
2019-07-22 8:06 ` Teresa Remmet
2019-08-13 10:17 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813101719.GG52127@atomide.com \
--to=tony@atomide.com \
--cc=ak@it-klinger.de \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.