From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [alsa-devel] Regression in next with codec unload and snd_soc_component_get/put Date: Tue, 13 Aug 2019 03:24:51 -0700 Message-ID: <20190813102451.GJ52127@atomide.com> References: <20190809070003.GA52127@atomide.com> <20190809074643.GB52127@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Takashi Iwai Cc: Kuninori Morimoto , Mark Brown , Jaroslav Kysela , alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org * Takashi Iwai [190809 08:24]: > On Fri, 09 Aug 2019 09:46:43 +0200, > Tony Lindgren wrote: > > > > * Takashi Iwai [190809 07:25]: > > > On Fri, 09 Aug 2019 09:00:03 +0200, > > > Tony Lindgren wrote: > > > > > > > > Hi, > > > > > > > > Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add > > > > snd_soc_component_get/put()") causes a regression where trying > > > > to rmmod a codec driver fails with module is in use error after > > > > rmmod of snd-soc-audio-graph-card for example. > > > > > > > > Any ideas what goes wrong there? > > > > > > There is an obvious typo: soc_cleanup_component() should call > > > snd_soc_component_module_put_when_remove() instead of *_close(). > > > > Making that change locally seems to fix it thanks. > > ... and it was already fixed in the later commit 0e36f36b04e7 > "ASoC: soc-core: fix module_put() warning in soc_cleanup_component". Mark, looks like this commit is still not in Linux next, forgot to push out something? Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 131CEC433FF for ; Tue, 13 Aug 2019 10:25:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB50420679 for ; Tue, 13 Aug 2019 10:25:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aEMGOM5x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB50420679 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=quW0ZLazci+Y5gFU8YwCx96Dbq1UZRxOHV/JrwYg+u8=; b=aEMGOM5xaH2HU5 2lWyU4cDLbHnI3E/RYQLeE3JxGWdFbku/U7APvZyNZI2Qf0Gar/IanxZ/VtkkFFahs3JP3QXRvj1C kIAsVpazau2YjPHholfsWxuZ8kU3xGopUXohGOxWwSmh+MCXg4bRNh/ISQdhDsiIlnts65FAGRP3B W7IAXOtivnzghyLv9HixFiecqPCsa090sw7rflhvT/SD3JsxCHwl88VOd0W+bJy7aTu1K0KMkQ6vc vW+PAnLvEhsNhDvfmXI4lyplGN2GvZ8cHA+cdkkQJar2yXfA9RWAMo5x6pJhQJqwiQ55RTpce6T/2 bMUGV0p12kPkSjrjO3qw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxTzD-00069i-9Y; Tue, 13 Aug 2019 10:25:03 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxTzA-0005sN-2A for linux-arm-kernel@lists.infradead.org; Tue, 13 Aug 2019 10:25:01 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 560AE805C; Tue, 13 Aug 2019 10:25:22 +0000 (UTC) Date: Tue, 13 Aug 2019 03:24:51 -0700 From: Tony Lindgren To: Takashi Iwai Subject: Re: [alsa-devel] Regression in next with codec unload and snd_soc_component_get/put Message-ID: <20190813102451.GJ52127@atomide.com> References: <20190809070003.GA52127@atomide.com> <20190809074643.GB52127@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190813_032500_147651_87F3756A X-CRM114-Status: GOOD ( 12.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Kuninori Morimoto , linux-kernel@vger.kernel.org, Jaroslav Kysela , Mark Brown , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Takashi Iwai [190809 08:24]: > On Fri, 09 Aug 2019 09:46:43 +0200, > Tony Lindgren wrote: > > > > * Takashi Iwai [190809 07:25]: > > > On Fri, 09 Aug 2019 09:00:03 +0200, > > > Tony Lindgren wrote: > > > > > > > > Hi, > > > > > > > > Looks like commit 4a81e8f30d0b ("ASoC: soc-component: add > > > > snd_soc_component_get/put()") causes a regression where trying > > > > to rmmod a codec driver fails with module is in use error after > > > > rmmod of snd-soc-audio-graph-card for example. > > > > > > > > Any ideas what goes wrong there? > > > > > > There is an obvious typo: soc_cleanup_component() should call > > > snd_soc_component_module_put_when_remove() instead of *_close(). > > > > Making that change locally seems to fix it thanks. > > ... and it was already fixed in the later commit 0e36f36b04e7 > "ASoC: soc-core: fix module_put() warning in soc_cleanup_component". Mark, looks like this commit is still not in Linux next, forgot to push out something? Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel