From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH for v5.3] ARM: OMAP1: ams-delta-fiq: Fix missing irq_ack Date: Tue, 13 Aug 2019 03:26:08 -0700 Message-ID: <20190813102608.GK52127@atomide.com> References: <20190811084802.630-1-jmkrzyszt@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190811084802.630-1-jmkrzyszt@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Janusz Krzysztofik Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Aaro Koskinen List-Id: linux-omap@vger.kernel.org * Janusz Krzysztofik [190811 01:48]: > Non-serio path of Amstrad Delta FIQ deferred handler depended on > irq_ack() method provided by OMAP GPIO driver. That method has been > removed by commit 693de831c6e5 ("gpio: omap: remove irq_ack method"). > Remove useless code from the deferred handler and reimplement the > missing operation inside the base FIQ handler. > > Should another dependency - irq_unmask() - be ever removed from the OMAP > GPIO driver, WARN once if missing. Thanks applying into fixes. Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FF0CC32750 for ; Tue, 13 Aug 2019 10:26:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75E2920679 for ; Tue, 13 Aug 2019 10:26:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pVCg+XNk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75E2920679 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qo97k959GOb9obrkHxezQen7xpSqM1Ej0EK7FZBlsKk=; b=pVCg+XNk5JBr97 834I7Q7AFSP7bqvSrBHGvhQ/F2Y2fzCiUrSYZm6w4IGlb8unawpoDuiCUos0S+ikMdi5JPZ6st0kb RTkPQwhZDGogTJM32sM+CxLWv6S/9fi1qG3WRtr0iGvxwwO9ASUgNqv27Vx/sTZQEDXa3yI8zBP5k sK0xyPbtwVAPbJiJcPdE5uMlZTsdddaZKZKa2AAzrr55Q6+rIPia1Qnsv/Brqr2I9eVU7gtRYlWMU RDg5w82bPknRAGpmuPWzFslABU/oGNURnrw4xdVOg3MBRDt8AGEKlUF5BmWZPxdhdAFWjBkb8t1tC 53QoIxyjxuXQZI4oqOOw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxU0M-0007M5-VC; Tue, 13 Aug 2019 10:26:14 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxU0J-0007Ln-Sf for linux-arm-kernel@lists.infradead.org; Tue, 13 Aug 2019 10:26:13 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 5C791805C; Tue, 13 Aug 2019 10:26:39 +0000 (UTC) Date: Tue, 13 Aug 2019 03:26:08 -0700 From: Tony Lindgren To: Janusz Krzysztofik Subject: Re: [PATCH for v5.3] ARM: OMAP1: ams-delta-fiq: Fix missing irq_ack Message-ID: <20190813102608.GK52127@atomide.com> References: <20190811084802.630-1-jmkrzyszt@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190811084802.630-1-jmkrzyszt@gmail.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190813_032611_969715_C17742A0 X-CRM114-Status: UNSURE ( 6.23 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Aaro Koskinen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Janusz Krzysztofik [190811 01:48]: > Non-serio path of Amstrad Delta FIQ deferred handler depended on > irq_ack() method provided by OMAP GPIO driver. That method has been > removed by commit 693de831c6e5 ("gpio: omap: remove irq_ack method"). > Remove useless code from the deferred handler and reimplement the > missing operation inside the base FIQ handler. > > Should another dependency - irq_unmask() - be ever removed from the OMAP > GPIO driver, WARN once if missing. Thanks applying into fixes. Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C40BC433FF for ; Tue, 13 Aug 2019 10:26:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 078E220679 for ; Tue, 13 Aug 2019 10:26:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728801AbfHMK0M (ORCPT ); Tue, 13 Aug 2019 06:26:12 -0400 Received: from muru.com ([72.249.23.125]:57106 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727416AbfHMK0L (ORCPT ); Tue, 13 Aug 2019 06:26:11 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 5C791805C; Tue, 13 Aug 2019 10:26:39 +0000 (UTC) Date: Tue, 13 Aug 2019 03:26:08 -0700 From: Tony Lindgren To: Janusz Krzysztofik Cc: Aaro Koskinen , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH for v5.3] ARM: OMAP1: ams-delta-fiq: Fix missing irq_ack Message-ID: <20190813102608.GK52127@atomide.com> References: <20190811084802.630-1-jmkrzyszt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190811084802.630-1-jmkrzyszt@gmail.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Janusz Krzysztofik [190811 01:48]: > Non-serio path of Amstrad Delta FIQ deferred handler depended on > irq_ack() method provided by OMAP GPIO driver. That method has been > removed by commit 693de831c6e5 ("gpio: omap: remove irq_ack method"). > Remove useless code from the deferred handler and reimplement the > missing operation inside the base FIQ handler. > > Should another dependency - irq_unmask() - be ever removed from the OMAP > GPIO driver, WARN once if missing. Thanks applying into fixes. Tony