From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, pbonzini@redhat.com, mst@redhat.com
Cc: peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH 0/2] Fix MemoryRegionSection alignment and comparison
Date: Tue, 13 Aug 2019 11:29:34 +0100 [thread overview]
Message-ID: <20190813102936.32195-1-dgilbert@redhat.com> (raw)
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
This fixes a symptom I've seen on vhost-user on aarch64 where the
daemon would be falsely notified of memory region changes that didn't
exist.
The underlying problem was me memcmp'ing MemoryRegionSections even
though they had padding in.
(Discovered while getting virtiofs working on aarch)
Dave
Dr. David Alan Gilbert (2):
memory: Align and add helper for comparing MemoryRegionSections
vhost: Fix memory region section comparison
hw/virtio/vhost.c | 9 +++++++--
include/exec/memory.h | 14 +++++++++++++-
2 files changed, 20 insertions(+), 3 deletions(-)
--
2.21.0
next reply other threads:[~2019-08-13 10:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 10:29 Dr. David Alan Gilbert (git) [this message]
2019-08-13 10:29 ` [Qemu-devel] [PATCH 1/2] memory: Align and add helper for comparing MemoryRegionSections Dr. David Alan Gilbert (git)
2019-08-13 12:58 ` Philippe Mathieu-Daudé
2019-08-14 17:25 ` Dr. David Alan Gilbert
2019-08-14 17:35 ` Philippe Mathieu-Daudé
2019-08-14 17:44 ` Dr. David Alan Gilbert
2019-08-13 10:29 ` [Qemu-devel] [PATCH 2/2] vhost: Fix memory region section comparison Dr. David Alan Gilbert (git)
2019-08-13 12:06 ` [Qemu-devel] [PATCH 0/2] Fix MemoryRegionSection alignment and comparison Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813102936.32195-1-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.