From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux admin Subject: Re: [PATCH v6 3/8] tda9950: use cec_notifier_cec_adap_(un)register Date: Tue, 13 Aug 2019 12:32:09 +0100 Message-ID: <20190813113209.GF13294@shell.armlinux.org.uk> References: <20190813110300.83025-1-darekm@google.com> <20190813110300.83025-4-darekm@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by gabe.freedesktop.org (Postfix) with ESMTPS id 188B189F47 for ; Tue, 13 Aug 2019 11:32:18 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190813110300.83025-4-darekm@google.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dariusz Marcinkiewicz Cc: Kate Stewart , Kees Cook , David Airlie , open list , dri-devel@lists.freedesktop.org, Hans Verkuil , hverkuil-cisco@xs4all.nl, Colin Ian King , Thomas Gleixner , Allison Randal , linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBBdWcgMTMsIDIwMTkgYXQgMDE6MDI6MzVQTSArMDIwMCwgRGFyaXVzeiBNYXJjaW5r aWV3aWN6IHdyb3RlOgo+IFVzZSB0aGUgbmV3IGNlY19ub3RpZmllcl9jZWNfYWRhcF8odW4pcmVn aXN0ZXIoKSBmdW5jdGlvbnMgdG8KPiAodW4pcmVnaXN0ZXIgdGhlIG5vdGlmaWVyIGZvciB0aGUg Q0VDIGFkYXB0ZXIuCj4gCj4gU2lnbmVkLW9mZi1ieTogRGFyaXVzeiBNYXJjaW5raWV3aWN6IDxk YXJla21AZ29vZ2xlLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBIYW5zIFZlcmt1aWwgPGh2ZXJrdWls LWNpc2NvQHhzNGFsbC5ubD4KPiBUZXN0ZWQtYnk6IEhhbnMgVmVya3VpbCA8aHZlcmt1aWwtY2lz Y29AeHM0YWxsLm5sPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTJjL3RkYTk5NTAuYyB8IDEy ICsrKysrKy0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA2IGRlbGV0 aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTJjL3RkYTk5NTAuYyBi L2RyaXZlcnMvZ3B1L2RybS9pMmMvdGRhOTk1MC5jCj4gaW5kZXggODAzOWZjMGQ4M2RiNC4uYTVh NzViZGViN2E1ZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTJjL3RkYTk5NTAuYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pMmMvdGRhOTk1MC5jCj4gQEAgLTQyMCw3ICs0MjAsOCBA QCBzdGF0aWMgaW50IHRkYTk5NTBfcHJvYmUoc3RydWN0IGkyY19jbGllbnQgKmNsaWVudCwKPiAg CQlwcml2LT5oZG1pID0gZ2x1ZS0+cGFyZW50Owo+ICAKPiAgCXByaXYtPmFkYXAgPSBjZWNfYWxs b2NhdGVfYWRhcHRlcigmdGRhOTk1MF9jZWNfb3BzLCBwcml2LCAidGRhOTk1MCIsCj4gLQkJCQkJ ICBDRUNfQ0FQX0RFRkFVTFRTLAo+ICsJCQkJCSAgQ0VDX0NBUF9ERUZBVUxUUyB8Cj4gKwkJCQkJ ICBDRUNfQ0FQX0NPTk5FQ1RPUl9JTkZPLAo+ICAJCQkJCSAgQ0VDX01BWF9MT0dfQUREUlMpOwo+ ICAJaWYgKElTX0VSUihwcml2LT5hZGFwKSkKPiAgCQlyZXR1cm4gUFRSX0VSUihwcml2LT5hZGFw KTsKPiBAQCAtNDU3LDEzICs0NTgsMTQgQEAgc3RhdGljIGludCB0ZGE5OTUwX3Byb2JlKHN0cnVj dCBpMmNfY2xpZW50ICpjbGllbnQsCj4gIAlpZiAocmV0IDwgMCkKPiAgCQlyZXR1cm4gcmV0Owo+ ICAKPiAtCXByaXYtPm5vdGlmeSA9IGNlY19ub3RpZmllcl9nZXQocHJpdi0+aGRtaSk7Cj4gKwlw cml2LT5ub3RpZnkgPSBjZWNfbm90aWZpZXJfY2VjX2FkYXBfcmVnaXN0ZXIocHJpdi0+aGRtaSwg TlVMTCwKPiArCQkJCQkJICAgICAgcHJpdi0+YWRhcCk7Cj4gIAlpZiAoIXByaXYtPm5vdGlmeSkK PiAgCQlyZXR1cm4gLUVOT01FTTsKPiAgCj4gIAlyZXQgPSBjZWNfcmVnaXN0ZXJfYWRhcHRlcihw cml2LT5hZGFwLCBwcml2LT5oZG1pKTsKPiAgCWlmIChyZXQgPCAwKSB7Cj4gLQkJY2VjX25vdGlm aWVyX3B1dChwcml2LT5ub3RpZnkpOwo+ICsJCWNlY19ub3RpZmllcl9jZWNfYWRhcF91bnJlZ2lz dGVyKHByaXYtPm5vdGlmeSk7Cj4gIAkJcmV0dXJuIHJldDsKPiAgCX0KPiAgCj4gQEAgLTQ3Myw4 ICs0NzUsNiBAQCBzdGF0aWMgaW50IHRkYTk5NTBfcHJvYmUoc3RydWN0IGkyY19jbGllbnQgKmNs aWVudCwKPiAgCSAqLwo+ICAJZGV2bV9yZW1vdmVfYWN0aW9uKGRldiwgdGRhOTk1MF9jZWNfZGVs LCBwcml2KTsKPiAgCj4gLQljZWNfcmVnaXN0ZXJfY2VjX25vdGlmaWVyKHByaXYtPmFkYXAsIHBy aXYtPm5vdGlmeSk7Cj4gLQo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gQEAgLTQ4Miw4ICs0ODIs OCBAQCBzdGF0aWMgaW50IHRkYTk5NTBfcmVtb3ZlKHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQp Cj4gIHsKPiAgCXN0cnVjdCB0ZGE5OTUwX3ByaXYgKnByaXYgPSBpMmNfZ2V0X2NsaWVudGRhdGEo Y2xpZW50KTsKPiAgCj4gKwljZWNfbm90aWZpZXJfY2VjX2FkYXBfdW5yZWdpc3Rlcihwcml2LT5u b3RpZnkpOwo+ICAJY2VjX3VucmVnaXN0ZXJfYWRhcHRlcihwcml2LT5hZGFwKTsKPiAtCWNlY19u b3RpZmllcl9wdXQocHJpdi0+bm90aWZ5KTsKCkl0IGxvb2tzIHdlaXJkIHRvIGhhdmUgYW4gdW5l eHBlY3RlZGx5IGRpZmZlcmVudCBvcmRlcmluZyBvZgp1bnJlZ2lzdHJhdGlvbiBmcm9tIHRoZSBy ZWdpc3RyYXRpb24gcGF0aCAtIG5vcm1hbGx5LCB1bnJlZ2lzdHJhdGlvbgppcyB0aGUgcmV2ZXJz ZSBvcmRlciBvZiBpbml0aWFsaXNhdGlvbi4KCkluIHRoZSBpbml0aWFsaXNhdGlvbiBwYXRoLCBp dCBzZWVtcyB0aGF0IHdlIHJlZ2lzdGVyIHRoZSBub3RpZmllcgphbmQgX3RoZW5fIHRoZSBhZGFw dGVyLiAgSGVyZSwgd2UgdW5yZWdpc3RlciB0aGUgbm90aWZpZXIgYW5kIHRoZW4KdGhlIGFkYXB0 ZXIgcmF0aGVyIHRoYW4gd2hhdCB3b3VsZCBub3JtYWxseSBiZSBleHBlY3RlZC4gIFdoeSBpcwp0 aGlzPyAgSSBzdXNwZWN0IHRoZXJlIHdpbGwgYmUgZHJpdmVycyBjcmVhdGVkIHRoYXQgZG8gdGhp cyB0aGUKIm5vcm1hbCIgd2F5IHJvdW5kLCBzbyBpZiB0aGlzIGlzIGEgcmVxdWlyZW1lbnQsIGl0 IG5lZWRzIHRvIGJlIG1hZGUKcGxhaW5seSBvYnZpb3VzLgoKPiAgCj4gIAlyZXR1cm4gMDsKPiAg fQo+IC0tIAo+IDIuMjMuMC5yYzEuMTUzLmdkZWVkODAzMzBmLWdvb2cKPiAKPiAKCi0tIApSTUsn cyBQYXRjaCBzeXN0ZW06IGh0dHBzOi8vd3d3LmFybWxpbnV4Lm9yZy51ay9kZXZlbG9wZXIvcGF0 Y2hlcy8KRlRUQyBicm9hZGJhbmQgZm9yIDAuOG1pbGUgbGluZSBpbiBzdWJ1cmJpYTogc3luYyBh dCAxMi4xTWJwcyBkb3duIDYyMmticHMgdXAKQWNjb3JkaW5nIHRvIHNwZWVkdGVzdC5uZXQ6IDEx LjlNYnBzIGRvd24gNTAwa2JwcyB1cApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7DF7C32750 for ; Tue, 13 Aug 2019 11:32:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7AF3E2085A for ; Tue, 13 Aug 2019 11:32:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="xiBNoaBz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726826AbfHMLcS (ORCPT ); Tue, 13 Aug 2019 07:32:18 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:35430 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725981AbfHMLcR (ORCPT ); Tue, 13 Aug 2019 07:32:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=8Cz0dhG8JlSQ8zGF79vjEHYxjSQnz3txKDT7QLmjLxw=; b=xiBNoaBz67Ngmks68l8gE5aH5 zIsOBxAGr5sqkC5CdQ/z8Vbf11g0UU9hxKAeoBC2XdOqEHVza2pPKPC2gRpHrzSmVa5P0zsE63NYq uj74WAySYdSqhaW4PJyoDlO+cO/H/2Tt7y1+5yYLkDO1+PdWHQ/iBYmG6VI8nb9Y9swI2R+DBrTSZ yLoL91CwrTeOXy6Om9ZrLhDxUzrFTo3JF3mTUnHjj6diabS0izAT44mUggMhBcPnb4V4h54o5C1bP J+ozu2+DthD3z8XjCqcqEv1nQOfCorWHYk/0eWjzlz41yMWHMQDMtZeKMh5Jx3CvcdrUhL3dxH7xB OBABDGFWA==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:51944) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hxV2D-0008RU-Hh; Tue, 13 Aug 2019 12:32:13 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1hxV29-0007Sy-BL; Tue, 13 Aug 2019 12:32:09 +0100 Date: Tue, 13 Aug 2019 12:32:09 +0100 From: Russell King - ARM Linux admin To: Dariusz Marcinkiewicz Cc: dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, hverkuil-cisco@xs4all.nl, David Airlie , Daniel Vetter , Hans Verkuil , Kate Stewart , Allison Randal , Thomas Gleixner , Kees Cook , Colin Ian King , open list Subject: Re: [PATCH v6 3/8] tda9950: use cec_notifier_cec_adap_(un)register Message-ID: <20190813113209.GF13294@shell.armlinux.org.uk> References: <20190813110300.83025-1-darekm@google.com> <20190813110300.83025-4-darekm@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190813110300.83025-4-darekm@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Tue, Aug 13, 2019 at 01:02:35PM +0200, Dariusz Marcinkiewicz wrote: > Use the new cec_notifier_cec_adap_(un)register() functions to > (un)register the notifier for the CEC adapter. > > Signed-off-by: Dariusz Marcinkiewicz > Signed-off-by: Hans Verkuil > Tested-by: Hans Verkuil > --- > drivers/gpu/drm/i2c/tda9950.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i2c/tda9950.c b/drivers/gpu/drm/i2c/tda9950.c > index 8039fc0d83db4..a5a75bdeb7a5f 100644 > --- a/drivers/gpu/drm/i2c/tda9950.c > +++ b/drivers/gpu/drm/i2c/tda9950.c > @@ -420,7 +420,8 @@ static int tda9950_probe(struct i2c_client *client, > priv->hdmi = glue->parent; > > priv->adap = cec_allocate_adapter(&tda9950_cec_ops, priv, "tda9950", > - CEC_CAP_DEFAULTS, > + CEC_CAP_DEFAULTS | > + CEC_CAP_CONNECTOR_INFO, > CEC_MAX_LOG_ADDRS); > if (IS_ERR(priv->adap)) > return PTR_ERR(priv->adap); > @@ -457,13 +458,14 @@ static int tda9950_probe(struct i2c_client *client, > if (ret < 0) > return ret; > > - priv->notify = cec_notifier_get(priv->hdmi); > + priv->notify = cec_notifier_cec_adap_register(priv->hdmi, NULL, > + priv->adap); > if (!priv->notify) > return -ENOMEM; > > ret = cec_register_adapter(priv->adap, priv->hdmi); > if (ret < 0) { > - cec_notifier_put(priv->notify); > + cec_notifier_cec_adap_unregister(priv->notify); > return ret; > } > > @@ -473,8 +475,6 @@ static int tda9950_probe(struct i2c_client *client, > */ > devm_remove_action(dev, tda9950_cec_del, priv); > > - cec_register_cec_notifier(priv->adap, priv->notify); > - > return 0; > } > > @@ -482,8 +482,8 @@ static int tda9950_remove(struct i2c_client *client) > { > struct tda9950_priv *priv = i2c_get_clientdata(client); > > + cec_notifier_cec_adap_unregister(priv->notify); > cec_unregister_adapter(priv->adap); > - cec_notifier_put(priv->notify); It looks weird to have an unexpectedly different ordering of unregistration from the registration path - normally, unregistration is the reverse order of initialisation. In the initialisation path, it seems that we register the notifier and _then_ the adapter. Here, we unregister the notifier and then the adapter rather than what would normally be expected. Why is this? I suspect there will be drivers created that do this the "normal" way round, so if this is a requirement, it needs to be made plainly obvious. > > return 0; > } > -- > 2.23.0.rc1.153.gdeed80330f-goog > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up