From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB529C32750 for ; Tue, 13 Aug 2019 11:43:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A60020644 for ; Tue, 13 Aug 2019 11:43:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727373AbfHMLnA (ORCPT ); Tue, 13 Aug 2019 07:43:00 -0400 Received: from muru.com ([72.249.23.125]:57192 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726814AbfHMLnA (ORCPT ); Tue, 13 Aug 2019 07:43:00 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id AC96E805C; Tue, 13 Aug 2019 11:43:27 +0000 (UTC) Date: Tue, 13 Aug 2019 04:42:56 -0700 From: Tony Lindgren To: Roger Quadros Cc: Nishka Dasgupta , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] bus: ti-sysc: sysc_check_children(): Change return type to void Message-ID: <20190813114256.GR52127@atomide.com> References: <20190813071714.27970-1-nishkadg.linux@gmail.com> <20190813075553.2354-1-nishkadg.linux@gmail.com> <20190813075553.2354-2-nishkadg.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Roger Quadros [190813 11:14]: > > On 13/08/2019 10:55, Nishka Dasgupta wrote: > > Change return type of function sysc_check_children() from int to void as > > it always returns 0. Remove its return statement as well. > > At call site, remove the variable that was used to store the return > > value, as well as the check on the return value. > > > > You don't need to describe each and everything as it is obvious > from code. How about? > "Change return type of sysc_check_children() to "void" > as it never returns error" > > Should both patches can be squashed into one patch? Sure why not, makes it easier to follow :) Regards, Tony