From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C7EEC32750 for ; Tue, 13 Aug 2019 16:28:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0751420840 for ; Tue, 13 Aug 2019 16:28:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727504AbfHMQ2J (ORCPT ); Tue, 13 Aug 2019 12:28:09 -0400 Received: from foss.arm.com ([217.140.110.172]:40220 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727053AbfHMQ2J (ORCPT ); Tue, 13 Aug 2019 12:28:09 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3C99A337; Tue, 13 Aug 2019 09:28:09 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A68513F706; Tue, 13 Aug 2019 09:28:08 -0700 (PDT) Date: Tue, 13 Aug 2019 17:28:06 +0100 From: Dave Martin To: Cristian Marussi Cc: linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 11/11] kselftest: arm64: fake_sigreturn_misaligned_sp Message-ID: <20190813162806.GJ10425@arm.com> References: <20190802170300.20662-1-cristian.marussi@arm.com> <20190802170300.20662-12-cristian.marussi@arm.com> <8811be0d-efb3-b6da-9f6b-acaeb3edce7d@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8811be0d-efb3-b6da-9f6b-acaeb3edce7d@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Wed, Aug 07, 2019 at 05:04:13PM +0100, Cristian Marussi wrote: > On 02/08/2019 18:03, Cristian Marussi wrote: > > Added a simple fake_sigreturn testcase which places a valid > > sigframe on a non-16 bytes aligned SP. > > fake_sigretrun() helper function has been patched accordingly > > to support placing a sigframe on a non-16 bytes aligned address. > > Expects a SIGSEGV on test PASS. > > > > Adds also a test TODO lists holding some further test ideas. > > > > Signed-off-by: Cristian Marussi > > --- > > Re-added this text after fixing the forced misaglinment procedure in > > fake_sigreturn() itself: require a ZERO alignment and you'll get > > your sigframe placed on a misaligned SP (2-bytes off the 16-align) > > --- > > .../testing/selftests/arm64/signal/signals.S | 21 +++++++++---- > > .../arm64/signal/testcases/TODO.readme | 8 +++++ > > .../testcases/fake_sigreturn_misaligned_sp.c | 30 +++++++++++++++++++ > > 3 files changed, 53 insertions(+), 6 deletions(-) > > create mode 100644 tools/testing/selftests/arm64/signal/testcases/TODO.readme > > create mode 100644 tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_misaligned_sp.c > > > > When this test was re-added in V3, the related .gitignore was missed. > It will go in V4 Ack, or otherwise try switching to using wildcards in .gitignore as suggested in my reply to patch 4. [...] Cheers ---Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C90AC32750 for ; Tue, 13 Aug 2019 16:30:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2280A20679 for ; Tue, 13 Aug 2019 16:30:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VFEvVXXh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2280A20679 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pEAQMNSNeYYiVAdYbq1vCEN6DRQpVI6ZqRGa1cQqw4o=; b=VFEvVXXh+/HIBT tezY0yjztD8i0SnkkaFiKvhp5bbNyRHbuGjnTcXxY8J8dck6dTolfo5pP1K080x7XD16plSJx+299 em6IOGH6DR/3ZHhO6EtIEAwP+bwMSIIkMYHF14HF5lq03ORuwJYPFmYJ/VfcTY/V4Zf0RtzEfAU7T 1JanpbI5o+YW1+KeI4rAjGblW84guktFxjqvYa77Cr5fxRsnYkhUoZtqrAVzzZ6nTSs4y3jmH07Si d7HxCGkP0iD3aueuWWURaHDk7jMYiJfEmuF0T9Nn0MfeidNFwyNuCoD093gMa9OiPniwJLQZ9Iney G7pYC3thf6Hb24Jz9u8A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxZgX-000229-4B; Tue, 13 Aug 2019 16:30:09 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxZeb-00083c-Tr for linux-arm-kernel@lists.infradead.org; Tue, 13 Aug 2019 16:28:11 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3C99A337; Tue, 13 Aug 2019 09:28:09 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A68513F706; Tue, 13 Aug 2019 09:28:08 -0700 (PDT) Date: Tue, 13 Aug 2019 17:28:06 +0100 From: Dave Martin To: Cristian Marussi Subject: Re: [PATCH v3 11/11] kselftest: arm64: fake_sigreturn_misaligned_sp Message-ID: <20190813162806.GJ10425@arm.com> References: <20190802170300.20662-1-cristian.marussi@arm.com> <20190802170300.20662-12-cristian.marussi@arm.com> <8811be0d-efb3-b6da-9f6b-acaeb3edce7d@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8811be0d-efb3-b6da-9f6b-acaeb3edce7d@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190813_092810_254122_B90439C3 X-CRM114-Status: GOOD ( 14.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 07, 2019 at 05:04:13PM +0100, Cristian Marussi wrote: > On 02/08/2019 18:03, Cristian Marussi wrote: > > Added a simple fake_sigreturn testcase which places a valid > > sigframe on a non-16 bytes aligned SP. > > fake_sigretrun() helper function has been patched accordingly > > to support placing a sigframe on a non-16 bytes aligned address. > > Expects a SIGSEGV on test PASS. > > > > Adds also a test TODO lists holding some further test ideas. > > > > Signed-off-by: Cristian Marussi > > --- > > Re-added this text after fixing the forced misaglinment procedure in > > fake_sigreturn() itself: require a ZERO alignment and you'll get > > your sigframe placed on a misaligned SP (2-bytes off the 16-align) > > --- > > .../testing/selftests/arm64/signal/signals.S | 21 +++++++++---- > > .../arm64/signal/testcases/TODO.readme | 8 +++++ > > .../testcases/fake_sigreturn_misaligned_sp.c | 30 +++++++++++++++++++ > > 3 files changed, 53 insertions(+), 6 deletions(-) > > create mode 100644 tools/testing/selftests/arm64/signal/testcases/TODO.readme > > create mode 100644 tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_misaligned_sp.c > > > > When this test was re-added in V3, the related .gitignore was missed. > It will go in V4 Ack, or otherwise try switching to using wildcards in .gitignore as suggested in my reply to patch 4. [...] Cheers ---Dave _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel