From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F8E3C433FF for ; Tue, 13 Aug 2019 20:16:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3FD4720651 for ; Tue, 13 Aug 2019 20:16:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="FeSjjDYf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726835AbfHMUQn (ORCPT ); Tue, 13 Aug 2019 16:16:43 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:58218 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725944AbfHMUQm (ORCPT ); Tue, 13 Aug 2019 16:16:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UI6tMJpgEbq+gOgrpocJOsbqLUm7faizOZvfBoBgtZE=; b=FeSjjDYfiUTyS13m9LbRU3cCsN 37Zbkng9V4MIGYsuKTjjKAVXkeloQMEDne6pDMldjVyXfIWGAgxR95kqQ3N+2puwUZ3ng8h9Ud9i8 yUOFMcYCgphAbUdaOOoYKLu2udHOHuXxcH0O5j/k9YxoGwfy6JN0YLPrJ8fcV8vIwrC4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hxdDj-0004N8-FT; Tue, 13 Aug 2019 22:16:39 +0200 Date: Tue, 13 Aug 2019 22:16:39 +0200 From: Andrew Lunn To: Heiner Kallweit Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next v2 2/3] net: phy: add phy_speed_down_core and phy_resolve_min_speed Message-ID: <20190813201639.GN15047@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Aug 12, 2019 at 11:51:27PM +0200, Heiner Kallweit wrote: > phy_speed_down_core provides most of the functionality for > phy_speed_down. It makes use of new helper phy_resolve_min_speed that is > based on the sorting of the settings[] array. In certain cases it may be > helpful to be able to exclude legacy half duplex modes, therefore > prepare phy_resolve_min_speed() for it. > > v2: > - rename __phy_speed_down to phy_speed_down_core > > Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Andrew