From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 330A3C32753 for ; Wed, 14 Aug 2019 08:56:04 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0ECDB205F4 for ; Wed, 14 Aug 2019 08:56:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0ECDB205F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id D7287C6A; Wed, 14 Aug 2019 08:56:03 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 15544C51 for ; Wed, 14 Aug 2019 08:56:02 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 9773DCF for ; Wed, 14 Aug 2019 08:56:01 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 2F9242E2; Wed, 14 Aug 2019 10:55:59 +0200 (CEST) Date: Wed, 14 Aug 2019 10:55:57 +0200 From: Joerg Roedel To: Kai-Heng Feng Subject: Re: [PATCH] iommu/amd: Override wrong IVRS IOAPIC on Raven Ridge systems Message-ID: <20190814085557.GB24321@8bytes.org> References: <20190808101707.16783-1-kai.heng.feng@canonical.com> <20190809153931.GG12930@8bytes.org> <9CDD544D-DE4C-4AC6-B0DC-CD30C99EA71C@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9CDD544D-DE4C-4AC6-B0DC-CD30C99EA71C@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org T24gVHVlLCBBdWcgMTMsIDIwMTkgYXQgMTE6NTg6NDhBTSArMDgwMCwgS2FpLUhlbmcgRmVuZyB3 cm90ZToKPiBhdCAyMzozOSwgSm9lcmcgUm9lZGVsIDxqb3JvQDhieXRlcy5vcmc+IHdyb3RlOgo+ IAo+ID4gT24gVGh1LCBBdWcgMDgsIDIwMTkgYXQgMDY6MTc6MDdQTSArMDgwMCwgS2FpLUhlbmcg RmVuZyB3cm90ZToKPiA+ID4gUmF2ZW4gUmlkZ2Ugc3lzdGVtcyBtYXkgaGF2ZSBtYWxmdW5jdGlv biB0b3VjaHBhZCBvciBoYW5nIGF0IGJvb3QgaWYKPiA+ID4gaW5jb3JyZWN0IElWUlMgSU9BUElD IGlzIHByb3ZpZGVkIGJ5IEJJT1MuCj4gPiA+IAo+ID4gPiBVc2VycyBhbHJlYWR5IGZvdW5kIGNv cnJlY3QgIml2cnNfaW9hcGljPSIgdmFsdWVzLCBsZXQncyBwdXQgdGhlbSBpbnNpZGUKPiA+ID4g a2VybmVsIHRvIHdvcmthcm91bmQgYnVnZ3kgQklPUy4KPiA+IAo+ID4gV2lsbCB0aGF0IHN0aWxs IHdvcmsgd2hlbiBhIGZpeGVkIEJJT1MgZm9yIHRoZXNlIGxhcHRvcHMgaXMgcmVsZWFzZWQ/Cj4g Cj4gRG8geW91IG1lYW4gdGhhdCB3ZSBzaG91bGQgc3RvcCBhcHBseWluZyB0aGVzZSBxdWlya3Mg b25jZSBhIEJJT1MgZml4IGlzCj4gY29uZmlybWVkPwoKTXkgY29uY2VybiBpcyBqdXN0IHRoYXQg dGhlc2UgcXVpcmtzIGJyZWFrIHNvbWUgc3lzdGVtcyB0aGF0IGRvbid0IG5lZWQKdGhlbS4KCj4g V2UgY2FuIG1vZGlmeSB0aGUgcXVpcmsgdG8gY29tcGFyZSBCSU9TIHZlcnNpb24sIGlmIHRoZXJl 4oCZcyBhbiB1bmxpa2VseSBCSU9TCj4gdXBkYXRlIHJlYWxseSBmaXhlcyB0aGUgaXNzdWUuCj4g QmVmb3JlIHRoYXQgaGFwcGVucywgSSB0aGluayBpdOKAmXMgT0sgdG8gbGV0IHRoZSBxdWlya3Mg c3RheSB0aGlzIHdheS4KCkEgQklPUyB2ZXJzaW9uIGNoZWNrIGlzIG5vdCBtYWtpbmcgdGhpbmdz IGJldHRlciBoZXJlIGFzIGl0IG1pZ2h0IGxvY2sKb3V0IHN5c3RlbXMgdGhhdCBuZWVkIHRoZSBx dWlyay4gSSB0aGluayB3ZSBjYW4gbGVhdmUgaXQgYXMgaXQgZm9yIG5vdywKYnV0IGNhbiB5b3Ug Y3JlYXRlIGEgbmV3IGZpbGUgYW1kX2lvbW11X3F1aXJrcy5jIGFuZCBtb3ZlIHRoZSBjb2RlCnRo ZXJlLiBBbmQgaW4gdGhlIHN0cnVjdCBhbmQgZnVuY3Rpb24gbmFtZXMgcGxlYXNlIG1ha2UgY2xl YXIgdGhhdCBpdCBpcwphYm91dCBpdnJzLXF1aXJrcy4KCgpSZWdhcmRzLAoKCUpvZXJnCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlvbW11IG1haWxpbmcg bGlzdAppb21tdUBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4 Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby9pb21tdQ== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25FE6C433FF for ; Wed, 14 Aug 2019 08:56:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 02A0C205F4 for ; Wed, 14 Aug 2019 08:56:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726162AbfHNI4C (ORCPT ); Wed, 14 Aug 2019 04:56:02 -0400 Received: from 8bytes.org ([81.169.241.247]:49216 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725888AbfHNI4B (ORCPT ); Wed, 14 Aug 2019 04:56:01 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id 2F9242E2; Wed, 14 Aug 2019 10:55:59 +0200 (CEST) Date: Wed, 14 Aug 2019 10:55:57 +0200 From: Joerg Roedel To: Kai-Heng Feng Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/amd: Override wrong IVRS IOAPIC on Raven Ridge systems Message-ID: <20190814085557.GB24321@8bytes.org> References: <20190808101707.16783-1-kai.heng.feng@canonical.com> <20190809153931.GG12930@8bytes.org> <9CDD544D-DE4C-4AC6-B0DC-CD30C99EA71C@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9CDD544D-DE4C-4AC6-B0DC-CD30C99EA71C@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 13, 2019 at 11:58:48AM +0800, Kai-Heng Feng wrote: > at 23:39, Joerg Roedel wrote: > > > On Thu, Aug 08, 2019 at 06:17:07PM +0800, Kai-Heng Feng wrote: > > > Raven Ridge systems may have malfunction touchpad or hang at boot if > > > incorrect IVRS IOAPIC is provided by BIOS. > > > > > > Users already found correct "ivrs_ioapic=" values, let's put them inside > > > kernel to workaround buggy BIOS. > > > > Will that still work when a fixed BIOS for these laptops is released? > > Do you mean that we should stop applying these quirks once a BIOS fix is > confirmed? My concern is just that these quirks break some systems that don't need them. > We can modify the quirk to compare BIOS version, if there’s an unlikely BIOS > update really fixes the issue. > Before that happens, I think it’s OK to let the quirks stay this way. A BIOS version check is not making things better here as it might lock out systems that need the quirk. I think we can leave it as it for now, but can you create a new file amd_iommu_quirks.c and move the code there. And in the struct and function names please make clear that it is about ivrs-quirks. Regards, Joerg