From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74C38C32753 for ; Wed, 14 Aug 2019 09:12:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4705F20843 for ; Wed, 14 Aug 2019 09:12:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="brdZkpk1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4705F20843 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j9t6vYxgWFJyXDBhCPWFqzFNQ83d+5TNEr/cZmmWEKM=; b=brdZkpk1c/Klv+ YSIMlxATdaApRBinBP61iv/Bc6niSw5ap7eFKGQ0/Hs2+vZDV2b2PLtWkpQPJfCuT7GwbUeH1s2TI 5wPJIjmOIeo82res8z8+XcoQphqSxUD8dGL9wDz4TxmYyqYWDbEHbfcAzwdWOcu13+Q2gX8UxGuMU NdlqvIGjfGBxUY6v9fUAJ1N94RxmeD5dX+ER1Gq/PQNWOOql4dYQ+FXh+3Np0NeXxsjGDsxLR65Ac 2Yw9D5aHDWSixLOQFMt40PodHnV/kI12IHzxuIkE8CSaOBxmF8vH9tKdsJiRLaV/pdBNxlW60FcDg 52xeuQPgqTw7om+vU9RA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxpKk-0005c9-Ld; Wed, 14 Aug 2019 09:12:42 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxpKf-0005ZE-Uo for linux-arm-kernel@lists.infradead.org; Wed, 14 Aug 2019 09:12:39 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6FD66344; Wed, 14 Aug 2019 02:12:37 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BBF1A3F694; Wed, 14 Aug 2019 02:12:36 -0700 (PDT) Date: Wed, 14 Aug 2019 10:12:34 +0100 From: Dave Martin To: Mark Rutland Subject: Re: [PATCH 3/3] arm64: constify sys64_hook instances Message-ID: <20190814091234.GM10425@arm.com> References: <20190813141639.13476-1-mark.rutland@arm.com> <20190813141639.13476-4-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190813141639.13476-4-mark.rutland@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190814_021238_127510_CC91D8DA X-CRM114-Status: GOOD ( 15.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, will.deacon@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 13, 2019 at 03:16:39PM +0100, Mark Rutland wrote: > All instances of struct sys64_hook contain compile-time constant data, > and are never inentionally modified, so let's make them all const. > > Signed-off-by: Mark Rutland > Cc: Catalin Marinas > Cc: Will Deacon > --- > arch/arm64/kernel/traps.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c > index 42c8422cdf4a..a5d7ce4297b0 100644 > --- a/arch/arm64/kernel/traps.c > +++ b/arch/arm64/kernel/traps.c > @@ -511,7 +511,7 @@ struct sys64_hook { > void (*handler)(unsigned int esr, struct pt_regs *regs); > }; > > -static struct sys64_hook sys64_hooks[] = { > +static const struct sys64_hook sys64_hooks[] = { > { > .esr_mask = ESR_ELx_SYS64_ISS_EL0_CACHE_OP_MASK, > .esr_val = ESR_ELx_SYS64_ISS_EL0_CACHE_OP_VAL, > @@ -636,7 +636,7 @@ static void compat_cntfrq_read_handler(unsigned int esr, struct pt_regs *regs) > arm64_compat_skip_faulting_instruction(regs, 4); > } > > -static struct sys64_hook cp15_32_hooks[] = { > +static const struct sys64_hook cp15_32_hooks[] = { > { > .esr_mask = ESR_ELx_CP15_32_ISS_SYS_MASK, > .esr_val = ESR_ELx_CP15_32_ISS_SYS_CNTFRQ, > @@ -656,7 +656,7 @@ static void compat_cntvct_read_handler(unsigned int esr, struct pt_regs *regs) > arm64_compat_skip_faulting_instruction(regs, 4); > } > > -static struct sys64_hook cp15_64_hooks[] = { > +static const struct sys64_hook cp15_64_hooks[] = { > { > .esr_mask = ESR_ELx_CP15_64_ISS_SYS_MASK, > .esr_val = ESR_ELx_CP15_64_ISS_SYS_CNTVCT, > @@ -667,7 +667,7 @@ static struct sys64_hook cp15_64_hooks[] = { > > asmlinkage void __exception do_cp15instr(unsigned int esr, struct pt_regs *regs) > { > - struct sys64_hook *hook, *hook_base; > + const struct sys64_hook *hook, *hook_base; > > if (!cp15_cond_valid(esr, regs)) { > /* > @@ -707,7 +707,7 @@ asmlinkage void __exception do_cp15instr(unsigned int esr, struct pt_regs *regs) > > asmlinkage void __exception do_sysinstr(unsigned int esr, struct pt_regs *regs) > { > - struct sys64_hook *hook; > + const struct sys64_hook *hook; > > for (hook = sys64_hooks; hook->handler; hook++) > if ((hook->esr_mask & esr) == hook->esr_val) { Reviewed-by: Dave Martin Cheers ---Dave _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel