All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [EXT] Re: [PATCH v4 1/5] spl: dm: disable SPI DM flash for non-DM SPL
Date: Wed, 14 Aug 2019 12:52:40 +0200	[thread overview]
Message-ID: <20190814125240.18fa2a8e@jawa> (raw)
In-Reply-To: <AM6PR04MB435739F1DC1C06317433BD2297AD0@AM6PR04MB4357.eurprd04.prod.outlook.com>

On Wed, 14 Aug 2019 10:41:32 +0000
Chuanhua Han <chuanhua.han@nxp.com> wrote:

> > -----Original Message-----
> > From: Lukasz Majewski <lukma@denx.de>
> > Sent: 2019年8月14日 16:57
> > To: Chuanhua Han <chuanhua.han@nxp.com>
> > Cc: Jagan Teki <jagan@amarulasolutions.com>; Xiaowei Bao
> > <xiaowei.bao@nxp.com>; U-Boot-Denx <u-boot@lists.denx.de>; Pan
> > Jiafei <Jiafei.Pan@freescale.com>; Jagan Teki <jagan@openedev.com>;
> > Ruchika Gupta <ruchika.gupta@nxp.com>
> > Subject: Re: [U-Boot] [EXT] Re: [PATCH v4 1/5] spl: dm: disable SPI
> > DM flash for non-DM SPL
> > 
> > Hi Chuanhua,
> >   
> > > > -----Original Message-----
> > > > From: Jagan Teki <jagan@amarulasolutions.com>
> > > > Sent: 2019年8月14日 15:45
> > > > To: Chuanhua Han <chuanhua.han@nxp.com>
> > > > Cc: Wolfgang Denk <wd@denx.de>; Shengzhou Liu
> > > > <shengzhou.liu@nxp.com>; Ruchika Gupta <ruchika.gupta@nxp.com>;
> > > > Jagan Teki <jagan@openedev.com>; Simon Glass <sjg@chromium.org>;
> > > > Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; U-Boot-Denx
> > > > <u-boot@lists.denx.de>; Pan Jiafei <Jiafei.Pan@freescale.com>
> > > > Subject: [EXT] Re: [U-Boot] [PATCH v4 1/5] spl: dm: disable SPI
> > > > DM flash for non-DM SPL
> > > >
> > > > Caution: EXT Email
> > > >
> > > > On Fri, Jun 21, 2019 at 7:51 AM Chuanhua Han
> > > > <chuanhua.han@nxp.com> wrote:  
> > > > >
> > > > > This patch solves the problem that spiboot cannot be
> > > > > performed in non-DM SPL.
> > > > >
> > > > > Signed-off-by: Pan Jiafei <Jiafei.Pan@freescale.com>
> > > > > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> > > > > ---
> > > > > Changes in v4:
> > > > >         - No change.
> > > > > Changes in v3:
> > > > >         - Add a cover-letter for this patch set.
> > > > > Changes in v2:
> > > > >         - No change.
> > > > >
> > > > >  include/config_uncmd_spl.h | 1 +
> > > > >  1 file changed, 1 insertion(+)
> > > > >
> > > > > diff --git a/include/config_uncmd_spl.h
> > > > > b/include/config_uncmd_spl.h index c2f9735ce7..da94b3d9df
> > > > > 100644 --- a/include/config_uncmd_spl.h
> > > > > +++ b/include/config_uncmd_spl.h
> > > > > @@ -15,6 +15,7 @@
> > > > >  #undef CONFIG_DM_GPIO
> > > > >  #undef CONFIG_DM_I2C
> > > > >  #undef CONFIG_DM_SPI
> > > > > +#undef CONFIG_DM_SPI_FLASH  
> > > >
> > > > Have you made any Travis-CI run?  
> > > I tested it with a local board  
> > 
> > Could you be so kind and also test following patchset (parts from
> > Layerscape also needs testing):
> > https://patchwork.ozlabs.org/cover/1146494/  
> I don't quite understand this patch. How can I test it?

You need to apply it first to -master branch.

Then apply your board code (or if it is already in mainline just remove
the #undef(s) from include/config_uncmd_spl.h)

As a last step - run make menuconfig and enable SPL_DM_SPI* flags.

> > 
> > Which allows removal of
> > #undef CONFIG_DM_SPI
> > #undef CONFIG_DM_SPI_FLASH
> > 
> > and have the same configuration done via Kconfig ?  
> 
> >   
> > > _______________________________________________
> > > U-Boot mailing list
> > > U-Boot at lists.denx.de
> > > https://lists.denx.de/listinfo/u-boot  
> > 
> > 
> > 
> > Best regards,
> > 
> > Lukasz Majewski
> > 
> > --
> > 
> > DENX Software Engineering GmbH,      Managing Director: Wolfgang
> > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> > Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> > lukma at denx.de  



Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190814/728d0523/attachment.sig>

  reply	other threads:[~2019-08-14 10:52 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-21  2:21 [U-Boot] [PATCH v4 0/5] dm: spi: Convert Freescale ESPI driver to driver Chuanhua Han
2019-06-21  2:21 ` [U-Boot] [PATCH v4 1/5] spl: dm: disable SPI DM flash for non-DM SPL Chuanhua Han
2019-08-14  7:44   ` Jagan Teki
2019-08-14  8:32     ` [U-Boot] [EXT] " Chuanhua Han
2019-08-14  8:57       ` Lukasz Majewski
2019-08-14  9:01         ` Chuanhua Han
2019-08-14 10:41         ` Chuanhua Han
2019-08-14 10:52           ` Lukasz Majewski [this message]
2019-08-14 11:10             ` Chuanhua Han
2019-08-14 11:38               ` Lukasz Majewski
2019-08-15  3:35                 ` Chuanhua Han
2019-08-15  7:14                   ` Lukasz Majewski
2019-08-15  7:39                     ` Chuanhua Han
2019-08-15  7:53                       ` Lukasz Majewski
2019-08-15  7:57                         ` Chuanhua Han
2019-08-15  8:12                           ` Lukasz Majewski
2019-06-21  2:21 ` [U-Boot] [PATCH v4 2/5] dm: spi: Convert Freescale ESPI driver to driver model Chuanhua Han
2019-06-24  4:02   ` Chuanhua Han
2019-08-14  7:38   ` Jagan Teki
2019-08-14 10:01     ` [U-Boot] [EXT] " Chuanhua Han
2019-08-14 18:02       ` Jagan Teki
2019-08-15  3:59         ` Chuanhua Han
2019-06-21  2:22 ` [U-Boot] [PATCH v4 3/5] powerpc: dts: t2080: add espi controller node support Chuanhua Han
2019-08-14  5:53   ` Prabhakar Kushwaha
2019-06-21  2:22 ` [U-Boot] [PATCH v4 4/5] powerpc: dts: t2080qds: add espi slave nodes support Chuanhua Han
2019-08-14  5:53   ` Prabhakar Kushwaha
2019-06-21  2:22 ` [U-Boot] [PATCH v4 5/5] configs: enable espi device module in T2080QDS Chuanhua Han
2019-06-21  4:07 ` [U-Boot] [PATCH v4 0/5] dm: spi: Convert Freescale ESPI driver to driver Prabhakar Kushwaha
2019-08-14  5:47 ` Prabhakar Kushwaha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190814125240.18fa2a8e@jawa \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.