From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 14 Aug 2019 18:14:43 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20190814171443.GR2920@work-vm> References: <5D478C13.3020406@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5D478C13.3020406@huawei.com> Subject: Re: [Virtio-fs] [PATCH] virtiofsd: move assert just after calloc() List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: piaojun Cc: virtio-fs@redhat.com * piaojun (piaojun@huawei.com) wrote: > It's better to assert NULL pointer just after calloc(). > > Signed-off-by: Jun Piao Thanks, squashed into 'virtiofsd: Start queue threads' Dave > --- > contrib/virtiofsd/fuse_virtio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/virtiofsd/fuse_virtio.c b/contrib/virtiofsd/fuse_virtio.c > index d543c6d..8a4f627 100644 > --- a/contrib/virtiofsd/fuse_virtio.c > +++ b/contrib/virtiofsd/fuse_virtio.c > @@ -748,9 +748,9 @@ static void fv_queue_set_started(VuDev *dev, int qidx, bool started) > } > if (!vud->qi[qidx]) { > vud->qi[qidx] = calloc(sizeof(struct fv_QueueInfo), 1); > + assert(vud->qi[qidx]); > vud->qi[qidx]->virtio_dev = vud; > vud->qi[qidx]->qidx = qidx; > - assert(vud->qi[qidx]); > } else { > /* Shouldn't have been started */ > assert(vud->qi[qidx]->kick_fd == -1); > -- > > _______________________________________________ > Virtio-fs mailing list > Virtio-fs@redhat.com > https://www.redhat.com/mailman/listinfo/virtio-fs -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK