From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D521C433FF for ; Wed, 14 Aug 2019 19:10:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3DBC52084F for ; Wed, 14 Aug 2019 19:10:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565809830; bh=z/HCDdVTf+ZmWoLcJCD2ve3MplQWjIz9ntK4lWui9Rk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=DflEHz9tuwgQrj/tVRqQxdcteq9GYXLmQOafKIMfktRWCKTp/pc7VNIFUtK5iZ8Sc L9LslbVD2xcSK9z88Ryhxa3oIs1rAvYRMZoIzGKhyP1jY3USxb2hsx9f/g8TvMaFoj P9vAsIXWd/xw6L1cpmOhs5hbESDQPykBbgrolK+Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728233AbfHNTK3 (ORCPT ); Wed, 14 Aug 2019 15:10:29 -0400 Received: from mga05.intel.com ([192.55.52.43]:34832 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727558AbfHNTK3 (ORCPT ); Wed, 14 Aug 2019 15:10:29 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2019 12:10:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,386,1559545200"; d="scan'208";a="352008658" Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by orsmga005.jf.intel.com with ESMTP; 14 Aug 2019 12:10:27 -0700 Date: Wed, 14 Aug 2019 13:08:15 -0600 From: Keith Busch To: "Guilherme G. Piccoli" Cc: "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" , "axboe@fb.com" , "hch@lst.de" , "sagi@grimberg.me" , "jay.vosburgh@canonical.com" , Dan Streetman Subject: Re: [PATCH] nvme: Use first ctrl->instance id as subsystem id Message-ID: <20190814190814.GC3256@localhost.localdomain> References: <20190814142836.2322-1-gpiccoli@canonical.com> <20190814160640.GA3256@localhost.localdomain> <20190814162754.GB3256@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Aug 14, 2019 at 11:29:17AM -0700, Guilherme G. Piccoli wrote: > It is a suggestion from my colleague Dan (CCed here), something like: > for non-multipath nvme, keep nvmeC and nvmeCnN (C=controller ida, > N=namespace); for multipath nvme, use nvmeScCnN (S=subsystem ida). This will inevitably lead to collisions. The existing naming scheme was selected specifically to avoid that problem. From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbusch@kernel.org (Keith Busch) Date: Wed, 14 Aug 2019 13:08:15 -0600 Subject: [PATCH] nvme: Use first ctrl->instance id as subsystem id In-Reply-To: References: <20190814142836.2322-1-gpiccoli@canonical.com> <20190814160640.GA3256@localhost.localdomain> <20190814162754.GB3256@localhost.localdomain> Message-ID: <20190814190814.GC3256@localhost.localdomain> On Wed, Aug 14, 2019@11:29:17AM -0700, Guilherme G. Piccoli wrote: > It is a suggestion from my colleague Dan (CCed here), something like: > for non-multipath nvme, keep nvmeC and nvmeCnN (C=controller ida, > N=namespace); for multipath nvme, use nvmeScCnN (S=subsystem ida). This will inevitably lead to collisions. The existing naming scheme was selected specifically to avoid that problem.