From: Scott Bauer <sbauer@plzdonthack.me>
To: Revanth Rajashekar <revanth.rajashekar@intel.com>
Cc: linux-block@vger.kernel.org,
Jonathan Derrick <jonathan.derrick@intel.com>
Subject: Re: [PATCH 3/3] block: sed-opal: OPAL_METHOD_LENGTH defined twice
Date: Thu, 15 Aug 2019 00:07:41 -0400 [thread overview]
Message-ID: <20190815040741.GC31938@hacktheplanet> (raw)
In-Reply-To: <20190813214340.15533-4-revanth.rajashekar@intel.com>
On Tue, Aug 13, 2019 at 03:43:40PM -0600, Revanth Rajashekar wrote:
> Signed-off-by: Revanth Rajashekar <revanth.rajashekar@intel.com>
Reviewed-by: Scott Bauer <sbauer@plzdonthack.me>
Two things,
Can we also change the title of this commit to:
"Removed duplicate OPAL_METHOD_LENGTH definition"
2nd, I'm dumb as hell now adays, why doesn't this throw a compiler error for multiple declarations?
next prev parent reply other threads:[~2019-08-15 4:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 21:43 [PATCH 0/3] block: sed-opal: Code Cleanup Patches Revanth Rajashekar
2019-08-13 21:43 ` [PATCH 1/3] block: sed-opal: Add/remove spaces Revanth Rajashekar
2019-08-14 20:26 ` Derrick, Jonathan
2019-08-15 4:01 ` Scott Bauer
2019-08-13 21:43 ` [PATCH 2/3] block: sed-opal: Eliminating the dead error Revanth Rajashekar
2019-08-14 20:33 ` Derrick, Jonathan
2019-08-15 4:03 ` Scott Bauer
2019-08-13 21:43 ` [PATCH 3/3] block: sed-opal: OPAL_METHOD_LENGTH defined twice Revanth Rajashekar
2019-08-14 20:34 ` Derrick, Jonathan
2019-08-15 4:07 ` Scott Bauer [this message]
2019-08-15 16:08 ` Rajashekar, Revanth
2019-08-13 22:28 ` [PATCH 0/3] block: sed-opal: Code Cleanup Patches Derrick, Jonathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815040741.GC31938@hacktheplanet \
--to=sbauer@plzdonthack.me \
--cc=jonathan.derrick@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=revanth.rajashekar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.