From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A924C433FF for ; Thu, 15 Aug 2019 06:53:05 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82F0B2084D for ; Thu, 15 Aug 2019 06:53:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82F0B2084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 468HG63C5DzDr3M for ; Thu, 15 Aug 2019 16:53:02 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=lst.de Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 468HDH140bzDqJh for ; Thu, 15 Aug 2019 16:51:25 +1000 (AEST) Received: by verein.lst.de (Postfix, from userid 2407) id CCA2068B02; Thu, 15 Aug 2019 08:51:17 +0200 (CEST) Date: Thu, 15 Aug 2019 08:51:17 +0200 From: Christoph Hellwig To: Rob Clark Subject: Re: [PATCH 0/6] drm+dma: cache support for arm, etc Message-ID: <20190815065117.GA23761@lst.de> References: <20190814220011.26934-1-robdclark@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190814220011.26934-1-robdclark@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kate Stewart , Masayoshi Mizuma , "Maciej W. Rozycki" , Eric Biggers , Catalin Marinas , Imre Deak , dri-devel@lists.freedesktop.org, Chris Wilson , Masahiro Yamada , Benjamin Gaignard , Mauro Carvalho Chehab , Will Deacon , Christoph Hellwig , Emil Velikov , Rob Clark , Mike Rapoport , Geert Uytterhoeven , "moderated list:ARM64 PORT \(AARCH64 ARCHITECTURE\)" , Daniel Vetter , "open list:MIPS" , Linus Walleij , Robin Murphy , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Deepak Sharma , Joerg Roedel , Arnd Bergmann , Anshuman Khandual , Hauke Mehrtens , Jesper Dangaard Brouer , "Wolfram Sang \(Renesas\)" , "open list:LINUX FOR POWERPC \(32-BIT AND 64-BIT\)" , Alexios Zavras , Russell King , Doug Anderson , Thomas Gleixner , Sean Paul , Allison Randal , Enrico Weigelt , Ard Biesheuvel , Greg Kroah-Hartman , open list , Paul Burton , Souptick Joarder , Andrew Morton , "open list:DRM DRIVER FOR MSM ADRENO GPU" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" As said before I don't think these low-level helpers are the right API to export, but even if they did you'd just cover a tiny subset of the architectures. Also to distil the previous thread - if you remap memory to uncached the helper to use is arch_dma_prep_coherent, which does a writeback+ invalidate everywhere, and there is no need to clean up after a long-term uncached mapping. We might still get speculations into that area, if we don't remap the direct mapping, but it isn't like invalidting that just before freeing the memory is going to help anyone. Also it seems like patches 5 and 6 are missing in my inbox. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF6E2C433FF for ; Thu, 15 Aug 2019 06:51:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9DA64205F4 for ; Thu, 15 Aug 2019 06:51:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Hd7sEjeb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DA64205F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iwXU1dHrmkVwcVlR11cGRwIkhsulQQxL6Zqq68kGkzc=; b=Hd7sEjebV0FbAn tY5MLV9lVJqH6gS6rjg07ZDPqjZWGF5VV9Ii8Brwwk7Oqlip2UTDZIBbHWFKNettP+Rc/CKH0WeL+ 4EtmX3DLFTRb24bHrIadvIazvoId81yxEN3UVjOd9hBAZ1pdlTRD0ZbqBpI+rsvM01Gahp7Fn9nEh UPdqGtoomrdDPYmSFd0qgzdOVlD6H8rhjW9Tpe4MLruAiVKK+WPjqxqjH9ZBPe2whKiAM9Dovfacz CWx/LpvZPz5Sr4si96Poro/6FcfcMIX5V09zVVfsMw7g7iWrOlcJGiGxa6sgkpbEtmoEvAiAFMIlM PlIw43FxaZ4mlTZ3BnAg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hy9bc-0004ng-9M; Thu, 15 Aug 2019 06:51:29 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hy9bY-0004mk-Qd for linux-arm-kernel@lists.infradead.org; Thu, 15 Aug 2019 06:51:26 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id CCA2068B02; Thu, 15 Aug 2019 08:51:17 +0200 (CEST) Date: Thu, 15 Aug 2019 08:51:17 +0200 From: Christoph Hellwig To: Rob Clark Subject: Re: [PATCH 0/6] drm+dma: cache support for arm, etc Message-ID: <20190815065117.GA23761@lst.de> References: <20190814220011.26934-1-robdclark@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190814220011.26934-1-robdclark@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190814_235125_013139_4EEFDDA4 X-CRM114-Status: GOOD ( 11.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kate Stewart , Masayoshi Mizuma , "Maciej W. Rozycki" , Eric Biggers , Catalin Marinas , Imre Deak , dri-devel@lists.freedesktop.org, Chris Wilson , Masahiro Yamada , Benjamin Gaignard , Mauro Carvalho Chehab , Will Deacon , Christoph Hellwig , Emil Velikov , Rob Clark , Michael Ellerman , Mike Rapoport , Geert Uytterhoeven , "moderated list:ARM64 PORT \(AARCH64 ARCHITECTURE\)" , Daniel Vetter , "open list:MIPS" , Linus Walleij , Robin Murphy , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Deepak Sharma , Joerg Roedel , Arnd Bergmann , Anshuman Khandual , Hauke Mehrtens , Jesper Dangaard Brouer , "Wolfram Sang \(Renesas\)" , "open list:LINUX FOR POWERPC \(32-BIT AND 64-BIT\)" , Alexios Zavras , Russell King , Doug Anderson , Thomas Gleixner , Sean Paul , Allison Randal , Christophe Leroy , Enrico Weigelt , Ard Biesheuvel , Greg Kroah-Hartman , open list , Paul Burton , Souptick Joarder , Andrew Morton , "open list:DRM DRIVER FOR MSM ADRENO GPU" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org As said before I don't think these low-level helpers are the right API to export, but even if they did you'd just cover a tiny subset of the architectures. Also to distil the previous thread - if you remap memory to uncached the helper to use is arch_dma_prep_coherent, which does a writeback+ invalidate everywhere, and there is no need to clean up after a long-term uncached mapping. We might still get speculations into that area, if we don't remap the direct mapping, but it isn't like invalidting that just before freeing the memory is going to help anyone. Also it seems like patches 5 and 6 are missing in my inbox. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 0/6] drm+dma: cache support for arm, etc Date: Thu, 15 Aug 2019 08:51:17 +0200 Message-ID: <20190815065117.GA23761@lst.de> References: <20190814220011.26934-1-robdclark@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190814220011.26934-1-robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Rob Clark Cc: Kate Stewart , Masayoshi Mizuma , "Maciej W. Rozycki" , Eric Biggers , Catalin Marinas , Imre Deak , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Chris Wilson , Masahiro Yamada , Benjamin Gaignard , Mauro Carvalho Chehab , Will Deacon , Christoph Hellwig , Emil Velikov , Rob Clark , Michael Ellerman , Mike Rapoport , Geert Uytterhoeven , "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" , Daniel Vetter "open list:MIPS" List-Id: dri-devel@lists.freedesktop.org QXMgc2FpZCBiZWZvcmUgSSBkb24ndCB0aGluayB0aGVzZSBsb3ctbGV2ZWwgaGVscGVycyBhcmUg dGhlCnJpZ2h0IEFQSSB0byBleHBvcnQsIGJ1dCBldmVuIGlmIHRoZXkgZGlkIHlvdSdkIGp1c3Qg Y292ZXIgYSB0aW55CnN1YnNldCBvZiB0aGUgYXJjaGl0ZWN0dXJlcy4KCkFsc28gdG8gZGlzdGls IHRoZSBwcmV2aW91cyB0aHJlYWQgLSBpZiB5b3UgcmVtYXAgbWVtb3J5IHRvIHVuY2FjaGVkCnRo ZSBoZWxwZXIgdG8gdXNlIGlzIGFyY2hfZG1hX3ByZXBfY29oZXJlbnQsIHdoaWNoIGRvZXMgYSB3 cml0ZWJhY2srCmludmFsaWRhdGUgZXZlcnl3aGVyZSwgYW5kIHRoZXJlIGlzIG5vIG5lZWQgdG8g Y2xlYW4gdXAgYWZ0ZXIgYQpsb25nLXRlcm0gdW5jYWNoZWQgbWFwcGluZy4gIFdlIG1pZ2h0IHN0 aWxsIGdldCBzcGVjdWxhdGlvbnMgaW50bwp0aGF0IGFyZWEsIGlmIHdlIGRvbid0IHJlbWFwIHRo ZSBkaXJlY3QgbWFwcGluZywgYnV0IGl0IGlzbid0IGxpa2UKaW52YWxpZHRpbmcgdGhhdCBqdXN0 IGJlZm9yZSBmcmVlaW5nIHRoZSBtZW1vcnkgaXMgZ29pbmcgdG8gaGVscAphbnlvbmUuCgpBbHNv IGl0IHNlZW1zIGxpa2UgcGF0Y2hlcyA1IGFuZCA2IGFyZSBtaXNzaW5nIGluIG15IGluYm94Lgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpGcmVlZHJlbm8g bWFpbGluZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmVlZHJlbm8=