From: Johan Hovold <johan@kernel.org>
To: Bob Ham <bob.ham@puri.sm>
Cc: "Johan Hovold" <johan@kernel.org>,
"Angus Ainslie (Purism)" <angus@akkea.ca>,
kernel@puri.sm, "Bjørn Mork" <bjorn@mork.no>,
"David S. Miller" <davem@davemloft.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: serial: option: Add the BroadMobi BM818 card
Date: Thu, 15 Aug 2019 13:49:41 +0200 [thread overview]
Message-ID: <20190815114941.GE32300@localhost> (raw)
In-Reply-To: <5fb96703-b174-eef1-5ad1-693e2bbce32f@puri.sm>
[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]
On Mon, Aug 05, 2019 at 03:44:30PM +0100, Bob Ham wrote:
> On 05/08/2019 12:47, Johan Hovold wrote:
> > On Wed, Jul 24, 2019 at 07:52:26AM -0700, Angus Ainslie (Purism) wrote:
> >> From: Bob Ham <bob.ham@puri.sm>
> >>
> >> Add a VID:PID for the BroadModi BM818 M.2 card
> >
> > Would you mind posting the output of usb-devices (or lsusb -v) for this
> > device?
>
> T: Bus=01 Lev=03 Prnt=40 Port=03 Cnt=01 Dev#= 44 Spd=480 MxCh= 0
> D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
> P: Vendor=2020 ProdID=2060 Rev=00.00
> S: Manufacturer=Qualcomm, Incorporated
> S: Product=Qualcomm CDMA Technologies MSM
> C: #Ifs= 5 Cfg#= 1 Atr=e0 MxPwr=500mA
> I: If#=0x0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I: If#=0x1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I: If#=0x2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I: If#=0x3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=fe Prot=ff Driver=(none)
> I: If#=0x4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
I amended the commit message with the above, switched to
USB_DEVICE_INTERFACE_CLASS(), fixed the comment and moved the entry
to the other 0x2020 entries before applying.
Johan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-08-15 11:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 14:52 [PATCH 0/2] Add the BroadMobi BM818 card Angus Ainslie (Purism)
2019-07-24 14:52 ` [PATCH 1/2] usb: serial: option: " Angus Ainslie (Purism)
2019-08-05 11:47 ` Johan Hovold
2019-08-05 14:44 ` Bob Ham
2019-08-15 11:49 ` Johan Hovold [this message]
2019-08-15 12:19 ` Bob Ham
2019-08-15 12:28 ` Johan Hovold
2019-07-24 14:52 ` [PATCH 2/2] net: usb: qmi_wwan: " Angus Ainslie (Purism)
2019-07-26 21:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815114941.GE32300@localhost \
--to=johan@kernel.org \
--cc=angus@akkea.ca \
--cc=bjorn@mork.no \
--cc=bob.ham@puri.sm \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@puri.sm \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.