All of lore.kernel.org
 help / color / mirror / Atom feed
diff for duplicates of <20190815144133.GA19557@kadam>

diff --git a/a/1.txt b/N1/1.txt
index 327309e..95c9b68 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -30,7 +30,7 @@ On Thu, Aug 15, 2019 at 12:35:49PM +0200, walter harms wrote:
 > 
 > Bonuspoints to make this more readable:
 > 
-> 	if (ret=0 || ret > len)
+> 	if (ret==0 || ret > len)
 > 		return -EIO;
 > 
 > that makes the intention more obvious.
@@ -38,7 +38,12 @@ On Thu, Aug 15, 2019 at 12:35:49PM +0200, walter harms wrote:
 That's not really related to the bug fix.
 
 I do agree with your style though.  "ret" is a number here, and not a
-bool or error vs no error so = 0 is nicer.
+bool or error vs no error so == 0 is nicer.
 
 regards,
 dan carpenter
+
+
+______________________________________________________
+Linux MTD discussion mailing list
+http://lists.infradead.org/mailman/listinfo/linux-mtd/
diff --git a/a/content_digest b/N1/content_digest
index 2bb6c55..3342180 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -2,7 +2,7 @@
  "ref\05D553585.2020907@bfs.de\0"
  "From\0Dan Carpenter <dan.carpenter@oracle.com>\0"
  "Subject\0Re: [PATCH] mtd: spi-nor: Fix an error code in spi_nor_read_raw()\0"
- "Date\0Thu, 15 Aug 2019 14:41:33 +0000\0"
+ "Date\0Thu, 15 Aug 2019 17:41:33 +0300\0"
  "To\0walter harms <wharms@bfs.de>\0"
  "Cc\0Vignesh Raghavendra <vigneshr@ti.com>"
   Tudor Ambarus <tudor.ambarus@microchip.com>
@@ -48,7 +48,7 @@
  "> \n"
  "> Bonuspoints to make this more readable:\n"
  "> \n"
- "> \tif (ret=0 || ret > len)\n"
+ "> \tif (ret==0 || ret > len)\n"
  "> \t\treturn -EIO;\n"
  "> \n"
  "> that makes the intention more obvious.\n"
@@ -56,9 +56,14 @@
  "That's not really related to the bug fix.\n"
  "\n"
  "I do agree with your style though.  \"ret\" is a number here, and not a\n"
- "bool or error vs no error so = 0 is nicer.\n"
+ "bool or error vs no error so == 0 is nicer.\n"
  "\n"
  "regards,\n"
- dan carpenter
+ "dan carpenter\n"
+ "\n"
+ "\n"
+ "______________________________________________________\n"
+ "Linux MTD discussion mailing list\n"
+ http://lists.infradead.org/mailman/listinfo/linux-mtd/
 
-96ed28a8bfea838b3f49c9517e961d2a47b52ac8b5d904f5a5238c9ab319d956
+36b2fb37a822f9beca9f18b9dc35ce0f8a1125bca95cb7ede328fdd914c9bd41

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.