From: Stephen Boyd <sboyd@kernel.org>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Chen-Yu Tsai <wens@csie.org>
Subject: Re: [PATCH] clk: sunxi: Don't call clk_hw_get_name() on a hw that isn't registered
Date: Thu, 15 Aug 2019 08:18:46 -0700 [thread overview]
Message-ID: <20190815151846.DA999206C1@mail.kernel.org> (raw)
In-Reply-To: <20190815080146.4tkudfzus7uryoe6@flea>
Quoting Maxime Ripard (2019-08-15 01:01:46)
> On Wed, Aug 14, 2019 at 09:10:37PM -0700, Stephen Boyd wrote:
> > The implementation of clk_hw_get_name() relies on the clk_core
> > associated with the clk_hw pointer existing. If of_clk_hw_register()
> > fails, there isn't a clk_core created yet, so calling clk_hw_get_name()
> > here fails. Extract the name first so we can print it later.
> >
> > Fixes: 1d80c14248d6 ("clk: sunxi-ng: Add common infrastructure")
> > Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> > Cc: Chen-Yu Tsai <wens@csie.org>
> > Signed-off-by: Stephen Boyd <sboyd@kernel.org>
>
> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
>
> Do you want to apply it yourself, or should I merge this and send you
> a PR later?
>
I can apply it myself. Thanks! Now to figure out the real problem...
next prev parent reply other threads:[~2019-08-15 15:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 4:10 [PATCH] clk: sunxi: Don't call clk_hw_get_name() on a hw that isn't registered Stephen Boyd
2019-08-15 8:01 ` Maxime Ripard
2019-08-15 15:18 ` Stephen Boyd [this message]
2019-08-16 17:25 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815151846.DA999206C1@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.