From: David Disseldorp <ddiss@suse.de>
To: ronnie sahlberg <ronniesahlberg@gmail.com>
Cc: linux-cifs <linux-cifs@vger.kernel.org>
Subject: Re: FSCTL_QUERY_ALLOCATED_RANGES issue with Windows2016
Date: Thu, 15 Aug 2019 17:48:54 +0200 [thread overview]
Message-ID: <20190815174854.05661672@suse.de> (raw)
In-Reply-To: <CAN05THT0OkbAoNu8ZVSHF-xY7w0ZW4q4i-jTxjNManrnz0OMfg@mail.gmail.com>
Hi Ronnie,
Is the file flagged sparse (FSCTL_SET_SPARSE()) prior to the QAR
request? When implementing the Samba server-side I tried to match
Windows/spec behaviour with:
702 if (!fsp->is_sparse) {
703 struct file_alloced_range_buf qar_buf;
704
705 /* file is non-sparse, claim file_off->max_off is allocated */
706 qar_buf.file_off = qar_req.buf.file_off;
707 /* + 1 to convert maximum offset back to length */
708 qar_buf.len = max_off - qar_req.buf.file_off + 1;
709
710 status = fsctl_qar_buf_push(mem_ctx, &qar_buf, &qar_array_blob);
711 } else {
712 status = fsctl_qar_seek_fill(mem_ctx, fsp, qar_req.buf.file_off,
713 max_off, &qar_array_blob);
714 }
...in which case you should see similar test results against Samba. This
also excersized via the ioctl_sparse_qar* smbtorture tests.
Cheers, David
next prev parent reply other threads:[~2019-08-15 15:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 6:30 FSCTL_QUERY_ALLOCATED_RANGES issue with Windows2016 ronnie sahlberg
2019-08-15 15:15 ` Tom Talpey
2019-08-16 2:17 ` ronnie sahlberg
2019-08-15 15:48 ` David Disseldorp [this message]
2019-08-16 2:07 ` ronnie sahlberg
2019-08-16 4:36 ` ronnie sahlberg
2019-08-19 16:31 ` David Disseldorp
2019-08-19 22:03 ` David Disseldorp
2019-08-20 17:47 ` Tom Talpey
2019-08-22 22:46 ` ronnie sahlberg
2019-08-16 9:07 ` David Disseldorp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815174854.05661672@suse.de \
--to=ddiss@suse.de \
--cc=linux-cifs@vger.kernel.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.