All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PULL 7/9] tests/libqtest: Clean up qtest_cb_for_every_machine() wrt global_qtest
Date: Thu, 15 Aug 2019 19:59:20 +0200	[thread overview]
Message-ID: <20190815175922.3475-8-thuth@redhat.com> (raw)
In-Reply-To: <20190815175922.3475-1-thuth@redhat.com>

The generic libqtest library functions should not use functions that
require the global_qtest variable.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20190813093047.27948-5-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/libqtest.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/tests/libqtest.c b/tests/libqtest.c
index 3e9245d4c9..d1aead30ed 100644
--- a/tests/libqtest.c
+++ b/tests/libqtest.c
@@ -1189,9 +1189,10 @@ void qtest_cb_for_every_machine(void (*cb)(const char *machine),
     QObject *qobj;
     QString *qstr;
     const char *mname;
+    QTestState *qts;
 
-    qtest_start("-machine none");
-    response = qmp("{ 'execute': 'query-machines' }");
+    qts = qtest_init("-machine none");
+    response = qtest_qmp(qts, "{ 'execute': 'query-machines' }");
     g_assert(response);
     list = qdict_get_qlist(response, "return");
     g_assert(list);
@@ -1209,7 +1210,7 @@ void qtest_cb_for_every_machine(void (*cb)(const char *machine),
         }
     }
 
-    qtest_end();
+    qtest_quit(qts);
     qobject_unref(response);
 }
 
-- 
2.18.1



  parent reply	other threads:[~2019-08-15 18:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-15 17:59 [Qemu-devel] [PULL 0/9] qtest patches Thomas Huth
2019-08-15 17:59 ` [Qemu-devel] [PULL 1/9] qtest: Rename qtest.c:qtest_init() Thomas Huth
2019-08-15 17:59 ` [Qemu-devel] [PULL 2/9] libqos: Account for the ctrl queue in virtio-net Thomas Huth
2019-08-15 17:59 ` [Qemu-devel] [PULL 3/9] tests: Set read-zeroes on for null-co driver Thomas Huth
2019-08-15 17:59 ` [Qemu-devel] [PULL 4/9] tests/libqos: Make generic virtio code independent from global_qtest Thomas Huth
2019-08-15 17:59 ` [Qemu-devel] [PULL 5/9] tests/libqos: Make virtio-pci " Thomas Huth
2019-08-15 17:59 ` [Qemu-devel] [PULL 6/9] tests/libqtest: Remove unused function hmp() Thomas Huth
2019-08-15 17:59 ` Thomas Huth [this message]
2019-08-15 17:59 ` [Qemu-devel] [PULL 8/9] tests/libqtest: Make qtest_qmp_device_add/del independent from global_qtest Thomas Huth
2019-08-15 17:59 ` [Qemu-devel] [PULL 9/9] tests/libqtest: Make qmp_assert_success() " Thomas Huth
2019-08-15 18:17 ` [Qemu-devel] [PULL 0/9] qtest patches no-reply
2019-08-15 18:34   ` Thomas Huth
2019-08-16 13:53 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190815175922.3475-8-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.