From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Fri, 16 Aug 2019 14:38:50 +0200 Subject: [PATCH] Revert "nvme-pci: use host managed power state for suspend" In-Reply-To: <156595862897.11610.6852982219615959799@skylake-alporthouse-com> References: <20190816121549.8754-1-chris@chris-wilson.co.uk> <20190816122644.GA21797@lst.de> <156595862897.11610.6852982219615959799@skylake-alporthouse-com> Message-ID: <20190816123850.GA22923@lst.de> On Fri, Aug 16, 2019@01:30:29PM +0100, Chris Wilson wrote: > Quoting Christoph Hellwig (2019-08-16 13:26:44) > > Please, report the actual problem. Blindly reverting a patch without > > even an explanation of your regressions is not the way to do it. > > As stated, the system doesn't suspend. > > If you would like to wait, you will get test results from our CI > giving the current failed state and the outcome of the patch. Platform type, SSD vendor and type, firmware version? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] Revert "nvme-pci: use host managed power state for suspend" Date: Fri, 16 Aug 2019 14:38:50 +0200 Message-ID: <20190816123850.GA22923@lst.de> References: <20190816121549.8754-1-chris@chris-wilson.co.uk> <20190816122644.GA21797@lst.de> <156595862897.11610.6852982219615959799@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by gabe.freedesktop.org (Postfix) with ESMTPS id 98D9E6E3E1 for ; Fri, 16 Aug 2019 12:38:53 +0000 (UTC) Content-Disposition: inline In-Reply-To: <156595862897.11610.6852982219615959799@skylake-alporthouse-com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: Jens Axboe , Sagi Grimberg , intel-gfx@lists.freedesktop.org, "Rafael J . Wysocki" , linux-nvme@lists.infradead.org, Keith Busch , Keith Busch , Christoph Hellwig List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBBdWcgMTYsIDIwMTkgYXQgMDE6MzA6MjlQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgQ2hyaXN0b3BoIEhlbGx3aWcgKDIwMTktMDgtMTYgMTM6MjY6NDQpCj4g PiBQbGVhc2UsIHJlcG9ydCB0aGUgYWN0dWFsIHByb2JsZW0uICBCbGluZGx5IHJldmVydGluZyBh IHBhdGNoIHdpdGhvdXQKPiA+IGV2ZW4gYW4gZXhwbGFuYXRpb24gb2YgeW91ciByZWdyZXNzaW9u cyBpcyBub3QgdGhlIHdheSB0byBkbyBpdC4KPiAKPiBBcyBzdGF0ZWQsIHRoZSBzeXN0ZW0gZG9l c24ndCBzdXNwZW5kLgo+IAo+IElmIHlvdSB3b3VsZCBsaWtlIHRvIHdhaXQsIHlvdSB3aWxsIGdl dCB0ZXN0IHJlc3VsdHMgZnJvbSBvdXIgQ0kKPiBnaXZpbmcgdGhlIGN1cnJlbnQgZmFpbGVkIHN0 YXRlIGFuZCB0aGUgb3V0Y29tZSBvZiB0aGUgcGF0Y2guCgpQbGF0Zm9ybSB0eXBlLCBTU0QgdmVu ZG9yIGFuZCB0eXBlLCBmaXJtd2FyZSB2ZXJzaW9uPwpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZng=