diff for duplicates of <20190816155353.GA6883@localhost.localdomain> diff --git a/a/1.txt b/N1/1.txt index 34b4490..e434941 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,4 +1,4 @@ -On Thu, Aug 15, 2019@07:28:49PM -0700, Ming Lei wrote: +On Thu, Aug 15, 2019 at 07:28:49PM -0700, Ming Lei wrote: > Now __irq_build_affinity_masks() spreads vectors evenly per node, and > all vectors may not be spread in case that each numa node has different > CPU number, then the warning in irq_build_affinity_masks() can @@ -16,7 +16,7 @@ On Thu, Aug 15, 2019@07:28:49PM -0700, Ming Lei wrote: > node has different CPU number. > > For example, on the following machine: -> [root at ktest-01 ~]# lscpu +> [root@ktest-01 ~]# lscpu > ... > CPU(s): 16 > On-line CPU(s) list: 0-15 @@ -42,13 +42,13 @@ On Thu, Aug 15, 2019@07:28:49PM -0700, Ming Lei wrote: > Without this patch, kernel warning is triggered on above situation, and > allocation result was supposed to be 4 vectors for each node. > -> Cc: Christoph Hellwig <hch at lst.de> -> Cc: Keith Busch <kbusch at kernel.org> -> Cc: linux-nvme at lists.infradead.org, -> Cc: Jon Derrick <jonathan.derrick at intel.com> -> Cc: Jens Axboe <axboe at kernel.dk> -> Reported-by: Jon Derrick <jonathan.derrick at intel.com> -> Signed-off-by: Ming Lei <ming.lei at redhat.com> +> Cc: Christoph Hellwig <hch@lst.de> +> Cc: Keith Busch <kbusch@kernel.org> +> Cc: linux-nvme@lists.infradead.org, +> Cc: Jon Derrick <jonathan.derrick@intel.com> +> Cc: Jens Axboe <axboe@kernel.dk> +> Reported-by: Jon Derrick <jonathan.derrick@intel.com> +> Signed-off-by: Ming Lei <ming.lei@redhat.com> I had every intention to thoroughly test this on imbalanced node configurations, but that's not going to happen anytime soon. It looks @@ -59,7 +59,7 @@ comments, though. It essentially boils down to "the sum of the parts doesn't exceed the whole", and the key to carving up the parts is the sorted iteration you've implemented. -Reviewed-by: Keith Busch <kbusch at kernel.org> +Reviewed-by: Keith Busch <kbusch@kernel.org> > --- > kernel/irq/affinity.c | 223 ++++++++++++++++++++++++++++++++++++------ diff --git a/a/content_digest b/N1/content_digest index 283dc6e..eff2d33 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,11 +1,19 @@ "ref\020190816022849.14075-1-ming.lei@redhat.com\0" "ref\020190816022849.14075-3-ming.lei@redhat.com\0" - "From\0kbusch@kernel.org (Keith Busch)\0" - "Subject\0[PATCH V5 2/2] genirq/affinity: Spread vectors on node according to nr_cpu ratio\0" + "From\0Keith Busch <kbusch@kernel.org>\0" + "Subject\0Re: [PATCH V5 2/2] genirq/affinity: Spread vectors on node according to nr_cpu ratio\0" "Date\0Fri, 16 Aug 2019 09:53:53 -0600\0" + "To\0Ming Lei <ming.lei@redhat.com>\0" + "Cc\0Thomas Gleixner <tglx@linutronix.de>" + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + Christoph Hellwig <hch@lst.de> + linux-nvme@lists.infradead.org <linux-nvme@lists.infradead.org> + Derrick + Jonathan <jonathan.derrick@intel.com> + " Jens Axboe <axboe@kernel.dk>\0" "\00:1\0" "b\0" - "On Thu, Aug 15, 2019@07:28:49PM -0700, Ming Lei wrote:\n" + "On Thu, Aug 15, 2019 at 07:28:49PM -0700, Ming Lei wrote:\n" "> Now __irq_build_affinity_masks() spreads vectors evenly per node, and\n" "> all vectors may not be spread in case that each numa node has different\n" "> CPU number, then the warning in irq_build_affinity_masks() can\n" @@ -23,7 +31,7 @@ "> node has different CPU number.\n" "> \n" "> For example, on the following machine:\n" - "> \t[root at ktest-01 ~]# lscpu\n" + "> \t[root@ktest-01 ~]# lscpu\n" "> \t...\n" "> \tCPU(s): 16\n" "> \tOn-line CPU(s) list: 0-15\n" @@ -49,13 +57,13 @@ "> Without this patch, kernel warning is triggered on above situation, and\n" "> allocation result was supposed to be 4 vectors for each node.\n" "> \n" - "> Cc: Christoph Hellwig <hch at lst.de>\n" - "> Cc: Keith Busch <kbusch at kernel.org>\n" - "> Cc: linux-nvme at lists.infradead.org,\n" - "> Cc: Jon Derrick <jonathan.derrick at intel.com>\n" - "> Cc: Jens Axboe <axboe at kernel.dk>\n" - "> Reported-by: Jon Derrick <jonathan.derrick at intel.com>\n" - "> Signed-off-by: Ming Lei <ming.lei at redhat.com>\n" + "> Cc: Christoph Hellwig <hch@lst.de>\n" + "> Cc: Keith Busch <kbusch@kernel.org>\n" + "> Cc: linux-nvme@lists.infradead.org,\n" + "> Cc: Jon Derrick <jonathan.derrick@intel.com>\n" + "> Cc: Jens Axboe <axboe@kernel.dk>\n" + "> Reported-by: Jon Derrick <jonathan.derrick@intel.com>\n" + "> Signed-off-by: Ming Lei <ming.lei@redhat.com>\n" "\n" "I had every intention to thoroughly test this on imbalanced node\n" "configurations, but that's not going to happen anytime soon. It looks\n" @@ -66,7 +74,7 @@ "doesn't exceed the whole\", and the key to carving up the parts is the\n" "sorted iteration you've implemented.\n" "\n" - "Reviewed-by: Keith Busch <kbusch at kernel.org>\n" + "Reviewed-by: Keith Busch <kbusch@kernel.org>\n" "\n" "> ---\n" "> kernel/irq/affinity.c | 223 ++++++++++++++++++++++++++++++++++++------\n" @@ -369,4 +377,4 @@ "> 2.20.1\n" > -dde0965f0095d5446f347c53a6eb40372f29b6e1b7435adc2e7035f295b2733f +4e0e49952eb3b7aa821c62e38535f08d137f3d82c63321f2105b13b6abdc2999
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.