From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C32CAC3A59E for ; Fri, 16 Aug 2019 16:43:33 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A491B2171F for ; Fri, 16 Aug 2019 16:43:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A491B2171F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 7CEE1C77; Fri, 16 Aug 2019 16:43:33 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 373D5C21 for ; Fri, 16 Aug 2019 16:43:32 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id B214BE5 for ; Fri, 16 Aug 2019 16:43:31 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id B7255227A81; Fri, 16 Aug 2019 18:43:28 +0200 (CEST) Date: Fri, 16 Aug 2019 18:43:28 +0200 From: Christoph Hellwig To: Robin Murphy Subject: Re: [PATCH 03/11] xen/arm: pass one less argument to dma_cache_maint Message-ID: <20190816164328.GB3629@lst.de> References: <20190816130013.31154-1-hch@lst.de> <20190816130013.31154-4-hch@lst.de> <8585fb27-14e0-888c-6749-6862b4e16418@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8585fb27-14e0-888c-6749-6862b4e16418@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Stefano Stabellini , Konrad Rzeszutek Wilk , x86@kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Christoph Hellwig , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On Fri, Aug 16, 2019 at 02:37:58PM +0100, Robin Murphy wrote: > On 16/08/2019 14:00, Christoph Hellwig wrote: >> Instead of taking apart the dma address in both callers do it inside >> dma_cache_maint itself. >> >> Signed-off-by: Christoph Hellwig >> --- >> arch/arm/xen/mm.c | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c >> index 90574d89d0d4..d9da24fda2f7 100644 >> --- a/arch/arm/xen/mm.c >> +++ b/arch/arm/xen/mm.c >> @@ -43,13 +43,15 @@ static bool hypercall_cflush = false; >> /* functions called by SWIOTLB */ >> -static void dma_cache_maint(dma_addr_t handle, unsigned long offset, >> - size_t size, enum dma_data_direction dir, enum dma_cache_op op) >> +static void dma_cache_maint(dma_addr_t handle, size_t size, >> + enum dma_data_direction dir, enum dma_cache_op op) >> { >> struct gnttab_cache_flush cflush; >> unsigned long xen_pfn; >> + unsigned long offset = handle & ~PAGE_MASK; >> size_t left = size; >> + offset &= PAGE_MASK; > > Ahem... presumably that should be handle, not offset. Ooops, yes. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78680C3A59C for ; Fri, 16 Aug 2019 16:43:50 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 539B72077C for ; Fri, 16 Aug 2019 16:43:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 539B72077C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hyfK9-0001xb-OH; Fri, 16 Aug 2019 16:43:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hyfK8-0001xT-F8 for xen-devel@lists.xenproject.org; Fri, 16 Aug 2019 16:43:32 +0000 X-Inumbo-ID: fab5a708-c044-11e9-813a-bc764e2007e4 Received: from verein.lst.de (unknown [213.95.11.211]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fab5a708-c044-11e9-813a-bc764e2007e4; Fri, 16 Aug 2019 16:43:31 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id B7255227A81; Fri, 16 Aug 2019 18:43:28 +0200 (CEST) Date: Fri, 16 Aug 2019 18:43:28 +0200 From: Christoph Hellwig To: Robin Murphy Message-ID: <20190816164328.GB3629@lst.de> References: <20190816130013.31154-1-hch@lst.de> <20190816130013.31154-4-hch@lst.de> <8585fb27-14e0-888c-6749-6862b4e16418@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8585fb27-14e0-888c-6749-6862b4e16418@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Subject: Re: [Xen-devel] [PATCH 03/11] xen/arm: pass one less argument to dma_cache_maint X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Konrad Rzeszutek Wilk , x86@kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Christoph Hellwig , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gRnJpLCBBdWcgMTYsIDIwMTkgYXQgMDI6Mzc6NThQTSArMDEwMCwgUm9iaW4gTXVycGh5IHdy b3RlOgo+IE9uIDE2LzA4LzIwMTkgMTQ6MDAsIENocmlzdG9waCBIZWxsd2lnIHdyb3RlOgo+PiBJ bnN0ZWFkIG9mIHRha2luZyBhcGFydCB0aGUgZG1hIGFkZHJlc3MgaW4gYm90aCBjYWxsZXJzIGRv IGl0IGluc2lkZQo+PiBkbWFfY2FjaGVfbWFpbnQgaXRzZWxmLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5 OiBDaHJpc3RvcGggSGVsbHdpZyA8aGNoQGxzdC5kZT4KPj4gLS0tCj4+ICAgYXJjaC9hcm0veGVu L21tLmMgfCAxMCArKysrKystLS0tCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygr KSwgNCBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL3hlbi9tbS5jIGIv YXJjaC9hcm0veGVuL21tLmMKPj4gaW5kZXggOTA1NzRkODlkMGQ0Li5kOWRhMjRmZGEyZjcgMTAw NjQ0Cj4+IC0tLSBhL2FyY2gvYXJtL3hlbi9tbS5jCj4+ICsrKyBiL2FyY2gvYXJtL3hlbi9tbS5j Cj4+IEBAIC00MywxMyArNDMsMTUgQEAgc3RhdGljIGJvb2wgaHlwZXJjYWxsX2NmbHVzaCA9IGZh bHNlOwo+PiAgICAgLyogZnVuY3Rpb25zIGNhbGxlZCBieSBTV0lPVExCICovCj4+ICAgLXN0YXRp YyB2b2lkIGRtYV9jYWNoZV9tYWludChkbWFfYWRkcl90IGhhbmRsZSwgdW5zaWduZWQgbG9uZyBv ZmZzZXQsCj4+IC0Jc2l6ZV90IHNpemUsIGVudW0gZG1hX2RhdGFfZGlyZWN0aW9uIGRpciwgZW51 bSBkbWFfY2FjaGVfb3Agb3ApCj4+ICtzdGF0aWMgdm9pZCBkbWFfY2FjaGVfbWFpbnQoZG1hX2Fk ZHJfdCBoYW5kbGUsIHNpemVfdCBzaXplLAo+PiArCQllbnVtIGRtYV9kYXRhX2RpcmVjdGlvbiBk aXIsIGVudW0gZG1hX2NhY2hlX29wIG9wKQo+PiAgIHsKPj4gICAJc3RydWN0IGdudHRhYl9jYWNo ZV9mbHVzaCBjZmx1c2g7Cj4+ICAgCXVuc2lnbmVkIGxvbmcgeGVuX3BmbjsKPj4gKwl1bnNpZ25l ZCBsb25nIG9mZnNldCA9IGhhbmRsZSAmIH5QQUdFX01BU0s7Cj4+ICAgCXNpemVfdCBsZWZ0ID0g c2l6ZTsKPj4gICArCW9mZnNldCAmPSBQQUdFX01BU0s7Cj4KPiBBaGVtLi4uIHByZXN1bWFibHkg dGhhdCBzaG91bGQgYmUgaGFuZGxlLCBub3Qgb2Zmc2V0LgoKT29vcHMsIHllcy4KCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5n IGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJv amVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88A91C3A59C for ; Fri, 16 Aug 2019 16:43:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C2F52077C for ; Fri, 16 Aug 2019 16:43:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="padUkqhb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C2F52077C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hbvo84Vu2P/K4ySA1qRlEGyMZ50CH7N3gIh5eQN5RD8=; b=padUkqhbBm6hjw 7tR5R7hZjsZuTz8cPivzTZG+qQCbUTlOIuGIJ1DxDUFLNx0oxrZ+BpyKij0alyPdYjc7SqE9+ri91 BNpPRBktVzvTkx+7DaeJ+AiOlRBWqAXpmnTDT4+TF1eiRxGPCUlKcg+qKgIIPD0EM5tr5GPeFzsWy gp+GNTWs9HNLxZU2KtTdUb/bunXXZLz8nnyWMAL8eBVXZnwJNDtVxUAZJ7Q/y6Byt9mFr6kVeHtZy qckW0TVoxFwZ1SZ7mjuvBZ3VxtxiGwe6M0g4/bMsNjrhh0QBZ9BaFjPj7ndSJjH9Yv1ZrFvNY6YlZ /5uTn3MzPo4akWyKu6fA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hyfKA-0001TT-TX; Fri, 16 Aug 2019 16:43:34 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hyfK7-0001Sv-FO for linux-arm-kernel@lists.infradead.org; Fri, 16 Aug 2019 16:43:32 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id B7255227A81; Fri, 16 Aug 2019 18:43:28 +0200 (CEST) Date: Fri, 16 Aug 2019 18:43:28 +0200 From: Christoph Hellwig To: Robin Murphy Subject: Re: [PATCH 03/11] xen/arm: pass one less argument to dma_cache_maint Message-ID: <20190816164328.GB3629@lst.de> References: <20190816130013.31154-1-hch@lst.de> <20190816130013.31154-4-hch@lst.de> <8585fb27-14e0-888c-6749-6862b4e16418@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8585fb27-14e0-888c-6749-6862b4e16418@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190816_094331_661035_E6FD3D6D X-CRM114-Status: GOOD ( 11.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Konrad Rzeszutek Wilk , x86@kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Christoph Hellwig , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 16, 2019 at 02:37:58PM +0100, Robin Murphy wrote: > On 16/08/2019 14:00, Christoph Hellwig wrote: >> Instead of taking apart the dma address in both callers do it inside >> dma_cache_maint itself. >> >> Signed-off-by: Christoph Hellwig >> --- >> arch/arm/xen/mm.c | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c >> index 90574d89d0d4..d9da24fda2f7 100644 >> --- a/arch/arm/xen/mm.c >> +++ b/arch/arm/xen/mm.c >> @@ -43,13 +43,15 @@ static bool hypercall_cflush = false; >> /* functions called by SWIOTLB */ >> -static void dma_cache_maint(dma_addr_t handle, unsigned long offset, >> - size_t size, enum dma_data_direction dir, enum dma_cache_op op) >> +static void dma_cache_maint(dma_addr_t handle, size_t size, >> + enum dma_data_direction dir, enum dma_cache_op op) >> { >> struct gnttab_cache_flush cflush; >> unsigned long xen_pfn; >> + unsigned long offset = handle & ~PAGE_MASK; >> size_t left = size; >> + offset &= PAGE_MASK; > > Ahem... presumably that should be handle, not offset. Ooops, yes. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F1ADC3A59C for ; Fri, 16 Aug 2019 16:43:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33E642077C for ; Fri, 16 Aug 2019 16:43:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727138AbfHPQnc (ORCPT ); Fri, 16 Aug 2019 12:43:32 -0400 Received: from verein.lst.de ([213.95.11.211]:56735 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726245AbfHPQnb (ORCPT ); Fri, 16 Aug 2019 12:43:31 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id B7255227A81; Fri, 16 Aug 2019 18:43:28 +0200 (CEST) Date: Fri, 16 Aug 2019 18:43:28 +0200 From: Christoph Hellwig To: Robin Murphy Cc: Christoph Hellwig , Stefano Stabellini , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, iommu@lists.linux-foundation.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 03/11] xen/arm: pass one less argument to dma_cache_maint Message-ID: <20190816164328.GB3629@lst.de> References: <20190816130013.31154-1-hch@lst.de> <20190816130013.31154-4-hch@lst.de> <8585fb27-14e0-888c-6749-6862b4e16418@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8585fb27-14e0-888c-6749-6862b4e16418@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 16, 2019 at 02:37:58PM +0100, Robin Murphy wrote: > On 16/08/2019 14:00, Christoph Hellwig wrote: >> Instead of taking apart the dma address in both callers do it inside >> dma_cache_maint itself. >> >> Signed-off-by: Christoph Hellwig >> --- >> arch/arm/xen/mm.c | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c >> index 90574d89d0d4..d9da24fda2f7 100644 >> --- a/arch/arm/xen/mm.c >> +++ b/arch/arm/xen/mm.c >> @@ -43,13 +43,15 @@ static bool hypercall_cflush = false; >> /* functions called by SWIOTLB */ >> -static void dma_cache_maint(dma_addr_t handle, unsigned long offset, >> - size_t size, enum dma_data_direction dir, enum dma_cache_op op) >> +static void dma_cache_maint(dma_addr_t handle, size_t size, >> + enum dma_data_direction dir, enum dma_cache_op op) >> { >> struct gnttab_cache_flush cflush; >> unsigned long xen_pfn; >> + unsigned long offset = handle & ~PAGE_MASK; >> size_t left = size; >> + offset &= PAGE_MASK; > > Ahem... presumably that should be handle, not offset. Ooops, yes.