All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	dri-devel@lists.freedesktop.org,
	Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 1/2] video: omapfb2: Make standard and custom panel drivers mutually exclusive
Date: Fri, 16 Aug 2019 19:31:05 +0200	[thread overview]
Message-ID: <20190816173105.GA9934@ravnborg.org> (raw)
In-Reply-To: <20190816122228.9475-2-laurent.pinchart@ideasonboard.com>

Hi Laurent

Thanks for beating me on this!

On Fri, Aug 16, 2019 at 03:22:27PM +0300, Laurent Pinchart wrote:
> Standard DRM panel drivers for several panels used by omapfb2 are now
> available. Their module name clashes with the modules from
> drivers/gpu/drm/omapdrm/displays/, part of the deprecated omapfb2 fbdev
> driver. As omapfb2 can only be compiled when the omapdrm driver is
> disabled, and the DRM panel drivers are useless in that case, make the
> omapfb2 panels depend on the standard DRM panels being disabled to fix
> the name clash.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  drivers/video/fbdev/omap2/omapfb/displays/Kconfig | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/video/fbdev/omap2/omapfb/displays/Kconfig b/drivers/video/fbdev/omap2/omapfb/displays/Kconfig
> index 8c1c5a4cfe18..744416dc530e 100644
> --- a/drivers/video/fbdev/omap2/omapfb/displays/Kconfig
> +++ b/drivers/video/fbdev/omap2/omapfb/displays/Kconfig
> @@ -49,6 +49,7 @@ config FB_OMAP2_PANEL_DSI_CM
>  config FB_OMAP2_PANEL_SONY_ACX565AKM
>  	tristate "ACX565AKM Panel"
>  	depends on SPI && BACKLIGHT_CLASS_DEVICE
> +	depends on DRM_PANEL_SONY_ACX565AKM = n

Would:
	depends on !DRM_PANEL_SONY_ACX565AKM

do the same?

Example:
config FB_INTEL
        tristate "Intel 830M/845G/852GM/855GM/865G/915G/945G/945GM/965G/965GM support"
        depends on FB && PCI && X86 && AGP_INTEL && EXPERT
	...
        depends on !DRM_I915


DRM_915 is a tristate symbol.

It is maybe bikeshedding, but the !<SYMBOL> seems more logical/readable to me.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-08-16 17:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-16 12:22 [PATCH 0/2] Fix module name clash with omapdrm and DRM panel modules Laurent Pinchart
2019-08-16 12:22 ` [PATCH 1/2] video: omapfb2: Make standard and custom panel drivers mutually exclusive Laurent Pinchart
2019-08-16 13:20   ` Tomi Valkeinen
2019-08-16 13:32     ` Laurent Pinchart
2019-08-19 14:16       ` Bartlomiej Zolnierkiewicz
2019-08-19 15:17         ` Sam Ravnborg
2019-08-20 11:40           ` Bartlomiej Zolnierkiewicz
2019-08-16 17:31   ` Sam Ravnborg [this message]
2019-08-16 18:39     ` Laurent Pinchart
2019-08-16 19:11       ` Sam Ravnborg
2019-08-20  8:59         ` Daniel Vetter
2019-08-20 10:32           ` Sam Ravnborg
2019-08-16 12:22 ` [PATCH 2/2] drm/omap: displays: Remove unused panel drivers Laurent Pinchart
2019-08-16 13:26   ` Tomi Valkeinen
2019-08-16 19:12 ` [PATCH 0/2] Fix module name clash with omapdrm and DRM panel modules Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190816173105.GA9934@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=sfr@canb.auug.org.au \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.