From: Rob Herring <robh@kernel.org>
To: Richard Tresidder <rtresidd@electromag.com.au>
Cc: sre@kernel.org, mark.rutland@arm.com, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: power/supply/sbs_sbs-battery: Addition of force_load binding Add device tree binding documentation for addition of force_load boolean value to allow loading a battery during boot even if not present at that time.
Date: Fri, 16 Aug 2019 16:14:30 -0500 [thread overview]
Message-ID: <20190816211430.GA8175@bogus> (raw)
In-Reply-To: <1564037445-22936-1-git-send-email-rtresidd@electromag.com.au>
On Thu, Jul 25, 2019 at 02:50:45PM +0800, Richard Tresidder wrote:
> Signed-off-by: Richard Tresidder <rtresidd@electromag.com.au>
> ---
>
> Notes:
> Add device tree binding documentation for addition of force_load
> boolean value to allow loading a battery during boot even if not
> present at that time.
> Accompanying patch to drivers/power/supply/sbs-battery.c submitted to linux-pm@vger.kernel.org
>
> Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt b/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt
> index 4e78e51..187d7bb 100644
> --- a/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt
> +++ b/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt
> @@ -15,7 +15,8 @@ Optional properties :
> after an external change notification.
> - sbs,battery-detect-gpios : The gpio which signals battery detection and
> a flag specifying its polarity.
> -
> + - sbs,force-load : Allow loading of a hot-pluggable battery when there is no
> + GPIO detect available and the module is statically built.
What's a module? That's Linux specific and nothing to do with the
binding.
Can't you just force load if sbs,battery-detect-gpios is not present?
Rob
next prev parent reply other threads:[~2019-08-16 21:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 6:50 [PATCH 1/1] dt-bindings: power/supply/sbs_sbs-battery: Addition of force_load binding Add device tree binding documentation for addition of force_load boolean value to allow loading a battery during boot even if not present at that time Richard Tresidder
2019-08-16 21:14 ` Rob Herring [this message]
2019-08-19 3:33 ` Richard Tresidder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816211430.GA8175@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rtresidd@electromag.com.au \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.