Re: [PATCH] nouveau/hmm: map pages after migration

From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: nouveau
	<nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
	dri-devel
	<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH] nouveau/hmm: map pages after migration
Date: Sat, 17 Aug 2019 08:11:03 +0200	[thread overview]
Message-ID: <20190817061103.GA18179@lst.de> (raw)
In-Reply-To: <CABDvA=n4Y0QticHZowEWFOqiEB3p99nV71GvHAySYdkcgw-Aow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Sat, Aug 17, 2019 at 11:05:36AM +1000, Ben Skeggs wrote:
> > >> constants with similar names and identical values, and those are used
> > >> in mmu/vmmgp100.c and what appears to finally do the low-level dma
> > >> mapping and talking to the hardware.  Are these two sets of constants
> > >> supposed to be the same?  Are the actual hardware values or just a
> > >> driver internal interface?
> > >
> > > It looks a bit odd to me too.
> > > I don't really know the structure/history of nouveau.
> > > Perhaps Ben Skeggs can shed more light on your question.
> >
> > Ben, do you have any insights on these constants?
> Those sets of constants are (currently) supposed to be the same value.
> They don't necessarily map to the HW directly at this stage, and
> something different will likely be done in the future as HW changes.

So why do we have two sets of constants instead of one set for these
values?  That makes trying to follow the code pretty hard.
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau