From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98C53C3A59B for ; Sat, 17 Aug 2019 06:50:18 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69C822077C for ; Sat, 17 Aug 2019 06:50:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69C822077C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 299D1B8E; Sat, 17 Aug 2019 06:50:18 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id E03A1B88 for ; Sat, 17 Aug 2019 06:50:16 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 69D5963D for ; Sat, 17 Aug 2019 06:50:16 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 70BE768B05; Sat, 17 Aug 2019 08:50:12 +0200 (CEST) Date: Sat, 17 Aug 2019 08:50:11 +0200 From: Christoph Hellwig To: Julien Grall Subject: Re: [Xen-devel] [PATCH 07/11] swiotlb-xen: provide a single page-coherent.h header Message-ID: <20190817065011.GA18599@lst.de> References: <20190816130013.31154-1-hch@lst.de> <20190816130013.31154-8-hch@lst.de> <9a3261c6-5d92-cf6b-1ae8-3a8e8b5ef0d4@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9a3261c6-5d92-cf6b-1ae8-3a8e8b5ef0d4@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Stefano Stabellini , Konrad Rzeszutek Wilk , x86@kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Christoph Hellwig , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On Fri, Aug 16, 2019 at 11:40:43PM +0100, Julien Grall wrote: > I am not sure I agree with this rename. The implementation of the helpers > are very Arm specific as this is assuming Dom0 is 1:1 mapped. > > This was necessary due to the lack of IOMMU on Arm platforms back then. > But this is now a pain to get rid of it on newer platform... So if you look at the final version of the header after the whole series, what assumes a 1:1 mapping? It all just is if (pfn_valid()) local cache sync; else call into the arch code; are you concerned that the local cache sync might have to be split up more for a non-1:1 map in that case? We could just move the xen_dma_* routines into the arch instead of __xen_dma, but it really helps to have a common interface header. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81F40C3A59B for ; Sat, 17 Aug 2019 06:50:50 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CC6B2077C for ; Sat, 17 Aug 2019 06:50:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CC6B2077C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hysXc-0000QZ-Cy; Sat, 17 Aug 2019 06:50:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hysXa-0000QU-LR for xen-devel@lists.xenproject.org; Sat, 17 Aug 2019 06:50:18 +0000 X-Inumbo-ID: 44a12e16-c0bb-11e9-8bbf-12813bfff9fa Received: from verein.lst.de (unknown [213.95.11.211]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 44a12e16-c0bb-11e9-8bbf-12813bfff9fa; Sat, 17 Aug 2019 06:50:16 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 70BE768B05; Sat, 17 Aug 2019 08:50:12 +0200 (CEST) Date: Sat, 17 Aug 2019 08:50:11 +0200 From: Christoph Hellwig To: Julien Grall Message-ID: <20190817065011.GA18599@lst.de> References: <20190816130013.31154-1-hch@lst.de> <20190816130013.31154-8-hch@lst.de> <9a3261c6-5d92-cf6b-1ae8-3a8e8b5ef0d4@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9a3261c6-5d92-cf6b-1ae8-3a8e8b5ef0d4@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Subject: Re: [Xen-devel] [PATCH 07/11] swiotlb-xen: provide a single page-coherent.h header X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Konrad Rzeszutek Wilk , x86@kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Christoph Hellwig , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gRnJpLCBBdWcgMTYsIDIwMTkgYXQgMTE6NDA6NDNQTSArMDEwMCwgSnVsaWVuIEdyYWxsIHdy b3RlOgo+IEkgYW0gbm90IHN1cmUgSSBhZ3JlZSB3aXRoIHRoaXMgcmVuYW1lLiBUaGUgaW1wbGVt ZW50YXRpb24gb2YgdGhlIGhlbHBlcnMgCj4gYXJlIHZlcnkgQXJtIHNwZWNpZmljIGFzIHRoaXMg aXMgYXNzdW1pbmcgRG9tMCBpcyAxOjEgbWFwcGVkLgo+Cj4gVGhpcyB3YXMgbmVjZXNzYXJ5IGR1 ZSB0byB0aGUgbGFjayBvZiBJT01NVSBvbiBBcm0gcGxhdGZvcm1zIGJhY2sgdGhlbi4KPiBCdXQg dGhpcyBpcyBub3cgYSBwYWluIHRvIGdldCByaWQgb2YgaXQgb24gbmV3ZXIgcGxhdGZvcm0uLi4K ClNvIGlmIHlvdSBsb29rIGF0IHRoZSBmaW5hbCB2ZXJzaW9uIG9mIHRoZSBoZWFkZXIgYWZ0ZXIg dGhlIHdob2xlCnNlcmllcywgd2hhdCBhc3N1bWVzIGEgMToxIG1hcHBpbmc/ICBJdCBhbGwganVz dCBpcwoKCWlmIChwZm5fdmFsaWQoKSkKCQlsb2NhbCBjYWNoZSBzeW5jOwoJZWxzZQoJCWNhbGwg aW50byB0aGUgYXJjaCBjb2RlOwoKYXJlIHlvdSBjb25jZXJuZWQgdGhhdCB0aGUgbG9jYWwgY2Fj aGUgc3luYyBtaWdodCBoYXZlIHRvIGJlIHNwbGl0CnVwIG1vcmUgZm9yIGEgbm9uLTE6MSBtYXAg aW4gdGhhdCBjYXNlPyAgV2UgY291bGQganVzdCBtb3ZlCnRoZSB4ZW5fZG1hXyogcm91dGluZXMg aW50byB0aGUgYXJjaCBpbnN0ZWFkIG9mIF9feGVuX2RtYSwgYnV0IGl0CnJlYWxseSBoZWxwcyB0 byBoYXZlIGEgY29tbW9uIGludGVyZmFjZSBoZWFkZXIuCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZl bEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxt YW4vbGlzdGluZm8veGVuLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC5D9C3A59B for ; Sat, 17 Aug 2019 06:50:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADEB52077C for ; Sat, 17 Aug 2019 06:50:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pOfAf5yj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADEB52077C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O/7N3fSSwyuY7Qv/3nNlHIDt0qc+SsazCctCnXc0H8g=; b=pOfAf5yj75Hjzo y8nI9z5B2izNSI21QXzp/VgCD8oUF1+F6Y3MvYCujBN2/Mds9ATOF1LB1ccsminlcVeMoKTR5vNix VYS/3rpRvbzE7NhmN8es5ApEXAuJHUTZaQDIF3pgmMk+WP061ogXmlMxxLwQvB7tPu+KHDGsqkG5W Ru5D2wDkf+Tfev0Ed2QMc1hjukyYLrAnALgO9vksPVRgKKvDDKGHL5ZTGpjI1Pey5J+yKUPWa4m8C t8S4p2XYY7RiSIMP65gYO/lcNab8XvNK6bE4Vm6rAWDvIPf8f31kscdl/r/2+IgyBKHva6VcGdvG8 6VpdJ/lKciB9pILdMhEQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hysXg-0001Ig-AF; Sat, 17 Aug 2019 06:50:24 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hysXc-0001I5-T5 for linux-arm-kernel@lists.infradead.org; Sat, 17 Aug 2019 06:50:22 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 70BE768B05; Sat, 17 Aug 2019 08:50:12 +0200 (CEST) Date: Sat, 17 Aug 2019 08:50:11 +0200 From: Christoph Hellwig To: Julien Grall Subject: Re: [Xen-devel] [PATCH 07/11] swiotlb-xen: provide a single page-coherent.h header Message-ID: <20190817065011.GA18599@lst.de> References: <20190816130013.31154-1-hch@lst.de> <20190816130013.31154-8-hch@lst.de> <9a3261c6-5d92-cf6b-1ae8-3a8e8b5ef0d4@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9a3261c6-5d92-cf6b-1ae8-3a8e8b5ef0d4@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190816_235021_092196_71E1169D X-CRM114-Status: UNSURE ( 9.55 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Konrad Rzeszutek Wilk , x86@kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Christoph Hellwig , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 16, 2019 at 11:40:43PM +0100, Julien Grall wrote: > I am not sure I agree with this rename. The implementation of the helpers > are very Arm specific as this is assuming Dom0 is 1:1 mapped. > > This was necessary due to the lack of IOMMU on Arm platforms back then. > But this is now a pain to get rid of it on newer platform... So if you look at the final version of the header after the whole series, what assumes a 1:1 mapping? It all just is if (pfn_valid()) local cache sync; else call into the arch code; are you concerned that the local cache sync might have to be split up more for a non-1:1 map in that case? We could just move the xen_dma_* routines into the arch instead of __xen_dma, but it really helps to have a common interface header. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0157C3A59B for ; Sat, 17 Aug 2019 06:50:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CFD5D2077C for ; Sat, 17 Aug 2019 06:50:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726033AbfHQGuR (ORCPT ); Sat, 17 Aug 2019 02:50:17 -0400 Received: from verein.lst.de ([213.95.11.211]:60648 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725832AbfHQGuQ (ORCPT ); Sat, 17 Aug 2019 02:50:16 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 70BE768B05; Sat, 17 Aug 2019 08:50:12 +0200 (CEST) Date: Sat, 17 Aug 2019 08:50:11 +0200 From: Christoph Hellwig To: Julien Grall Cc: Christoph Hellwig , Stefano Stabellini , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, iommu@lists.linux-foundation.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [Xen-devel] [PATCH 07/11] swiotlb-xen: provide a single page-coherent.h header Message-ID: <20190817065011.GA18599@lst.de> References: <20190816130013.31154-1-hch@lst.de> <20190816130013.31154-8-hch@lst.de> <9a3261c6-5d92-cf6b-1ae8-3a8e8b5ef0d4@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9a3261c6-5d92-cf6b-1ae8-3a8e8b5ef0d4@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 16, 2019 at 11:40:43PM +0100, Julien Grall wrote: > I am not sure I agree with this rename. The implementation of the helpers > are very Arm specific as this is assuming Dom0 is 1:1 mapped. > > This was necessary due to the lack of IOMMU on Arm platforms back then. > But this is now a pain to get rid of it on newer platform... So if you look at the final version of the header after the whole series, what assumes a 1:1 mapping? It all just is if (pfn_valid()) local cache sync; else call into the arch code; are you concerned that the local cache sync might have to be split up more for a non-1:1 map in that case? We could just move the xen_dma_* routines into the arch instead of __xen_dma, but it really helps to have a common interface header.