diff for duplicates of <20190817065146.GA4451@kadam> diff --git a/a/1.txt b/N1/1.txt index e414805..33fa68d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -23,9 +23,9 @@ On Fri, Aug 16, 2019 at 11:10:11PM +0100, Colin King wrote: > uint32_t i; > - struct dc_firmware_info *fw_info = &init_data->bp->fw_info; > + struct dc_firmware_info *fw_info; -> if (calc_pll_cs = NULL || -> init_data = NULL || -> init_data->bp = NULL) +> if (calc_pll_cs == NULL || +> init_data == NULL || +> init_data->bp == NULL) init_data can't be NULL. I'm mostly pointing this out because that NULL check is written so higgledy-piggledy. At first I thought this was diff --git a/a/content_digest b/N1/content_digest index c4abefe..33fea4b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,20 +1,19 @@ "ref\020190816221011.10750-1-colin.king@canonical.com\0" - "ref\020190816221011.10750-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0Re: [PATCH][drm-next] drm/amd/display: fix a potential null pointer dereference\0" - "Date\0Sat, 17 Aug 2019 06:51:46 +0000\0" - "To\0Colin King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>\0" - "Cc\0David Zhou <David1.Zhou-5C7GfCeVMHo@public.gmane.org>" - Leo Li <sunpeng.li-5C7GfCeVMHo@public.gmane.org> - kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org - David Airlie <airlied-cv59FeDIM0c@public.gmane.org> - dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org - Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org> - Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org> - Harry Wentland <harry.wentland-5C7GfCeVMHo@public.gmane.org> - " Christian K\303\266nig <christian.koenig-5C7GfCeVMHo@public.gmane.org>\0" + "Date\0Sat, 17 Aug 2019 09:51:46 +0300\0" + "To\0Colin King <colin.king@canonical.com>\0" + "Cc\0Harry Wentland <harry.wentland@amd.com>" + Leo Li <sunpeng.li@amd.com> + Alex Deucher <alexander.deucher@amd.com> + " Christian K\303\266nig <christian.koenig@amd.com>" + David Zhou <David1.Zhou@amd.com> + David Airlie <airlied@linux.ie> + Daniel Vetter <daniel@ffwll.ch> + amd-gfx@lists.freedesktop.org + dri-devel@lists.freedesktop.org + kernel-janitors@vger.kernel.org + " linux-kernel@vger.kernel.org\0" "\00:1\0" "b\0" "On Fri, Aug 16, 2019 at 11:10:11PM +0100, Colin King wrote:\n" @@ -42,9 +41,9 @@ "> \tuint32_t i;\n" "> -\tstruct dc_firmware_info *fw_info = &init_data->bp->fw_info;\n" "> +\tstruct dc_firmware_info *fw_info;\n" - "> \tif (calc_pll_cs = NULL ||\n" - "> \t\t\tinit_data = NULL ||\n" - "> \t\t\tinit_data->bp = NULL)\n" + "> \tif (calc_pll_cs == NULL ||\n" + "> \t\t\tinit_data == NULL ||\n" + "> \t\t\tinit_data->bp == NULL)\n" "\n" "init_data can't be NULL. I'm mostly pointing this out because that NULL\n" "check is written so higgledy-piggledy. At first I thought this was\n" @@ -53,4 +52,4 @@ "regards,\n" dan carpenter -989a107bbc8b8e704286290e2deb9c5c430e68f4e87b661f372986587e2ebc25 +f4b1d12ac3320a5d9cb2793e7f16fdc4be5a6aef39c73fe7e66c6be760e1f487
diff --git a/a/1.txt b/N2/1.txt index e414805..c5f395a 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -23,9 +23,9 @@ On Fri, Aug 16, 2019 at 11:10:11PM +0100, Colin King wrote: > uint32_t i; > - struct dc_firmware_info *fw_info = &init_data->bp->fw_info; > + struct dc_firmware_info *fw_info; -> if (calc_pll_cs = NULL || -> init_data = NULL || -> init_data->bp = NULL) +> if (calc_pll_cs == NULL || +> init_data == NULL || +> init_data->bp == NULL) init_data can't be NULL. I'm mostly pointing this out because that NULL check is written so higgledy-piggledy. At first I thought this was @@ -33,3 +33,8 @@ staging code so I was planning to ignore the patch. :P regards, dan carpenter + +_______________________________________________ +amd-gfx mailing list +amd-gfx@lists.freedesktop.org +https://lists.freedesktop.org/mailman/listinfo/amd-gfx diff --git a/a/content_digest b/N2/content_digest index c4abefe..0d121fe 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,8 +1,8 @@ "ref\020190816221011.10750-1-colin.king@canonical.com\0" "ref\020190816221011.10750-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org\0" - "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" + "From\0Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>\0" "Subject\0Re: [PATCH][drm-next] drm/amd/display: fix a potential null pointer dereference\0" - "Date\0Sat, 17 Aug 2019 06:51:46 +0000\0" + "Date\0Sat, 17 Aug 2019 09:51:46 +0300\0" "To\0Colin King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>\0" "Cc\0David Zhou <David1.Zhou-5C7GfCeVMHo@public.gmane.org>" Leo Li <sunpeng.li-5C7GfCeVMHo@public.gmane.org> @@ -42,15 +42,20 @@ "> \tuint32_t i;\n" "> -\tstruct dc_firmware_info *fw_info = &init_data->bp->fw_info;\n" "> +\tstruct dc_firmware_info *fw_info;\n" - "> \tif (calc_pll_cs = NULL ||\n" - "> \t\t\tinit_data = NULL ||\n" - "> \t\t\tinit_data->bp = NULL)\n" + "> \tif (calc_pll_cs == NULL ||\n" + "> \t\t\tinit_data == NULL ||\n" + "> \t\t\tinit_data->bp == NULL)\n" "\n" "init_data can't be NULL. I'm mostly pointing this out because that NULL\n" "check is written so higgledy-piggledy. At first I thought this was\n" "staging code so I was planning to ignore the patch. :P\n" "\n" "regards,\n" - dan carpenter + "dan carpenter\n" + "\n" + "_______________________________________________\n" + "amd-gfx mailing list\n" + "amd-gfx@lists.freedesktop.org\n" + https://lists.freedesktop.org/mailman/listinfo/amd-gfx -989a107bbc8b8e704286290e2deb9c5c430e68f4e87b661f372986587e2ebc25 +7dd3d5d3e52e062d64233a46c3c6d79f47fce2679d0ef628bd63ead5ade5c81b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.