From: Christoph Hellwig <hch@lst.de>
To: Jason Gunthorpe <jgg@mellanox.com>
Cc: "Christoph Hellwig" <hch@lst.de>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Ralph Campbell" <rcampbell@nvidia.com>,
"Bharata B Rao" <bharata@linux.ibm.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 01/10] mm: turn migrate_vma upside down
Date: Sat, 17 Aug 2019 13:31:28 +0200 [thread overview]
Message-ID: <20190817113128.GA23295@lst.de> (raw)
In-Reply-To: <20190816171101.GK5412@mellanox.com>
On Fri, Aug 16, 2019 at 05:11:07PM +0000, Jason Gunthorpe wrote:
> - if (args->cpages)
> - migrate_vma_prepare(args);
> - if (args->cpages)
> - migrate_vma_unmap(args);
> + if (!args->cpages)
> + return 0;
> +
> + migrate_vma_prepare(args);
> + migrate_vma_unmap(args);
I don't think this is ok. Both migrate_vma_prepare and migrate_vma_unmap
can reduce args->cpages, including possibly to 0.
next prev parent reply other threads:[~2019-08-17 11:31 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 7:59 turn hmm migrate_vma upside down v3 Christoph Hellwig
[not found] ` <20190814075928.23766-1-hch-jcswGhMUV9g@public.gmane.org>
2019-08-14 7:59 ` [PATCH 01/10] mm: turn migrate_vma upside down Christoph Hellwig
2019-08-14 7:59 ` Christoph Hellwig
[not found] ` <20190814075928.23766-2-hch-jcswGhMUV9g@public.gmane.org>
2019-08-14 13:47 ` William Lewis
2019-08-16 17:11 ` Jason Gunthorpe
2019-08-16 17:11 ` Jason Gunthorpe
2019-08-17 11:31 ` Christoph Hellwig [this message]
[not found] ` <20190817113128.GA23295-jcswGhMUV9g@public.gmane.org>
2019-08-17 12:50 ` Jason Gunthorpe
2019-08-17 12:50 ` Jason Gunthorpe
2019-08-14 7:59 ` [PATCH 04/10] nouveau: factor out dmem fence completion Christoph Hellwig
2019-08-14 7:59 ` Christoph Hellwig
2019-08-14 7:59 ` [PATCH 05/10] nouveau: remove a few function stubs Christoph Hellwig
2019-08-14 7:59 ` Christoph Hellwig
2019-08-14 7:59 ` [PATCH 06/10] nouveau: simplify nouveau_dmem_migrate_to_ram Christoph Hellwig
2019-08-14 7:59 ` Christoph Hellwig
2019-08-14 7:59 ` [PATCH 07/10] nouveau: simplify nouveau_dmem_migrate_vma Christoph Hellwig
2019-08-14 7:59 ` Christoph Hellwig
2019-08-14 7:59 ` [PATCH 09/10] mm: remove the unused MIGRATE_PFN_DEVICE flag Christoph Hellwig
2019-08-14 7:59 ` Christoph Hellwig
[not found] ` <20190814075928.23766-10-hch-jcswGhMUV9g@public.gmane.org>
2019-08-16 15:23 ` Jason Gunthorpe
2019-08-16 15:23 ` Jason Gunthorpe
2019-08-14 7:59 ` [PATCH 10/10] mm: remove CONFIG_MIGRATE_VMA_HELPER Christoph Hellwig
2019-08-14 7:59 ` Christoph Hellwig
[not found] ` <20190814075928.23766-11-hch-jcswGhMUV9g@public.gmane.org>
2019-08-16 15:21 ` Jason Gunthorpe
2019-08-16 15:21 ` Jason Gunthorpe
2019-08-14 7:59 ` [PATCH 02/10] nouveau: reset dma_nr in nouveau_dmem_migrate_alloc_and_copy Christoph Hellwig
2019-08-14 7:59 ` [PATCH 03/10] nouveau: factor out device memory address calculation Christoph Hellwig
2019-08-14 7:59 ` [PATCH 08/10] mm: remove the unused MIGRATE_PFN_ERROR flag Christoph Hellwig
2019-08-15 0:09 ` turn hmm migrate_vma upside down v3 Ralph Campbell
2019-08-15 0:09 ` Ralph Campbell
2019-08-15 13:28 ` Christoph Hellwig
2019-08-16 6:51 ` Christoph Hellwig
2019-08-16 11:45 ` Jason Gunthorpe
2019-08-16 17:23 ` Jason Gunthorpe
2019-08-16 17:12 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190817113128.GA23295@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=bharata@linux.ibm.com \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jgg@mellanox.com \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rcampbell@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.