From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E0E4C3A59B for ; Sat, 17 Aug 2019 21:42:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EEEC20578 for ; Sat, 17 Aug 2019 21:42:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="o2msdq+T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EEEC20578 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version: References:Message-ID:Subject:To:From:Date:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ss3mIRN2XivQ2H7+DZE9mQ+0b7uTM4jNSE78vcP2RAI=; b=o2msdq+TyvdFh3 lIMvhCTX66bEROHdQjlFumMjgRP0Z73FJCEu36r4adSFyfv30QWpdFYa2yUdiha7qX3RFAvfFiDZl z9jngXgdtEXD3aO+VB+9wnmSUZK/Z7Cs0CUH0D55ornjtJqpRguHWDvRUtR/+bCz/3l2oWxfRHQUP AOviiE2SbCinjwEbi39iw+dOKmJVnVcMdbKPX6pLzdKTmmGxEfIEN1k8+3seOFVuuWLkHuGpgCp1w R1d+pS+0gL/tyY1HM6/nvmnDwIdmQtj7OWhTdahGSlORhUpz11uNvSRonzmnjgcWXA/2t16crmpkO MhSOWUaKN4NahiwWHlbg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hz6Sv-0006hk-VY; Sat, 17 Aug 2019 21:42:25 +0000 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5] helo=mx0a-001b2d01.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hz6St-0006gw-QD for linux-riscv@lists.infradead.org; Sat, 17 Aug 2019 21:42:25 +0000 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x7HLgJQo070110; Sat, 17 Aug 2019 17:42:20 -0400 Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0b-001b2d01.pphosted.com with ESMTP id 2ueagrykqm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 17 Aug 2019 17:42:20 -0400 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id x7HLdlMV021950; Sat, 17 Aug 2019 21:42:17 GMT Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by ppma02dal.us.ibm.com with ESMTP id 2ue9760hdq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 17 Aug 2019 21:42:17 +0000 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x7HLgHQ636438384 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 17 Aug 2019 21:42:17 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 03038B2065; Sat, 17 Aug 2019 21:42:17 +0000 (GMT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D6CAEB205F; Sat, 17 Aug 2019 21:42:16 +0000 (GMT) Received: from paulmck-ThinkPad-W541 (unknown [9.85.201.199]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Sat, 17 Aug 2019 21:42:16 +0000 (GMT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id BE05416C1700; Sat, 17 Aug 2019 14:42:17 -0700 (PDT) Date: Sat, 17 Aug 2019 14:42:17 -0700 From: "Paul E. McKenney" To: Joel Fernandes Subject: Re: [PATCH -rcu/dev] Please squash: fixup! rcu/tree: Add basic support for kfree_rcu() batching Message-ID: <20190817214217.GD28441@linux.ibm.com> References: <20190817042211.137149-1-joel@joelfernandes.org> <20190817044308.GA139754@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190817044308.GA139754@google.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-08-17_10:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908170237 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190817_144223_972963_09E516CD X-CRM114-Status: GOOD ( 17.23 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: paulmck@linux.ibm.com Cc: rcu@vger.kernel.org, linux-riscv@lists.infradead.org, Palmer Dabbelt , linux-kernel@vger.kernel.org, Paul Walmsley Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Sat, Aug 17, 2019 at 12:43:08AM -0400, Joel Fernandes wrote: > On Fri, Aug 16, 2019 at 09:38:54PM -0700, Paul Walmsley wrote: > > On Sat, 17 Aug 2019, Joel Fernandes (Google) wrote: > > > > > xchg() on a bool is causing issues on riscv and arm32. > > > > Indeed, it seems best not to use xchg() on any type that's not 32 bits > > long or that's not the CPU's native word size. Probably we should update > > the documentation. > > I would endorse any such documentation effort ;-) > > > > Please squash this into the -rcu dev branch to resolve the issue. > > > > > > Please squash this fix. Done, please see below for updated version. > > > Fixes: -rcu dev commit 3cbd3aa7d9c7bdf ("rcu/tree: Add basic support for kfree_rcu() batching") > > > > > > Signed-off-by: Joel Fernandes (Google) > > > > Link: https://lore.kernel.org/lkml/alpine.DEB.2.21.9999.1908161931110.32497@viisi.sifive.com/T/#me9956f66cb611b95d26ae92700e1d901f46e8c59 > > Reviewed-by: Paul Walmsley I added the link, thank you Paul! If you meant the Reviewed-by to apply to the entire kfree_rcu() patch, I will of course be very happy to apply that as well. > Thanks Paul! And nice to meet you again after many years ;-) Glad to see you > working on riscv. What Joel said! ;-) Thanx, Paul _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30CB8C3A59B for ; Sat, 17 Aug 2019 21:42:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 070E620578 for ; Sat, 17 Aug 2019 21:42:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726390AbfHQVm1 (ORCPT ); Sat, 17 Aug 2019 17:42:27 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:44402 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726372AbfHQVm1 (ORCPT ); Sat, 17 Aug 2019 17:42:27 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x7HLgJQo070110; Sat, 17 Aug 2019 17:42:20 -0400 Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0b-001b2d01.pphosted.com with ESMTP id 2ueagrykqm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 17 Aug 2019 17:42:20 -0400 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id x7HLdlMV021950; Sat, 17 Aug 2019 21:42:17 GMT Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by ppma02dal.us.ibm.com with ESMTP id 2ue9760hdq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 17 Aug 2019 21:42:17 +0000 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x7HLgHQ636438384 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 17 Aug 2019 21:42:17 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 03038B2065; Sat, 17 Aug 2019 21:42:17 +0000 (GMT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D6CAEB205F; Sat, 17 Aug 2019 21:42:16 +0000 (GMT) Received: from paulmck-ThinkPad-W541 (unknown [9.85.201.199]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Sat, 17 Aug 2019 21:42:16 +0000 (GMT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id BE05416C1700; Sat, 17 Aug 2019 14:42:17 -0700 (PDT) Date: Sat, 17 Aug 2019 14:42:17 -0700 From: "Paul E. McKenney" To: Joel Fernandes Cc: Paul Walmsley , linux-kernel@vger.kernel.org, Palmer Dabbelt , rcu@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH -rcu/dev] Please squash: fixup! rcu/tree: Add basic support for kfree_rcu() batching Message-ID: <20190817214217.GD28441@linux.ibm.com> Reply-To: paulmck@linux.ibm.com References: <20190817042211.137149-1-joel@joelfernandes.org> <20190817044308.GA139754@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190817044308.GA139754@google.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-08-17_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908170237 Sender: rcu-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: rcu@vger.kernel.org On Sat, Aug 17, 2019 at 12:43:08AM -0400, Joel Fernandes wrote: > On Fri, Aug 16, 2019 at 09:38:54PM -0700, Paul Walmsley wrote: > > On Sat, 17 Aug 2019, Joel Fernandes (Google) wrote: > > > > > xchg() on a bool is causing issues on riscv and arm32. > > > > Indeed, it seems best not to use xchg() on any type that's not 32 bits > > long or that's not the CPU's native word size. Probably we should update > > the documentation. > > I would endorse any such documentation effort ;-) > > > > Please squash this into the -rcu dev branch to resolve the issue. > > > > > > Please squash this fix. Done, please see below for updated version. > > > Fixes: -rcu dev commit 3cbd3aa7d9c7bdf ("rcu/tree: Add basic support for kfree_rcu() batching") > > > > > > Signed-off-by: Joel Fernandes (Google) > > > > Link: https://lore.kernel.org/lkml/alpine.DEB.2.21.9999.1908161931110.32497@viisi.sifive.com/T/#me9956f66cb611b95d26ae92700e1d901f46e8c59 > > Reviewed-by: Paul Walmsley I added the link, thank you Paul! If you meant the Reviewed-by to apply to the entire kfree_rcu() patch, I will of course be very happy to apply that as well. > Thanks Paul! And nice to meet you again after many years ;-) Glad to see you > working on riscv. What Joel said! ;-) Thanx, Paul