From: Greg KH <gregkh@linuxfoundation.org>
To: Donald Yandt <donald.yandt@gmail.com>
Cc: devel@driverdev.osuosl.org, tkjos@android.com,
linux-kernel@vger.kernel.org, arve@android.com,
joel@joelfernandes.org, maco@android.com, christian@brauner.io
Subject: Re: [PATCH] staging: android: Remove ion device tree bindings from the TODO
Date: Sun, 18 Aug 2019 08:31:24 +0200 [thread overview]
Message-ID: <20190818063124.GA31192@kroah.com> (raw)
In-Reply-To: <CADm=fgmb-JN-t-VxFSfWw_UzvxO__P6NkNh+U3XhR6+NRtK9yw@mail.gmail.com>
On Sun, Aug 18, 2019 at 01:47:38AM -0400, Donald Yandt wrote:
> On Sun, Aug 18, 2019 at 1:03 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Sat, Aug 17, 2019 at 05:37:58PM -0400, Donald Yandt wrote:
> > > This patch removes the todo for the ion chunk and
> > > carveout device tree bindings.
> > >
> > > Signed-off-by: Donald Yandt <donald.yandt@gmail.com>
> > > ---
> > > drivers/staging/android/TODO | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO
> > > index fbf015cc6..767dd98fd 100644
> > > --- a/drivers/staging/android/TODO
> > > +++ b/drivers/staging/android/TODO
> > > @@ -6,8 +6,6 @@ TODO:
> > >
> > >
> > > ion/
> > > - - Add dt-bindings for remaining heaps (chunk and carveout heaps). This would
> > > - involve putting appropriate bindings in a memory node for Ion to find.
> > > - Split /dev/ion up into multiple nodes (e.g. /dev/ion/heap0)
> > > - Better test framework (integration with VGEM was suggested)
> > >
> >
> > This is already done? Do you have a pointer to the git commit id(s)
> > that did it?
> >
> > thanks,
> >
> > greg k-h
>
> Hi Greg,
>
> Both the chunk and carveout heaps were removed from ion,
> so unless I'm mistaken there's no need to implement the device tree
> bindings for them.
>
> Commits that removed both heaps:
> - 23a4388f2 staging: android: ion: Remove file ion_chunk_heap.c
> - eadbf7a34 staging: android: ion: Remove file ion_carveout_heap.c
Great, can you resend this patch with that information in the changelog?
As you wrote it, it could be implied that these tasks were actually
completed :)
thanks,
greg k-h
prev parent reply other threads:[~2019-08-18 6:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-17 21:37 [PATCH] staging: android: Remove ion device tree bindings from the TODO Donald Yandt
2019-08-18 5:03 ` Greg KH
2019-08-18 5:47 ` Donald Yandt
2019-08-18 6:31 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190818063124.GA31192@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=devel@driverdev.osuosl.org \
--cc=donald.yandt@gmail.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.