From: Florian Westphal <fw@strlen.de>
To: wenxu@ucloud.cn
Cc: pablo@netfilter.org, fw@strlen.de, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next] netfilter: nf_table_offload: Fix the incorrect rcu usage in nft_indr_block_get_and_ing_cmd
Date: Mon, 19 Aug 2019 12:21:23 +0200 [thread overview]
Message-ID: <20190819102123.GA2588@breakpoint.cc> (raw)
In-Reply-To: <1566208007-22513-1-git-send-email-wenxu@ucloud.cn>
wenxu@ucloud.cn <wenxu@ucloud.cn> wrote:
> From: wenxu <wenxu@ucloud.cn>
>
> The nft_indr_block_get_and_ing_cmd is called in netdevice notify
> It is the incorrect rcu case, To fix it just traverse the list under
> the commit mutex.
What is an 'incorrect rcu case'?
Please clarify, e.g. by including rcu warning/splat backtrace here.
> + struct nft_ctx ctx = {
> + .net = dev_net(dev),
> + };
Why is this ctx needed?
> + mutex_lock(&ctx.net->nft.commit_mutex);
net->nft.commit_mutex?
> - list_for_each_entry_rcu(chain, &table->chains, list) {
> + list_for_each_entry_safe(chain, nr, &table->chains, list) {
Why is _safe needed rather than list_for_each_entry()?
next prev parent reply other threads:[~2019-08-19 10:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 9:46 [PATCH nf-next] netfilter: nf_table_offload: Fix the incorrect rcu usage in nft_indr_block_get_and_ing_cmd wenxu
2019-08-19 10:21 ` Florian Westphal [this message]
2019-08-19 10:48 ` wenxu
2019-08-19 10:59 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190819102123.GA2588@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wenxu@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.