From: Florian Westphal <fw at strlen.de>
To: mptcp at lists.01.org
Subject: Re: [MPTCP] [PRE-RFC 3/6] mptcp: update msk unacked sequence in sendmsg()
Date: Mon, 19 Aug 2019 13:09:27 +0200 [thread overview]
Message-ID: <20190819110927.GD2588@breakpoint.cc> (raw)
In-Reply-To: 165e8c8bb1924963f285a6025e7582487758c561.1565970525.git.pabeni@redhat.com
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
Paolo Abeni <pabeni(a)redhat.com> wrote:
> + /* heuristic to avoid doing the expensive data ack update frequently */
> + if (snd_una + tcp_sk(sk)->snd_cwnd <= msk->write_seq)
> + snd_una = mptcp_update_msk_una(sk);
I think this will need to protect against sequence wraparound.
> + /* if we msk just switched to this subflow, update subflow's una
> + * to allow 32 bit ack update to be more accurate
> + */
> + subflow = subflow_ctx(ssk);
> + if (after64(snd_una, subflow->snd_una))
> + subflow->snd_una = snd_una;
... like you did here.
next reply other threads:[~2019-08-19 11:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 11:09 Florian Westphal [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-08-16 16:48 [MPTCP] [PRE-RFC 3/6] mptcp: update msk unacked sequence in sendmsg() Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190819110927.GD2588@breakpoint.cc \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.