From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68065C3A59B for ; Mon, 19 Aug 2019 09:22:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C3DE2184D for ; Mon, 19 Aug 2019 09:22:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="az3iOxFV"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="osS0LYtr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C3DE2184D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p8FuJxSQwnTWBKVGLOwK1SjpWohH1J8xd1oK8UsU05g=; b=az3iOxFVcT8/wK W+KARGIMTsF+xvls/GesW4jVDhrbT9EZ5y3dmTkhJ0NuNd15HeJaAB2N4yMK+t58VvkpR5ul31pTk dJPjOkl7p/+BhMLGprb2cRMjR/Iy1PK6rWwwYyZRxg+7bG9pTSA8V3DbDppFpFNKzOo9AA8fWDYn0 ss91dKfWa9SneUQw0hnoET49DN6AXv/yIWGTU18de81DeXQYiE60iZHq+hwToJxQuD0+mZlDGhxGn lfW7njmAnj5oWgD/hNCS6xy/tTrp1MMEFWVBF7ZTv0vhj8khMdU+K+Oi5H0l1IJwA4eAN2nHf+VzM YYUkAaFnxLOgCeyQ4n3Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hzdrI-0004rv-P2; Mon, 19 Aug 2019 09:21:48 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hzdpb-0002kR-KH for linux-mtd@bombadil.infradead.org; Mon, 19 Aug 2019 09:20:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Mo4fE9xiDwuq/JOARJXN4C1vT6elVtfNQseskBqQSyk=; b=osS0LYtr4hsZETXsIDwInsHjLF I2VqCp7tla7+tCQjdIRcOLT0tIuONE+wFoYEAcZFoPssC6ZXdPjlJHKDThoTIj7kBZenRY14EWIiu R4lalKDwmOqZsEKdUN29mfes1I1OhvTU/l34y+YLlARI3Y8O1nbgXYY5Z/piNwPVY/RueedlH/Yvd eZk+5qJXX19Q6KT1lY8CpD+KB+JnImqb521KqsQid0EeDgwUOS58xQtsmhSpX4CaFJL8oMqYRPNBl zmOe1CnB1dW9RJbXtUl1GMx9nC6qGC3djW8esZvWCA14cRfZCJpYTz5p5XL6lw0e1nFLGvElrof3v HeC52iZA==; Received: from relay12.mail.gandi.net ([217.70.178.232]) by merlin.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hzdpY-0002kj-JL for linux-mtd@lists.infradead.org; Mon, 19 Aug 2019 09:20:02 +0000 Received: from xps13 (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 5038F20000C; Mon, 19 Aug 2019 09:19:19 +0000 (UTC) Date: Mon, 19 Aug 2019 11:19:18 +0200 From: Miquel Raynal To: "Shivamurthy Shastri (sshivamurthy)" Subject: Re: [EXT] Re: [PATCH 6/8] mtd: spinand: micron: Turn driver implementation generic Message-ID: <20190819111918.6be79570@xps13> In-Reply-To: References: <20190722055621.23526-1-sshivamurthy@micron.com> <20190722055621.23526-7-sshivamurthy@micron.com> <20190807120408.031b8d1b@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chuanhong Guo , Vignesh Raghavendra , Boris Brezillon , Marcel Ziswiler , Richard Weinberger , "linux-kernel@vger.kernel.org" , Frieder Schrempf , liaoweixiong , Marek Vasut , "linux-mtd@lists.infradead.org" , Jeff Kletsky , Brian Norris , David Woodhouse Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgQm9yaXMsCgpJIG5lZWQgeW91ciBvcGluaW9uIG9uIHRoZSBxdWVzdGlvbiBiZWxvdy4KCiJT aGl2YW11cnRoeSBTaGFzdHJpIChzc2hpdmFtdXJ0aHkpIiA8c3NoaXZhbXVydGh5QG1pY3Jvbi5j b20+IHdyb3RlIG9uCk1vbiwgMTkgQXVnIDIwMTkgMDk6MDM6MzggKzAwMDA6Cgo+IEhpIE1pcXVl bCwKPiAKPiA+IAo+ID4gSGkgU2hpdmEsCj4gPiAKPiA+IHNoaXZhLmxpbnV4d29ya3NAZ21haWwu Y29tIHdyb3RlIG9uIE1vbiwgMjIgSnVsIDIwMTkgMDc6NTY6MTkgKzAyMDA6Cj4gPiAgIAo+ID4g PiBGcm9tOiBTaGl2YW11cnRoeSBTaGFzdHJpIDxzc2hpdmFtdXJ0aHlAbWljcm9uLmNvbT4KPiA+ ID4gIAo+ID4gCj4gPiBJIGFtIG5vdCBzdXJlIHRoZSAidHVybiBpbXBsZW1lbmF0YXRpb24gZ2Vu ZXJpYyIgdGl0bGUgZGVzY3JpYmVzIHdoYXQKPiA+IHlvdSBkby4KPiA+ICAgCj4gPiA+IERyaXZl ciBpcyByZWRlc2lnbmVkIHVzaW5nIHBhcmFtZXRlciBwYWdlIHRvIHN1cHBvcnQgTWljcm9uIFNQ SSBOQU5ECj4gPiA+IGZsYXNoZXMuICAKPiA+IAo+ID4gUmVkZXNpZ25lZCBpcyBwZXJoYXBzIGEg Yml0IHRvbyBtdWNoLgo+ID4gCj4gPiAiICAKPiA+ID4gVGhlIHJlYXNvbiB3aHkgc3BpbmFuZF9z ZWxlY3Rfb3BfdmFyaWFudCBnbG9iYWxpemVkIGlzIHRoYXQgdGhlIE1pY3Jvbgo+ID4gPiBkcml2 ZXIgbm8gbG9uZ2VyIGNhbGxpbmcgc3BpbmFuZF9tYXRjaF9hbmRfaW5pdC4KPiA+ID4KPiA+ID4g U2lnbmVkLW9mZi1ieTogU2hpdmFtdXJ0aHkgU2hhc3RyaSA8c3NoaXZhbXVydGh5QG1pY3Jvbi5j b20+Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9tdGQvbmFuZC9zcGkvY29yZS5jICAgfCAgMiAr LQo+ID4gPiAgZHJpdmVycy9tdGQvbmFuZC9zcGkvbWljcm9uLmMgfCA2MSArKysrKysrKysrKysr KysrKysrKysrKysrLS0tLS0tLSAgCj4gPiAtLS0gIAo+ID4gPiAgaW5jbHVkZS9saW51eC9tdGQv c3BpbmFuZC5oICAgfCAgNCArKysKPiA+ID4gIDMgZmlsZXMgY2hhbmdlZCwgNDkgaW5zZXJ0aW9u cygrKSwgMTggZGVsZXRpb25zKC0pCj4gPiA+Cj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210 ZC9uYW5kL3NwaS9jb3JlLmMgYi9kcml2ZXJzL210ZC9uYW5kL3NwaS9jb3JlLmMKPiA+ID4gaW5k ZXggN2FlNzZkYWI5MTQxLi5hYWU3MTVkMzg4YjcgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMv bXRkL25hbmQvc3BpL2NvcmUuYwo+ID4gPiArKysgYi9kcml2ZXJzL210ZC9uYW5kL3NwaS9jb3Jl LmMKPiA+ID4gQEAgLTkyMCw3ICs5MjAsNyBAQCBzdGF0aWMgdm9pZCBzcGluYW5kX21hbnVmYWN0 dXJlcl9jbGVhbnVwKHN0cnVjdCAgCj4gPiBzcGluYW5kX2RldmljZSAqc3BpbmFuZCkgIAo+ID4g PiAgCQlyZXR1cm4gc3BpbmFuZC0+bWFudWZhY3R1cmVyLT5vcHMtPmNsZWFudXAoc3BpbmFuZCk7 Cj4gPiA+ICB9Cj4gPiA+Cj4gPiA+IC1zdGF0aWMgY29uc3Qgc3RydWN0IHNwaV9tZW1fb3AgKgo+ ID4gPiArY29uc3Qgc3RydWN0IHNwaV9tZW1fb3AgKgo+ID4gPiAgc3BpbmFuZF9zZWxlY3Rfb3Bf dmFyaWFudChzdHJ1Y3Qgc3BpbmFuZF9kZXZpY2UgKnNwaW5hbmQsCj4gPiA+ICAJCQkgIGNvbnN0 IHN0cnVjdCBzcGluYW5kX29wX3ZhcmlhbnRzICp2YXJpYW50cykKPiA+ID4gIHsKPiA+ID4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvbXRkL25hbmQvc3BpL21pY3Jvbi5jICAKPiA+IGIvZHJpdmVycy9t dGQvbmFuZC9zcGkvbWljcm9uLmMgIAo+ID4gPiBpbmRleCA5NWJjNTI2NGViYzEuLjZmZGU5M2Vj MjNhMSAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9tdGQvbmFuZC9zcGkvbWljcm9uLmMKPiA+ ID4gKysrIGIvZHJpdmVycy9tdGQvbmFuZC9zcGkvbWljcm9uLmMKPiA+ID4gQEAgLTkwLDIyICs5 MCwxMCBAQCBzdGF0aWMgaW50IG1pY3Jvbl9lY2NfZ2V0X3N0YXR1cyhzdHJ1Y3QgIAo+ID4gc3Bp bmFuZF9kZXZpY2UgKnNwaW5hbmQsICAKPiA+ID4gIAlyZXR1cm4gLUVJTlZBTDsKPiA+ID4gIH0K PiA+ID4KPiA+ID4gLXN0YXRpYyBjb25zdCBzdHJ1Y3Qgc3BpbmFuZF9pbmZvIG1pY3Jvbl9zcGlu YW5kX3RhYmxlW10gPSB7Cj4gPiA+IC0JU1BJTkFORF9JTkZPKCJNVDI5RjJHMDFBQkFHRCIsIDB4 MjQsCj4gPiA+IC0JCSAgICAgTkFORF9NRU1PUkcoMSwgMjA0OCwgMTI4LCA2NCwgMjA0OCwgNDAs IDIsIDEsIDEpLAo+ID4gPiAtCQkgICAgIE5BTkRfRUNDUkVRKDgsIDUxMiksCj4gPiA+IC0JCSAg ICAgU1BJTkFORF9JTkZPX09QX1ZBUklBTlRTKCZyZWFkX2NhY2hlX3ZhcmlhbnRzLAo+ID4gPiAt CQkJCQkgICAgICAmd3JpdGVfY2FjaGVfdmFyaWFudHMsCj4gPiA+IC0JCQkJCSAgICAgICZ1cGRh dGVfY2FjaGVfdmFyaWFudHMpLAo+ID4gPiAtCQkgICAgIDAsCj4gPiA+IC0JCSAgICAgU1BJTkFO RF9FQ0NJTkZPKCZtaWNyb25fb29ibGF5b3V0X29wcywKPiA+ID4gLQkJCQkgICAgIG1pY3Jvbl9l Y2NfZ2V0X3N0YXR1cykpLAo+ID4gPiAtfTsKPiA+ID4gLSAgCj4gPiAKPiA+IEkgZG9uJ3Qga25v dyBpZiBpdCBpcyB3aXNlIHRvIGRyb3AgdGhpcyBzdHJ1Y3R1cmUuCj4gPiAgIAo+ID4gPiAgc3Rh dGljIGludCBtaWNyb25fc3BpbmFuZF9kZXRlY3Qoc3RydWN0IHNwaW5hbmRfZGV2aWNlICpzcGlu YW5kKQo+ID4gPiAgewo+ID4gPiArCWNvbnN0IHN0cnVjdCBzcGlfbWVtX29wICpvcDsKPiA+ID4g IAl1OCAqaWQgPSBzcGluYW5kLT5pZC5kYXRhOwo+ID4gPiAtCWludCByZXQ7Cj4gPiA+Cj4gPiA+ ICAJLyoKPiA+ID4gIAkgKiBNaWNyb24gU1BJIE5BTkQgcmVhZCBJRCBuZWVkIGEgZHVtbXkgYnl0 ZSwKPiA+ID4gQEAgLTExNCwxNiArMTAyLDU1IEBAIHN0YXRpYyBpbnQgbWljcm9uX3NwaW5hbmRf ZGV0ZWN0KHN0cnVjdCAgCj4gPiBzcGluYW5kX2RldmljZSAqc3BpbmFuZCkgIAo+ID4gPiAgCWlm IChpZFsxXSAhPSBTUElOQU5EX01GUl9NSUNST04pCj4gPiA+ICAJCXJldHVybiAwOwo+ID4gPgo+ ID4gPiAtCXJldCA9IHNwaW5hbmRfbWF0Y2hfYW5kX2luaXQoc3BpbmFuZCwgbWljcm9uX3NwaW5h bmRfdGFibGUsCj4gPiA+IC0JCQkJICAgICBBUlJBWV9TSVpFKG1pY3Jvbl9zcGluYW5kX3RhYmxl KSwgIAo+ID4gaWRbMl0pOwo+ID4gCj4gPiBJIGFtIG5vdCBzdXJlIHRoaXMgaXMgdGhlIHJpZ2h0 IHNvbHV0aW9uLiBJIHdvdWxkIGtlZXAgdGhpcyBjYWxsIGFuZAo+ID4gb3ZlcndyaXRlIHdoYXQg eW91IG5lZWQgdG8gb3ZlcndyaXRlIHdpdGggdGhlIGZpeHVwIGhvb2suCj4gPiAgIAo+IAo+IFRo ZW4sIEkgd2lsbCBoYXZlIGR1bW15IHN0cnVjdHVyZSBsaWtlIGJlbG93Lgo+IAo+IHN0YXRpYyBj b25zdCBzdHJ1Y3Qgc3BpbmFuZF9pbmZvIG1pY3Jvbl9zcGluYW5kX3RhYmxlW10gPSB7ICAgICAg ICAgICAgICAgICAgICAgIAo+ICAgICAgICAgU1BJTkFORF9JTkZPKE5VTEwsIDAsICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAKPiAgICAgICAgICAgICAgICAgICAgICBOQU5EX01FTU9SRygwLCAwLCAwLCAwLCAwLCAwLCAw LCAwLCAwKSwgICAgICAgICAgIAo+ICAgICAgICAgICAgICAgICAgICAgIE5BTkRfRUNDUkVRKDAs IDApLCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgCj4gICAgICAgICAgICAgICAgICAgICAgU1BJTkFORF9JTkZPX09Q X1ZBUklBTlRTKCZyZWFkX2NhY2hlX3ZhcmlhbnRzLCAgICAgICAgICAgICAgCj4gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZ3cml0ZV9jYWNoZV92YXJpYW50 cywgICAgICAgICAgICAgCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICZ1cGRhdGVfY2FjaGVfdmFyaWFudHMpLCAgICAgICAgICAgCj4gICAgICAgICAgICAg ICAgICAgICAgMCwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAo+ICAgICAgICAgICAg ICAgICAgICAgIFNQSU5BTkRfRUNDSU5GTygmbWljcm9uX29vYmxheW91dF9vcHMsICAgICAgICAg ICAgICAgICAgICAgIAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtaWNy b25fZWNjX2dldF9zdGF0dXMpKSwgICAgICAgICAgICAgICAgICAgIAo+IH07ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgCj4gCj4gTGV0IG1lIGtub3cgaWYgeW91IGFyZSB0aGlu a2luZyBmb3IgZGlmZmVyZW50IGFwcHJvYWNoLgo+IAoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVRE IGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14AF5C3A59B for ; Mon, 19 Aug 2019 09:19:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E493F2184D for ; Mon, 19 Aug 2019 09:19:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727431AbfHSJTY convert rfc822-to-8bit (ORCPT ); Mon, 19 Aug 2019 05:19:24 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:44895 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727068AbfHSJTY (ORCPT ); Mon, 19 Aug 2019 05:19:24 -0400 Received: from xps13 (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 5038F20000C; Mon, 19 Aug 2019 09:19:19 +0000 (UTC) Date: Mon, 19 Aug 2019 11:19:18 +0200 From: Miquel Raynal To: "Shivamurthy Shastri (sshivamurthy)" Cc: Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Vignesh Raghavendra , Boris Brezillon , Marcel Ziswiler , Frieder Schrempf , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Jeff Kletsky , Chuanhong Guo , liaoweixiong Subject: Re: [EXT] Re: [PATCH 6/8] mtd: spinand: micron: Turn driver implementation generic Message-ID: <20190819111918.6be79570@xps13> In-Reply-To: References: <20190722055621.23526-1-sshivamurthy@micron.com> <20190722055621.23526-7-sshivamurthy@micron.com> <20190807120408.031b8d1b@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, I need your opinion on the question below. "Shivamurthy Shastri (sshivamurthy)" wrote on Mon, 19 Aug 2019 09:03:38 +0000: > Hi Miquel, > > > > > Hi Shiva, > > > > shiva.linuxworks@gmail.com wrote on Mon, 22 Jul 2019 07:56:19 +0200: > > > > > From: Shivamurthy Shastri > > > > > > > I am not sure the "turn implemenatation generic" title describes what > > you do. > > > > > Driver is redesigned using parameter page to support Micron SPI NAND > > > flashes. > > > > Redesigned is perhaps a bit too much. > > > > " > > > The reason why spinand_select_op_variant globalized is that the Micron > > > driver no longer calling spinand_match_and_init. > > > > > > Signed-off-by: Shivamurthy Shastri > > > --- > > > drivers/mtd/nand/spi/core.c | 2 +- > > > drivers/mtd/nand/spi/micron.c | 61 +++++++++++++++++++++++++------- > > --- > > > include/linux/mtd/spinand.h | 4 +++ > > > 3 files changed, 49 insertions(+), 18 deletions(-) > > > > > > diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c > > > index 7ae76dab9141..aae715d388b7 100644 > > > --- a/drivers/mtd/nand/spi/core.c > > > +++ b/drivers/mtd/nand/spi/core.c > > > @@ -920,7 +920,7 @@ static void spinand_manufacturer_cleanup(struct > > spinand_device *spinand) > > > return spinand->manufacturer->ops->cleanup(spinand); > > > } > > > > > > -static const struct spi_mem_op * > > > +const struct spi_mem_op * > > > spinand_select_op_variant(struct spinand_device *spinand, > > > const struct spinand_op_variants *variants) > > > { > > > diff --git a/drivers/mtd/nand/spi/micron.c > > b/drivers/mtd/nand/spi/micron.c > > > index 95bc5264ebc1..6fde93ec23a1 100644 > > > --- a/drivers/mtd/nand/spi/micron.c > > > +++ b/drivers/mtd/nand/spi/micron.c > > > @@ -90,22 +90,10 @@ static int micron_ecc_get_status(struct > > spinand_device *spinand, > > > return -EINVAL; > > > } > > > > > > -static const struct spinand_info micron_spinand_table[] = { > > > - SPINAND_INFO("MT29F2G01ABAGD", 0x24, > > > - NAND_MEMORG(1, 2048, 128, 64, 2048, 40, 2, 1, 1), > > > - NAND_ECCREQ(8, 512), > > > - SPINAND_INFO_OP_VARIANTS(&read_cache_variants, > > > - &write_cache_variants, > > > - &update_cache_variants), > > > - 0, > > > - SPINAND_ECCINFO(µn_ooblayout_ops, > > > - micron_ecc_get_status)), > > > -}; > > > - > > > > I don't know if it is wise to drop this structure. > > > > > static int micron_spinand_detect(struct spinand_device *spinand) > > > { > > > + const struct spi_mem_op *op; > > > u8 *id = spinand->id.data; > > > - int ret; > > > > > > /* > > > * Micron SPI NAND read ID need a dummy byte, > > > @@ -114,16 +102,55 @@ static int micron_spinand_detect(struct > > spinand_device *spinand) > > > if (id[1] != SPINAND_MFR_MICRON) > > > return 0; > > > > > > - ret = spinand_match_and_init(spinand, micron_spinand_table, > > > - ARRAY_SIZE(micron_spinand_table), > > id[2]); > > > > I am not sure this is the right solution. I would keep this call and > > overwrite what you need to overwrite with the fixup hook. > > > > Then, I will have dummy structure like below. > > static const struct spinand_info micron_spinand_table[] = { > SPINAND_INFO(NULL, 0, > NAND_MEMORG(0, 0, 0, 0, 0, 0, 0, 0, 0), > NAND_ECCREQ(0, 0), > SPINAND_INFO_OP_VARIANTS(&read_cache_variants, > &write_cache_variants, > &update_cache_variants), > 0, > SPINAND_ECCINFO(µn_ooblayout_ops, > micron_ecc_get_status)), > }; > > Let me know if you are thinking for different approach. > Thanks, Miquèl