From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 213D1C3A59D for ; Mon, 19 Aug 2019 09:44:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7D6920989 for ; Mon, 19 Aug 2019 09:44:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7D6920989 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzeDd-0005lk-TY for qemu-devel@archiver.kernel.org; Mon, 19 Aug 2019 05:44:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34938) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzeCz-00059v-DN for qemu-devel@nongnu.org; Mon, 19 Aug 2019 05:44:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzeCy-0007uJ-3p for qemu-devel@nongnu.org; Mon, 19 Aug 2019 05:44:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35936) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hzeCx-0007td-UG; Mon, 19 Aug 2019 05:44:12 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 26CEE30A5A64; Mon, 19 Aug 2019 09:44:10 +0000 (UTC) Received: from gondolin (unknown [10.36.116.255]) by smtp.corp.redhat.com (Postfix) with ESMTP id D8F0D831DF; Mon, 19 Aug 2019 09:44:05 +0000 (UTC) Date: Mon, 19 Aug 2019 11:44:02 +0200 From: Cornelia Huck To: David Hildenbrand Message-ID: <20190819114402.58419749.cohuck@redhat.com> In-Reply-To: <20190816084708.602-2-david@redhat.com> References: <20190816084708.602-1-david@redhat.com> <20190816084708.602-2-david@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Mon, 19 Aug 2019 09:44:10 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v3 1/6] s390x/mmu: Trace the right value if setting/getting the storage key fails X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Janosch Frank , qemu-devel@nongnu.org, Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Alex =?UTF-8?B?QmVubsOpZQ==?= , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 16 Aug 2019 10:47:03 +0200 David Hildenbrand wrote: > We want to trace the actual return value, not "0". > > Fixes: 0f5f669147b5 (s390x: Enable new s390-storage-keys device) Fixes: 0f5f669147b5 ("s390x: Enable new s390-storage-keys device") :) > Reviewed-by: Cornelia Huck > Reviewed-by: Thomas Huth > Signed-off-by: David Hildenbrand > --- > target/s390x/mmu_helper.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-)