From: Shawn Guo <shawnguo@kernel.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH] bus: imx-weim: module_platform_driver()
Date: Mon, 19 Aug 2019 14:08:30 +0200 [thread overview]
Message-ID: <20190819120829.GD5999@X250> (raw)
In-Reply-To: <20190814082316.30300-1-s.hauer@pengutronix.de>
On Wed, Aug 14, 2019 at 10:23:16AM +0200, Sascha Hauer wrote:
> Switch from module_platform_driver_probe() to module_platform_driver().
> The former is not suitable for booting with device tree as the driver
> will be registered before the device and thus won't be probed again
> when the device is present.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Applied with subject updated like below.
bus: imx-weim: use module_platform_driver()
Shawn
> ---
> drivers/bus/imx-weim.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index db74334ca5ef..8a9f8a4328c2 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -183,8 +183,7 @@ static int __init weim_timing_setup(struct device *dev,
> return 0;
> }
>
> -static int __init weim_parse_dt(struct platform_device *pdev,
> - void __iomem *base)
> +static int weim_parse_dt(struct platform_device *pdev, void __iomem *base)
> {
> const struct of_device_id *of_id = of_match_device(weim_id_table,
> &pdev->dev);
> @@ -217,7 +216,7 @@ static int __init weim_parse_dt(struct platform_device *pdev,
> return ret;
> }
>
> -static int __init weim_probe(struct platform_device *pdev)
> +static int weim_probe(struct platform_device *pdev)
> {
> struct resource *res;
> struct clk *clk;
> @@ -254,8 +253,9 @@ static struct platform_driver weim_driver = {
> .name = "imx-weim",
> .of_match_table = weim_id_table,
> },
> + .probe = weim_probe,
> };
> -module_platform_driver_probe(weim_driver, weim_probe);
> +module_platform_driver(weim_driver);
>
> MODULE_AUTHOR("Freescale Semiconductor Inc.");
> MODULE_DESCRIPTION("i.MX EIM Controller Driver");
> --
> 2.20.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-08-19 12:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 8:23 [PATCH] bus: imx-weim: module_platform_driver() Sascha Hauer
2019-08-19 12:08 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190819120829.GD5999@X250 \
--to=shawnguo@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.