From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: linuxppc-dev@lists.ozlabs.org, Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] powerpc/64: optimise LOAD_REG_IMMEDIATE_SYM()
Date: Mon, 19 Aug 2019 09:24:59 -0500 [thread overview]
Message-ID: <20190819142459.GJ31406@gate.crashing.org> (raw)
In-Reply-To: <92bf50b31f5f78cc76ed055b11a492e8e9e2c731.1566223054.git.christophe.leroy@c-s.fr>
On Mon, Aug 19, 2019 at 01:58:12PM +0000, Christophe Leroy wrote:
> -#define LOAD_REG_IMMEDIATE_SYM(reg,expr) \
> - lis reg,(expr)@highest; \
> - ori reg,reg,(expr)@higher; \
> - rldicr reg,reg,32,31; \
> - oris reg,reg,(expr)@__AS_ATHIGH; \
> - ori reg,reg,(expr)@l;
> +#define LOAD_REG_IMMEDIATE_SYM(reg, tmp, expr) \
> + lis reg, (expr)@highest; \
> + lis tmp, (expr)@__AS_ATHIGH; \
> + ori reg, reg, (expr)@higher; \
> + ori tmp, reg, (expr)@l; \
> + rldimi reg, tmp, 32, 0
That should be
#define LOAD_REG_IMMEDIATE_SYM(reg, tmp, expr) \
lis tmp, (expr)@highest; \
ori tmp, tmp, (expr)@higher; \
lis reg, (expr)@__AS_ATHIGH; \
ori reg, reg, (expr)@l; \
rldimi reg, tmp, 32, 0
(tmp is the high half, reg is the low half, as inputs to that rldimi).
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 3/3] powerpc/64: optimise LOAD_REG_IMMEDIATE_SYM()
Date: Mon, 19 Aug 2019 09:24:59 -0500 [thread overview]
Message-ID: <20190819142459.GJ31406@gate.crashing.org> (raw)
In-Reply-To: <92bf50b31f5f78cc76ed055b11a492e8e9e2c731.1566223054.git.christophe.leroy@c-s.fr>
On Mon, Aug 19, 2019 at 01:58:12PM +0000, Christophe Leroy wrote:
> -#define LOAD_REG_IMMEDIATE_SYM(reg,expr) \
> - lis reg,(expr)@highest; \
> - ori reg,reg,(expr)@higher; \
> - rldicr reg,reg,32,31; \
> - oris reg,reg,(expr)@__AS_ATHIGH; \
> - ori reg,reg,(expr)@l;
> +#define LOAD_REG_IMMEDIATE_SYM(reg, tmp, expr) \
> + lis reg, (expr)@highest; \
> + lis tmp, (expr)@__AS_ATHIGH; \
> + ori reg, reg, (expr)@higher; \
> + ori tmp, reg, (expr)@l; \
> + rldimi reg, tmp, 32, 0
That should be
#define LOAD_REG_IMMEDIATE_SYM(reg, tmp, expr) \
lis tmp, (expr)@highest; \
ori tmp, tmp, (expr)@higher; \
lis reg, (expr)@__AS_ATHIGH; \
ori reg, reg, (expr)@l; \
rldimi reg, tmp, 32, 0
(tmp is the high half, reg is the low half, as inputs to that rldimi).
Segher
next prev parent reply other threads:[~2019-08-19 14:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 13:58 [PATCH v3 1/3] powerpc: rewrite LOAD_REG_IMMEDIATE() as an intelligent macro Christophe Leroy
2019-08-19 13:58 ` Christophe Leroy
2019-08-19 13:58 ` [PATCH v3 2/3] powerpc/32: replace LOAD_MSR_KERNEL() by LOAD_REG_IMMEDIATE() Christophe Leroy
2019-08-19 13:58 ` Christophe Leroy
2019-08-19 13:58 ` [PATCH v3 3/3] powerpc/64: optimise LOAD_REG_IMMEDIATE_SYM() Christophe Leroy
2019-08-19 13:58 ` Christophe Leroy
2019-08-19 14:24 ` Segher Boessenkool [this message]
2019-08-19 14:24 ` Segher Boessenkool
2019-08-19 15:05 ` Nicholas Piggin
2019-08-19 15:05 ` Nicholas Piggin
2019-08-19 14:16 ` [PATCH v3 1/3] powerpc: rewrite LOAD_REG_IMMEDIATE() as an intelligent macro Segher Boessenkool
2019-08-19 14:16 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190819142459.GJ31406@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.