From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/vblank: Document and fix vblank count barrier semantics Date: Mon, 19 Aug 2019 19:21:38 +0300 Message-ID: <20190819162138.GY5942@intel.com> References: <20190719170654.GQ5942@intel.com> <20190723131337.22031-1-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190723131337.22031-1-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Keith Packard , Rodrigo Siqueira , Intel Graphics Development , DRI Development , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKdWwgMjMsIDIwMTkgYXQgMDM6MTM6MzdQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBOb3RpY2VkIHdoaWxlIHJldmlld2luZyBjb2RlLiBJJ20gbm90IHN1cmUgd2hldGhl ciB0aGlzIG1pZ2h0IG9yIG1pZ2h0Cj4gbm90IGV4cGxhaW4gc29tZSBvZiB0aGUgbWlzc2VkIHZi bGFuayBoaWxhcml0eSB3ZSd2ZSBiZWVuIHNlZWluZy4gSQo+IHRoaW5rIHRob3NlIGFsbCBnbyB0 aHJvdWdoIHRoZSB2YmxhbmsgY29tcGxldGlvbiBldmVudCwgd2hpY2ggaGFzCj4gdW5jb25kaXRp b25hbCBiYXJyaWVycyAtIGl0IGFsd2F5cyB0YWtlcyB0aGUgc3BpbmxvY2suIFRoZXJlZm9yZSBu bwo+IGNjIHN0YWJsZS4KPiAKPiB2MjoKPiAtIEJhcnJyaWVycyBhcmUgaGFyZCwgcHV0IHRoZW0g aW4gaW4gdGhlIHJpZ2h0IG9yZGVyIChDaHJpcykuCj4gLSBJbXByb3ZlIHRoZSBjb21tZW50cyBh IGJpdC4KPiAKPiB2MzoKPiAKPiBWaWxsZSBub3RpY2VkIHRoYXQgb24gMzJiaXQgd2UgbWlnaHQg YmUgYnJlYWtpbmcgdXAgdGhlIGxvYWQvc3RvcmVzLAo+IG5vdyB0aGF0IHRoZSB2YmxhbmsgY291 bnRlciBoYXMgYmVlbiBzd2l0Y2hlZCBvdmVyIHRvIGJlIDY0IGJpdC4gRml4Cj4gdGhhdCB1cCBi eSBzd2l0Y2hpbmcgdG8gYXRvbWljNjRfdC4gVGhpcyB0aGlzIGhhcHBlbnMgc28gcmFyZWx5IGlu Cj4gcHJhY3RpY2UgSSBmaWd1cmVkIG5vIG5lZWQgdG8gY2M6IHN0YWJsZSAuLi4KPiAKPiBDYzog VmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBDYzogS2Vp dGggUGFja2FyZCA8a2VpdGhwQGtlaXRocC5jb20+Cj4gUmVmZXJlbmNlczogNTcwZTg2OTYzYTUx ICgiZHJtOiBXaWRlbiB2YmxhbmsgY291bnQgdG8gNjQtYml0cyBbdjNdIikKPiBDYzogUm9kcmln byBTaXF1ZWlyYSA8cm9kcmlnb3NpcXVlaXJhbWVsb0BnbWFpbC5jb20+Cj4gQ2M6IENocmlzIFdp bHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBW ZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrD pGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vZHJtX3ZibGFuay5jIHwgNDUgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKyst LS0tCj4gIGluY2x1ZGUvZHJtL2RybV92YmxhbmsuaCAgICAgfCAxNSArKysrKysrKysrLS0KPiAg MiBmaWxlcyBjaGFuZ2VkLCA1NCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3ZibGFuay5jIGIvZHJpdmVycy9ncHUvZHJt L2RybV92YmxhbmsuYwo+IGluZGV4IDYwM2FiMTA1MTI1ZC4uMDNlMzdiY2VhYzljIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fdmJsYW5rLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vZHJtX3ZibGFuay5jCj4gQEAgLTEwNyw3ICsxMDcsNyBAQCBzdGF0aWMgdm9pZCBzdG9yZV92 Ymxhbmsoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdW5zaWduZWQgaW50IHBpcGUsCj4gIAo+ICAJ d3JpdGVfc2VxbG9jaygmdmJsYW5rLT5zZXFsb2NrKTsKPiAgCXZibGFuay0+dGltZSA9IHRfdmJs YW5rOwo+IC0JdmJsYW5rLT5jb3VudCArPSB2YmxhbmtfY291bnRfaW5jOwo+ICsJYXRvbWljNjRf YWRkKHZibGFua19jb3VudF9pbmMsICZ2YmxhbmstPmNvdW50KTsKPiAgCXdyaXRlX3NlcXVubG9j aygmdmJsYW5rLT5zZXFsb2NrKTsKPiAgfQo+ICAKPiBAQCAtMjczLDcgKzI3Myw4IEBAIHN0YXRp YyB2b2lkIGRybV91cGRhdGVfdmJsYW5rX2NvdW50KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVu c2lnbmVkIGludCBwaXBlLAo+ICAKPiAgCURSTV9ERUJVR19WQkwoInVwZGF0aW5nIHZibGFuayBj b3VudCBvbiBjcnRjICV1OiIKPiAgCQkgICAgICAiIGN1cnJlbnQ9JWxsdSwgZGlmZj0ldSwgaHc9 JXUgaHdfbGFzdD0ldVxuIiwKPiAtCQkgICAgICBwaXBlLCB2YmxhbmstPmNvdW50LCBkaWZmLCBj dXJfdmJsYW5rLCB2YmxhbmstPmxhc3QpOwo+ICsJCSAgICAgIHBpcGUsIGF0b21pYzY0X3JlYWQo JnZibGFuay0+Y291bnQpLCBkaWZmLAo+ICsJCSAgICAgIGN1cl92YmxhbmssIHZibGFuay0+bGFz dCk7Cj4gIAo+ICAJaWYgKGRpZmYgPT0gMCkgewo+ICAJCVdBUk5fT05fT05DRShjdXJfdmJsYW5r ICE9IHZibGFuay0+bGFzdCk7Cj4gQEAgLTI5NSwxMSArMjk2LDIzIEBAIHN0YXRpYyB2b2lkIGRy bV91cGRhdGVfdmJsYW5rX2NvdW50KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIGlu dCBwaXBlLAo+ICBzdGF0aWMgdTY0IGRybV92YmxhbmtfY291bnQoc3RydWN0IGRybV9kZXZpY2Ug KmRldiwgdW5zaWduZWQgaW50IHBpcGUpCj4gIHsKPiAgCXN0cnVjdCBkcm1fdmJsYW5rX2NydGMg KnZibGFuayA9ICZkZXYtPnZibGFua1twaXBlXTsKPiArCXU2NCBjb3VudDsKPiAgCj4gIAlpZiAo V0FSTl9PTihwaXBlID49IGRldi0+bnVtX2NydGNzKSkKPiAgCQlyZXR1cm4gMDsKPiAgCj4gLQly ZXR1cm4gdmJsYW5rLT5jb3VudDsKPiArCWNvdW50ID0gYXRvbWljNjRfcmVhZCgmdmJsYW5rLT5j b3VudCk7Cj4gKwo+ICsJLyoKPiArCSAqIFRoaXMgcmVhZCBiYXJyaWVyIGNvcnJlc3BvbmRzIHRv IHRoZSBpbXBsaWNpdCB3cml0ZSBiYXJyaWVyIG9mIHRoZQo+ICsJICogd3JpdGUgc2VxbG9jayBp biBzdG9yZV92YmxhbmsoKS4gTm90ZSB0aGF0IHRoaXMgaXMgdGhlIG9ubHkgcGxhY2UKPiArCSAq IHdoZXJlIHdlIG5lZWQgYW4gZXhwbGljaXQgYmFycmllciwgc2luY2UgYWxsIG90aGVyIGFjY2Vz cyBnb2VzCj4gKwkgKiB0aHJvdWdoIGRybV92YmxhbmtfY291bnRfYW5kX3RpbWUoKSwgd2hpY2gg YWxyZWFkeSBoYXMgdGhlIHJlcXVpcmVkCj4gKwkgKiByZWFkIGJhcnJpZXIgY3VydGVzeSBvZiB0 aGUgcmVhZCBzZXFsb2NrLgo+ICsJICovCj4gKwlzbXBfcm1iKCk7Cj4gKwo+ICsJcmV0dXJuIGNv dW50Owo+ICB9Cj4gIAo+ICAvKioKPiBAQCAtNzY0LDYgKzc3NywxNCBAQCBkcm1fZ2V0X2xhc3Rf dmJsdGltZXN0YW1wKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCBwaXBlLAo+ ICAgKiB2YmxhbmsgaW50ZXJydXB0IChzaW5jZSBpdCBvbmx5IHJlcG9ydHMgdGhlIHNvZnR3YXJl IHZibGFuayBjb3VudGVyKSwgc2VlCj4gICAqIGRybV9jcnRjX2FjY3VyYXRlX3ZibGFua19jb3Vu dCgpIGZvciBzdWNoIHVzZS1jYXNlcy4KPiAgICoKPiArICogTm90ZSB0aGF0IGZvciBhIGdpdmVu IHZibGFuayBjb3VudGVyIHZhbHVlIGRybV9jcnRjX2hhbmRsZV92YmxhbmsoKQo+ICsgKiBhbmQg ZHJtX2NydGNfdmJsYW5rX2NvdW50KCkgb3IgZHJtX2NydGNfdmJsYW5rX2NvdW50X2FuZF90aW1l KCkKPiArICogcHJvdmlkZSBhIGJhcnJpZXI6IEFueSB3cml0ZXMgZG9uZSBiZWZvcmUgY2FsbGlu Zwo+ICsgKiBkcm1fY3J0Y19oYW5kbGVfdmJsYW5rKCkgd2lsbCBiZSB2aXNpYmxlIHRvIGNhbGxl cnMgb2YgdGhlIGxhdGVyCj4gKyAqIGZ1bmN0aW9ucywgaWZmIHRoZSB2YmxhbmsgY291bnQgaXMg dGhlIHNhbWUgb3IgYSBsYXRlciBvbmUuCj4gKyAqCj4gKyAqIFNlZSBhbHNvICZkcm1fdmJsYW5r X2NydGMuY291bnQuCj4gKyAqCj4gICAqIFJldHVybnM6Cj4gICAqIFRoZSBzb2Z0d2FyZSB2Ymxh bmsgY291bnRlci4KPiAgICovCj4gQEAgLTgwMSw3ICs4MjIsNyBAQCBzdGF0aWMgdTY0IGRybV92 YmxhbmtfY291bnRfYW5kX3RpbWUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdW5zaWduZWQgaW50 IHBpcGUsCj4gIAo+ICAJZG8gewo+ICAJCXNlcSA9IHJlYWRfc2VxYmVnaW4oJnZibGFuay0+c2Vx bG9jayk7Cj4gLQkJdmJsYW5rX2NvdW50ID0gdmJsYW5rLT5jb3VudDsKPiArCQl2YmxhbmtfY291 bnQgPSBhdG9taWM2NF9yZWFkKCZ2YmxhbmstPmNvdW50KTsKPiAgCQkqdmJsYW5rdGltZSA9IHZi bGFuay0+dGltZTsKPiAgCX0gd2hpbGUgKHJlYWRfc2VxcmV0cnkoJnZibGFuay0+c2VxbG9jaywg c2VxKSk7Cj4gIAo+IEBAIC04MTgsNiArODM5LDE0IEBAIHN0YXRpYyB1NjQgZHJtX3ZibGFua19j b3VudF9hbmRfdGltZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgcGlwZSwK PiAgICogdmJsYW5rIGV2ZW50cyBzaW5jZSB0aGUgc3lzdGVtIHdhcyBib290ZWQsIGluY2x1ZGlu ZyBsb3N0IGV2ZW50cyBkdWUgdG8KPiAgICogbW9kZXNldHRpbmcgYWN0aXZpdHkuIFJldHVybnMg Y29ycmVzcG9uZGluZyBzeXN0ZW0gdGltZXN0YW1wIG9mIHRoZSB0aW1lCj4gICAqIG9mIHRoZSB2 YmxhbmsgaW50ZXJ2YWwgdGhhdCBjb3JyZXNwb25kcyB0byB0aGUgY3VycmVudCB2YmxhbmsgY291 bnRlciB2YWx1ZS4KPiArICoKPiArICogTm90ZSB0aGF0IGZvciBhIGdpdmVuIHZibGFuayBjb3Vu dGVyIHZhbHVlIGRybV9jcnRjX2hhbmRsZV92YmxhbmsoKQo+ICsgKiBhbmQgZHJtX2NydGNfdmJs YW5rX2NvdW50KCkgb3IgZHJtX2NydGNfdmJsYW5rX2NvdW50X2FuZF90aW1lKCkKPiArICogcHJv dmlkZSBhIGJhcnJpZXI6IEFueSB3cml0ZXMgZG9uZSBiZWZvcmUgY2FsbGluZwo+ICsgKiBkcm1f Y3J0Y19oYW5kbGVfdmJsYW5rKCkgd2lsbCBiZSB2aXNpYmxlIHRvIGNhbGxlcnMgb2YgdGhlIGxh dGVyCj4gKyAqIGZ1bmN0aW9ucywgaWZmIHRoZSB2YmxhbmsgY291bnQgaXMgdGhlIHNhbWUgb3Ig YSBsYXRlciBvbmUuCj4gKyAqCj4gKyAqIFNlZSBhbHNvICZkcm1fdmJsYW5rX2NydGMuY291bnQu Cj4gICAqLwo+ICB1NjQgZHJtX2NydGNfdmJsYW5rX2NvdW50X2FuZF90aW1lKHN0cnVjdCBkcm1f Y3J0YyAqY3J0YywKPiAgCQkJCSAgIGt0aW1lX3QgKnZibGFua3RpbWUpCj4gQEAgLTE3OTEsNiAr MTgyMCwxNCBAQCBFWFBPUlRfU1lNQk9MKGRybV9oYW5kbGVfdmJsYW5rKTsKPiAgICoKPiAgICog VGhpcyBpcyB0aGUgbmF0aXZlIEtNUyB2ZXJzaW9uIG9mIGRybV9oYW5kbGVfdmJsYW5rKCkuCj4g ICAqCj4gKyAqIE5vdGUgdGhhdCBmb3IgYSBnaXZlbiB2YmxhbmsgY291bnRlciB2YWx1ZSBkcm1f Y3J0Y19oYW5kbGVfdmJsYW5rKCkKPiArICogYW5kIGRybV9jcnRjX3ZibGFua19jb3VudCgpIG9y IGRybV9jcnRjX3ZibGFua19jb3VudF9hbmRfdGltZSgpCj4gKyAqIHByb3ZpZGUgYSBiYXJyaWVy OiBBbnkgd3JpdGVzIGRvbmUgYmVmb3JlIGNhbGxpbmcKPiArICogZHJtX2NydGNfaGFuZGxlX3Zi bGFuaygpIHdpbGwgYmUgdmlzaWJsZSB0byBjYWxsZXJzIG9mIHRoZSBsYXRlcgo+ICsgKiBmdW5j dGlvbnMsIGlmZiB0aGUgdmJsYW5rIGNvdW50IGlzIHRoZSBzYW1lIG9yIGEgbGF0ZXIgb25lLgo+ ICsgKgo+ICsgKiBTZWUgYWxzbyAmZHJtX3ZibGFua19jcnRjLmNvdW50Lgo+ICsgKgo+ICAgKiBS ZXR1cm5zOgo+ICAgKiBUcnVlIGlmIHRoZSBldmVudCB3YXMgc3VjY2Vzc2Z1bGx5IGhhbmRsZWQs IGZhbHNlIG9uIGZhaWx1cmUuCj4gICAqLwo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1f dmJsYW5rLmggYi9pbmNsdWRlL2RybS9kcm1fdmJsYW5rLmgKPiBpbmRleCA5ZmU0YmE4YmM2MjIu LmMxNmM0NDA1MmIzZCAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2RybS9kcm1fdmJsYW5rLmgKPiAr KysgYi9pbmNsdWRlL2RybS9kcm1fdmJsYW5rLmgKPiBAQCAtMTA5LDkgKzEwOSwyMCBAQCBzdHJ1 Y3QgZHJtX3ZibGFua19jcnRjIHsKPiAgCXNlcWxvY2tfdCBzZXFsb2NrOwo+ICAKPiAgCS8qKgo+ IC0JICogQGNvdW50OiBDdXJyZW50IHNvZnR3YXJlIHZibGFuayBjb3VudGVyLgo+ICsJICogQGNv dW50Ogo+ICsJICoKPiArCSAqIEN1cnJlbnQgc29mdHdhcmUgdmJsYW5rIGNvdW50ZXIuCj4gKwkg Kgo+ICsJICogTm90ZSB0aGF0IGZvciBhIGdpdmVuIHZibGFuayBjb3VudGVyIHZhbHVlIGRybV9j cnRjX2hhbmRsZV92YmxhbmsoKQo+ICsJICogYW5kIGRybV9jcnRjX3ZibGFua19jb3VudCgpIG9y IGRybV9jcnRjX3ZibGFua19jb3VudF9hbmRfdGltZSgpCj4gKwkgKiBwcm92aWRlIGEgYmFycmll cjogQW55IHdyaXRlcyBkb25lIGJlZm9yZSBjYWxsaW5nCj4gKwkgKiBkcm1fY3J0Y19oYW5kbGVf dmJsYW5rKCkgd2lsbCBiZSB2aXNpYmxlIHRvIGNhbGxlcnMgb2YgdGhlIGxhdGVyCj4gKwkgKiBm dW5jdGlvbnMsIGlmZiB0aGUgdmJsYW5rIGNvdW50IGlzIHRoZSBzYW1lIG9yIGEgbGF0ZXIgb25l Lgo+ICsJICoKPiArCSAqIElNUE9SVEFOVDogVGhpcyBndWFyYW50ZWUgcmVxdWlyZXMgYmFycmll cnMsIHRoZXJlZm9yIG5ldmVyIGFjY2Vzcwo+ICsJICogdGhpcyBmaWVsZCBkaXJlY3RseS4gVXNl IGRybV9jcnRjX3ZibGFua19jb3VudCgpIGluc3RlYWQuCj4gIAkgKi8KPiAtCXU2NCBjb3VudDsK PiArCWF0b21pYzY0X3QgY291bnQ7Cj4gIAkvKioKPiAgCSAqIEB0aW1lOiBWYmxhbmsgdGltZXN0 YW1wIGNvcnJlc3BvbmRpbmcgdG8gQGNvdW50Lgo+ICAJICovCj4gLS0gCj4gMi4yMi4wCgotLSAK VmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbA==