From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH] HID: wacom: correct misreported EKR ring values Date: Mon, 19 Aug 2019 15:03:49 -0400 Message-ID: <20190819190349.GE30205@sasha-vm> References: <1566232914-9919-1-git-send-email-aaron.skomra@wacom.com> <20190819170246.GA30205@sasha-vm> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Return-path: Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org To: Aaron Armstrong Skomra Cc: "open list:HID CORE LAYER" , Jiri Kosina , benjamin.tissoires@redhat.com, "Cheng, Ping" , Jason Gerecke , Aaron Armstrong Skomra , "# v4 . 3+" List-Id: linux-input@vger.kernel.org On Mon, Aug 19, 2019 at 10:13:31AM -0700, Aaron Armstrong Skomra wrote: >On Mon, Aug 19, 2019 at 10:02 AM Sasha Levin wrote: > >> On Mon, Aug 19, 2019 at 09:41:54AM -0700, Aaron Armstrong Skomra wrote: >> >The EKR ring claims a range of 0 to 71 but actually reports >> >values 1 to 72. The ring is used in relative mode so this >> >change should not affect users. >> > >> >Signed-off-by: Aaron Armstrong Skomra >> >Fixes: 72b236d60218f ("HID: wacom: Add support for Express Key Remote.") >> >Cc: # v4.3+ >> >Reviewed-by: Ping Cheng >> >Reviewed-by: Jason Gerecke >> >--- >> >Patch specifically targeted to v4.9.189 >> >> Is this not a problem upstream as well? Why not? >> >> If it is, this patch will need to go upstream first, and then it'll get >> to stable branches from there. >> >> Hi Sasha, >I neglected my "--in-reply-to" in git send-email, I will resend. My >apologies. Ah, I see what happened. Looks good now, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27F97C3A5A0 for ; Mon, 19 Aug 2019 19:03:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9D8D22CE8 for ; Mon, 19 Aug 2019 19:03:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566241433; bh=jSr9TTwNt7h927ghAvkmu9t9Gk5BAIbgJN+uo5miIQo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=LtOIEiB0WFjVzo/Ed89pcXpawi2c06wgNX7xDuXyGSjXeSrRm/SHNvcJT7fE2ZzM4 m5EsvHzaVnPEsC+T2U4Xq8PCebvJlE4URl3kIKUhvH+EEeBcxln7l1CZjFl4mgl6nX 8V6TiGQ/2DBD0amOYUcy86bgT2w5JpV5PByKlSq0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728021AbfHSTDv (ORCPT ); Mon, 19 Aug 2019 15:03:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:33802 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727769AbfHSTDu (ORCPT ); Mon, 19 Aug 2019 15:03:50 -0400 Received: from localhost (wsip-184-188-36-2.sd.sd.cox.net [184.188.36.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B5B32214DA; Mon, 19 Aug 2019 19:03:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566241429; bh=jSr9TTwNt7h927ghAvkmu9t9Gk5BAIbgJN+uo5miIQo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZS13jkzwjmuASZFE38Zk5gFS5nQLRWFhqFad4UH1FUf27QeAiZ9qxDMtcJtymJa2U EYHx4MySb3Mg0dh9nUvw2pcnC8BgFAvmfFIPUNIM/lhUn8kwrQYu11NsgPXHZJ1vEq ga95TRTNAPBAr3vDajZWRoYxJVS3AaIhN6OhLza4= Date: Mon, 19 Aug 2019 15:03:49 -0400 From: Sasha Levin To: Aaron Armstrong Skomra Cc: "open list:HID CORE LAYER" , Jiri Kosina , benjamin.tissoires@redhat.com, "Cheng, Ping" , Jason Gerecke , Aaron Armstrong Skomra , "# v4 . 3+" Subject: Re: [PATCH] HID: wacom: correct misreported EKR ring values Message-ID: <20190819190349.GE30205@sasha-vm> References: <1566232914-9919-1-git-send-email-aaron.skomra@wacom.com> <20190819170246.GA30205@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Aug 19, 2019 at 10:13:31AM -0700, Aaron Armstrong Skomra wrote: >On Mon, Aug 19, 2019 at 10:02 AM Sasha Levin wrote: > >> On Mon, Aug 19, 2019 at 09:41:54AM -0700, Aaron Armstrong Skomra wrote: >> >The EKR ring claims a range of 0 to 71 but actually reports >> >values 1 to 72. The ring is used in relative mode so this >> >change should not affect users. >> > >> >Signed-off-by: Aaron Armstrong Skomra >> >Fixes: 72b236d60218f ("HID: wacom: Add support for Express Key Remote.") >> >Cc: # v4.3+ >> >Reviewed-by: Ping Cheng >> >Reviewed-by: Jason Gerecke >> >--- >> >Patch specifically targeted to v4.9.189 >> >> Is this not a problem upstream as well? Why not? >> >> If it is, this patch will need to go upstream first, and then it'll get >> to stable branches from there. >> >> Hi Sasha, >I neglected my "--in-reply-to" in git send-email, I will resend. My >apologies. Ah, I see what happened. Looks good now, thanks! -- Thanks, Sasha