All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ayan Halder <Ayan.Halder@arm.com>
To: "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
Cc: Mihail Atanassov <Mihail.Atanassov@arm.com>,
	David Airlie <airlied@linux.ie>,
	Liviu Dudau <Liviu.Dudau@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>, nd <nd@arm.com>
Subject: Re: [PATCH v2.1] drm/komeda: Add support for 'memory-region' DT node property
Date: Tue, 20 Aug 2019 10:31:21 +0000	[thread overview]
Message-ID: <20190820103121.GA676@arm.com> (raw)
In-Reply-To: <20190805101329.GA26357@jamwan02-TSP300>

On Mon, Aug 05, 2019 at 10:13:35AM +0000, james qian wang (Arm Technology China) wrote:
> On Mon, Aug 05, 2019 at 05:56:25PM +0800, Mihail Atanassov wrote:
> > The 'memory-region' property of the komeda display driver DT binding
> > allows the use of a 'reserved-memory' node for buffer allocations. Add
> > the requisite of_reserved_mem_device_{init,release} calls to actually
> > make use of the memory if present.
> > 
> > Changes since v1:
> >  - Move handling inside komeda_parse_dt
> > 
> > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> > ---
> >  drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > index 1ff7f4b2c620..0142ee991957 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > @@ -8,6 +8,7 @@
> >  #include <linux/iommu.h>
> >  #include <linux/of_device.h>
> >  #include <linux/of_graph.h>
> > +#include <linux/of_reserved_mem.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/dma-mapping.h>
> >  #ifdef CONFIG_DEBUG_FS
> > @@ -146,6 +147,12 @@ static int komeda_parse_dt(struct device *dev, struct komeda_dev *mdev)
> >  		return mdev->irq;
> >  	}
> >  
> > +	/* Get the optional framebuffer memory resource */
> > +	ret = of_reserved_mem_device_init(dev);
> > +	if (ret && ret != -ENODEV)
> > +		return ret;
> > +	ret = 0;
> > +
> >  	for_each_available_child_of_node(np, child) {
> >  		if (of_node_cmp(child->name, "pipeline") == 0) {
> >  			ret = komeda_parse_pipe_dt(mdev, child);
> > @@ -292,6 +299,8 @@ void komeda_dev_destroy(struct komeda_dev *mdev)
> >  
> >  	mdev->n_pipelines = 0;
> >  
> > +	of_reserved_mem_device_release(dev);
> > +
> >  	if (funcs && funcs->cleanup)
> >  		funcs->cleanup(mdev);
> >  
> > -- 
> > 2.22.0
> 
> 
> Thank you.
> 
> Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>

Pushed to drm-misc-next - a8c16b7593bd1a4e613164a47c526ca9d1be764b
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Ayan Halder <Ayan.Halder@arm.com>
To: "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
Cc: Mihail Atanassov <Mihail.Atanassov@arm.com>,
	David Airlie <airlied@linux.ie>,
	Liviu Dudau <Liviu.Dudau@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>, nd <nd@arm.com>
Subject: Re: [PATCH v2.1] drm/komeda: Add support for 'memory-region' DT node property
Date: Tue, 20 Aug 2019 10:31:21 +0000	[thread overview]
Message-ID: <20190820103121.GA676@arm.com> (raw)
In-Reply-To: <20190805101329.GA26357@jamwan02-TSP300>

On Mon, Aug 05, 2019 at 10:13:35AM +0000, james qian wang (Arm Technology China) wrote:
> On Mon, Aug 05, 2019 at 05:56:25PM +0800, Mihail Atanassov wrote:
> > The 'memory-region' property of the komeda display driver DT binding
> > allows the use of a 'reserved-memory' node for buffer allocations. Add
> > the requisite of_reserved_mem_device_{init,release} calls to actually
> > make use of the memory if present.
> > 
> > Changes since v1:
> >  - Move handling inside komeda_parse_dt
> > 
> > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> > ---
> >  drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > index 1ff7f4b2c620..0142ee991957 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > @@ -8,6 +8,7 @@
> >  #include <linux/iommu.h>
> >  #include <linux/of_device.h>
> >  #include <linux/of_graph.h>
> > +#include <linux/of_reserved_mem.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/dma-mapping.h>
> >  #ifdef CONFIG_DEBUG_FS
> > @@ -146,6 +147,12 @@ static int komeda_parse_dt(struct device *dev, struct komeda_dev *mdev)
> >  		return mdev->irq;
> >  	}
> >  
> > +	/* Get the optional framebuffer memory resource */
> > +	ret = of_reserved_mem_device_init(dev);
> > +	if (ret && ret != -ENODEV)
> > +		return ret;
> > +	ret = 0;
> > +
> >  	for_each_available_child_of_node(np, child) {
> >  		if (of_node_cmp(child->name, "pipeline") == 0) {
> >  			ret = komeda_parse_pipe_dt(mdev, child);
> > @@ -292,6 +299,8 @@ void komeda_dev_destroy(struct komeda_dev *mdev)
> >  
> >  	mdev->n_pipelines = 0;
> >  
> > +	of_reserved_mem_device_release(dev);
> > +
> >  	if (funcs && funcs->cleanup)
> >  		funcs->cleanup(mdev);
> >  
> > -- 
> > 2.22.0
> 
> 
> Thank you.
> 
> Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>

Pushed to drm-misc-next - a8c16b7593bd1a4e613164a47c526ca9d1be764b
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-08-20 10:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-02 14:40 [PATCH] drm/komeda: Add support for 'memory-region' DT node property Mihail Atanassov
2019-08-05  8:40 ` james qian wang (Arm Technology China)
2019-08-05  8:40   ` james qian wang (Arm Technology China)
2019-08-05  9:52 ` [PATCH v2] " Mihail Atanassov
2019-08-05  9:56 ` [PATCH v2.1] " Mihail Atanassov
2019-08-05 10:13   ` james qian wang (Arm Technology China)
2019-08-05 10:13     ` james qian wang (Arm Technology China)
2019-08-20 10:31     ` Ayan Halder [this message]
2019-08-20 10:31       ` Ayan Halder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190820103121.GA676@arm.com \
    --to=ayan.halder@arm.com \
    --cc=Liviu.Dudau@arm.com \
    --cc=Mihail.Atanassov@arm.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=james.qian.wang@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.