All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Chester Lin <clin@suse.com>
Cc: "ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"rppt@linux.ibm.com" <rppt@linux.ibm.com>,
	"ren_guo@c-sky.com" <ren_guo@c-sky.com>,
	Juergen Gross <JGross@suse.com>,
	"geert@linux-m68k.org" <geert@linux-m68k.org>,
	"mingo@kernel.org" <mingo@kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
	"guillaume.gardet@arm.com" <guillaume.gardet@arm.com>,
	Joey Lee <JLee@suse.com>, Gary Lin <GLin@suse.com>
Subject: Re: [PATCH] efi/arm: fix allocation failure when reserving the kernel base
Date: Tue, 20 Aug 2019 12:56:46 +0100	[thread overview]
Message-ID: <20190820115645.GP13294@shell.armlinux.org.uk> (raw)
In-Reply-To: <20190802053744.5519-1-clin@suse.com>

On Fri, Aug 02, 2019 at 05:38:54AM +0000, Chester Lin wrote:
> diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c
> index f3ce34113f89..909b11ba48d8 100644
> --- a/arch/arm/mm/mmu.c
> +++ b/arch/arm/mm/mmu.c
> @@ -1184,6 +1184,9 @@ void __init adjust_lowmem_bounds(void)
>  		phys_addr_t block_start = reg->base;
>  		phys_addr_t block_end = reg->base + reg->size;
>  
> +		if (memblock_is_nomap(reg))
> +			continue;
> +
>  		if (reg->base < vmalloc_limit) {
>  			if (block_end > lowmem_limit)
>  				/*

I think this hunk is sane - if the memory is marked nomap, then it isn't
available for the kernel's use, so as far as calculating where the
lowmem/highmem boundary is, it effectively doesn't exist and should be
skipped.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Chester Lin <clin@suse.com>
Cc: Juergen Gross <JGross@suse.com>,
	"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
	"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
	"guillaume.gardet@arm.com" <guillaume.gardet@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"rppt@linux.ibm.com" <rppt@linux.ibm.com>,
	Joey Lee <JLee@suse.com>,
	"geert@linux-m68k.org" <geert@linux-m68k.org>,
	"ren_guo@c-sky.com" <ren_guo@c-sky.com>, Gary Lin <GLin@suse.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"mingo@kernel.org" <mingo@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] efi/arm: fix allocation failure when reserving the kernel base
Date: Tue, 20 Aug 2019 12:56:46 +0100	[thread overview]
Message-ID: <20190820115645.GP13294@shell.armlinux.org.uk> (raw)
In-Reply-To: <20190802053744.5519-1-clin@suse.com>

On Fri, Aug 02, 2019 at 05:38:54AM +0000, Chester Lin wrote:
> diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c
> index f3ce34113f89..909b11ba48d8 100644
> --- a/arch/arm/mm/mmu.c
> +++ b/arch/arm/mm/mmu.c
> @@ -1184,6 +1184,9 @@ void __init adjust_lowmem_bounds(void)
>  		phys_addr_t block_start = reg->base;
>  		phys_addr_t block_end = reg->base + reg->size;
>  
> +		if (memblock_is_nomap(reg))
> +			continue;
> +
>  		if (reg->base < vmalloc_limit) {
>  			if (block_end > lowmem_limit)
>  				/*

I think this hunk is sane - if the memory is marked nomap, then it isn't
available for the kernel's use, so as far as calculating where the
lowmem/highmem boundary is, it effectively doesn't exist and should be
skipped.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-08-20 11:57 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-02  5:38 [PATCH] efi/arm: fix allocation failure when reserving the kernel base Chester Lin
2019-08-02  5:38 ` Chester Lin
2019-08-04  7:57 ` Ard Biesheuvel
2019-08-04  7:57   ` Ard Biesheuvel
2019-08-14  7:58   ` Guillaume Gardet
2019-08-14  7:58     ` Guillaume Gardet
2019-08-15  7:59   ` Ard Biesheuvel
2019-08-15  7:59     ` Ard Biesheuvel
2019-08-15 11:16     ` Chester Lin
2019-08-15 11:16       ` Chester Lin
2019-08-15 11:32       ` Ard Biesheuvel
2019-08-15 11:32         ` Ard Biesheuvel
2019-08-15 13:37         ` Mike Rapoport
2019-08-15 13:37           ` Mike Rapoport
2019-08-19  7:56           ` Chester Lin
2019-08-19  7:56             ` Chester Lin
2019-08-19 14:56             ` Ard Biesheuvel
2019-08-19 14:56               ` Ard Biesheuvel
2019-08-20  7:33               ` Chester Lin
2019-08-20  7:33                 ` Chester Lin
2019-08-20  7:49               ` Mike Rapoport
2019-08-20  7:49                 ` Mike Rapoport
2019-08-20 10:29                 ` Chester Lin
2019-08-20 10:29                   ` Chester Lin
2019-08-20 11:00                 ` Ard Biesheuvel
2019-08-20 11:00                   ` Ard Biesheuvel
2019-08-20 11:54   ` Russell King - ARM Linux admin
2019-08-20 11:54     ` Russell King - ARM Linux admin
2019-08-20 12:27     ` Ard Biesheuvel
2019-08-20 12:27       ` Ard Biesheuvel
2019-08-20 11:56 ` Russell King - ARM Linux admin [this message]
2019-08-20 11:56   ` Russell King - ARM Linux admin
2019-08-20 12:28   ` Ard Biesheuvel
2019-08-20 12:28     ` Ard Biesheuvel
2019-08-21  6:10     ` Chester Lin
2019-08-21  6:10       ` Chester Lin
2019-08-21  6:35       ` Ard Biesheuvel
2019-08-21  6:35         ` Ard Biesheuvel
2019-08-21  7:11         ` Mike Rapoport
2019-08-21  7:11           ` Mike Rapoport
2019-08-21  7:22           ` Chester Lin
2019-08-21  7:22             ` Chester Lin
2019-08-21  7:29           ` Ard Biesheuvel
2019-08-21  7:29             ` Ard Biesheuvel
2019-08-21  8:29             ` Mike Rapoport
2019-08-21  8:29               ` Mike Rapoport
2019-08-21  9:42               ` Ard Biesheuvel
2019-08-21  9:42                 ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190820115645.GP13294@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=GLin@suse.com \
    --cc=JGross@suse.com \
    --cc=JLee@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=clin@suse.com \
    --cc=geert@linux-m68k.org \
    --cc=guillaume.gardet@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=ren_guo@c-sky.com \
    --cc=rppt@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.