From: Bob Copeland <me@bobcopeland.com>
To: Wenwen Wang <wenwen@cs.uga.edu>
Cc: "open list:OMFS FILESYSTEM"
<linux-karma-devel@lists.sourceforge.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] omfs: Fix a memory leak bug
Date: Tue, 20 Aug 2019 10:16:13 -0400 [thread overview]
Message-ID: <20190820141613.GA5634@localhost> (raw)
In-Reply-To: <1566282180-10485-1-git-send-email-wenwen@cs.uga.edu>
On Tue, Aug 20, 2019 at 01:22:59AM -0500, Wenwen Wang wrote:
> In omfs_get_imap(), 'sbi->s_imap' is allocated through kcalloc(). However,
> it is not deallocated in the following execution if 'block' is not less
> than 'sbi->s_num_blocks', leading to a memory leak bug. To fix this issue,
> go to the 'nomem_free' label to free 'sbi->s_imap'.
Nice catch, thanks.
Acked-by: Bob Copeland <me@bobcopeland.com>
--
Bob Copeland %% https://bobcopeland.com/
prev parent reply other threads:[~2019-08-20 14:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 6:22 [PATCH] omfs: Fix a memory leak bug Wenwen Wang
2019-08-20 14:16 ` Bob Copeland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820141613.GA5634@localhost \
--to=me@bobcopeland.com \
--cc=linux-karma-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=wenwen@cs.uga.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.