From: Bruno Meneguele <bmeneg@redhat.com>
To: Vitaly Chikunov <vt@altlinux.org>
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH] ima-evm-utils: Change log text of hash in hash_ima
Date: Tue, 20 Aug 2019 12:23:11 -0300 [thread overview]
Message-ID: <20190820152311.GD7410@rhlt> (raw)
In-Reply-To: <20190817223229.22623-1-vt@altlinux.org>
[-- Attachment #1: Type: text/plain, Size: 921 bytes --]
On Sun, Aug 18, 2019 at 01:32:29AM +0300, Vitaly Chikunov wrote:
> Output value is not just a hash, but hash prefixed with header. User may
> be confused to see invalid hash value. Thus, change text so that is
> obvious this is not a raw hash.
>
> Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
> ---
> src/evmctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/evmctl.c b/src/evmctl.c
> index ef1f289..53711f4 100644
> --- a/src/evmctl.c
> +++ b/src/evmctl.c
> @@ -606,7 +606,7 @@ static int hash_ima(const char *file)
> len += offset;
>
> if (imaevm_params.verbose >= LOG_INFO)
> - log_info("hash(%s): ", imaevm_params.hash_algo);
> + log_info("hdr+hash(%s): ", imaevm_params.hash_algo);
>
> if (sigdump || imaevm_params.verbose >= LOG_INFO)
> imaevm_hexdump(hash, len);
> --
> 2.11.0
>
Haha, simple but really useful change :)
Thanks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-08-20 15:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-17 22:32 [PATCH] ima-evm-utils: Change log text of hash in hash_ima Vitaly Chikunov
2019-08-20 15:23 ` Bruno Meneguele [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820152311.GD7410@rhlt \
--to=bmeneg@redhat.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=linux-integrity@vger.kernel.org \
--cc=vt@altlinux.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.