From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 050EBC3A59E for ; Tue, 20 Aug 2019 17:41:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D043823407 for ; Tue, 20 Aug 2019 17:41:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="oTJV/F9u" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730689AbfHTRlT (ORCPT ); Tue, 20 Aug 2019 13:41:19 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:42164 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730680AbfHTRlS (ORCPT ); Tue, 20 Aug 2019 13:41:18 -0400 Received: from pendragon.ideasonboard.com (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 925D533D; Tue, 20 Aug 2019 19:41:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1566322876; bh=8TSAbOc99oaocNanYpIuNSjuJymG5rkFZtxYVVqu2wU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oTJV/F9uYWNZIyTdvp2beSi864kYUk09+Kil83mxRJqLnCUfKp6GLjFjFhe+0qzGK j1kpG8z5++Fhw2CUBIXfW/mSDmYrqPfUYpadGJVMau+4lBA6pj6N/V1xvjNsiENKFi XuoF6BLOH+sSnElD/PbT4xEU5K10CwPnYsKDQHMQ= Date: Tue, 20 Aug 2019 20:41:10 +0300 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Jacopo Mondi , Jacopo Mondi , Kieran Bingham , David Airlie , Daniel Vetter , Koji Matsuoka , muroya@ksk.co.jp, VenkataRajesh.Kalakodima@in.bosch.com, Harsha.ManjulaMallikarjun@in.bosch.com, Linux-Renesas , DRI Development , Linux Kernel Mailing List Subject: Re: [PATCH v2 01/19] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation Message-ID: <20190820174110.GH10820@pendragon.ideasonboard.com> References: <20190706140746.29132-1-jacopo+renesas@jmondi.org> <20190706140746.29132-2-jacopo+renesas@jmondi.org> <20190820074826.5rdzeqyk6ylpjr7o@uno.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Geert, On Tue, Aug 20, 2019 at 09:53:44AM +0200, Geert Uytterhoeven wrote: > On Tue, Aug 20, 2019 at 9:47 AM Jacopo Mondi wrote: > > On Mon, Aug 19, 2019 at 03:45:54PM +0200, Geert Uytterhoeven wrote: > >> On Mon, Jul 8, 2019 at 9:58 AM Geert Uytterhoeven wrote: > >>> On Sat, Jul 6, 2019 at 4:07 PM Jacopo Mondi wrote: > >>>> Add device tree bindings documentation for the Renesas R-Car Display > >>>> Unit Color Management Module. > >>>> > >>>> CMM is the image enhancement module available on each R-Car DU video > >>>> channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded). > >>>> > >>>> Signed-off-by: Jacopo Mondi > >>>> Reviewed-by: Laurent Pinchart > >>> > >>> Thanks for your patch! > >>> > >>>> --- /dev/null > >>>> +++ b/Documentation/devicetree/bindings/display/renesas,cmm.txt > >>>> @@ -0,0 +1,25 @@ > >>>> +* Renesas R-Car Color Management Module (CMM) > >>>> + > >>>> +Renesas R-Car image enhancement module connected to R-Car DU video channels. > >>>> + > >>>> +Required properties: > >>>> + - compatible: shall be one of: > >>>> + - "renesas,rcar-gen3-cmm" > >>>> + - "renesas,rcar-gen2-cmm" > >>> > >>> Why do you think you do not need SoC-specific compatible values? > >>> What if you discover a different across the R-Car Gen3 line tomorrow? > >>> Does the IP block have a version register? > >> > >> Do you have an answer to these questions? > > > > It does not seem to me that CMM has any version register, nor there > > are differences between the different Gen3 SoCs.. > > > > However, even if we now define a single compatible property for > > gen3/gen2 and we later find out one of the SoC needs a soc-specific > > property we can safely add it and keep the generic gen3/gen2 one as > > fallback.. Does it work for you? > > Unfortunately that won't work, as the existing DTBs won't have the > soc-specific compatible value. > You could still resort to soc_device_match(), but it is better to avoid that. We've had the same discussion over and over for quite a long time :-) I wonder, now that we have implemented SoC-specific compatible values for many IP cores, how many of them have actually benefited from it ? I'm not considering IP cores where we knew from the start that each SoC was different (such as pinctrl or clocks for instance), but IP cores where we though all SoCs would be handled in the same way. I also wouldn't count ES-specific differences, as those are handled by soc_device_match() anyway. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 01/19] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation Date: Tue, 20 Aug 2019 20:41:10 +0300 Message-ID: <20190820174110.GH10820@pendragon.ideasonboard.com> References: <20190706140746.29132-1-jacopo+renesas@jmondi.org> <20190706140746.29132-2-jacopo+renesas@jmondi.org> <20190820074826.5rdzeqyk6ylpjr7o@uno.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id AA1E06E44A for ; Tue, 20 Aug 2019 17:41:18 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Geert Uytterhoeven Cc: muroya@ksk.co.jp, Jacopo Mondi , VenkataRajesh.Kalakodima@in.bosch.com, David Airlie , Koji Matsuoka , DRI Development , Linux Kernel Mailing List , Linux-Renesas , Kieran Bingham , Jacopo Mondi , Harsha.ManjulaMallikarjun@in.bosch.com List-Id: dri-devel@lists.freedesktop.org SGkgR2VlcnQsCgpPbiBUdWUsIEF1ZyAyMCwgMjAxOSBhdCAwOTo1Mzo0NEFNICswMjAwLCBHZWVy dCBVeXR0ZXJob2V2ZW4gd3JvdGU6Cj4gT24gVHVlLCBBdWcgMjAsIDIwMTkgYXQgOTo0NyBBTSBK YWNvcG8gTW9uZGkgPGphY29wb0BqbW9uZGkub3JnPiB3cm90ZToKPiA+IE9uIE1vbiwgQXVnIDE5 LCAyMDE5IGF0IDAzOjQ1OjU0UE0gKzAyMDAsIEdlZXJ0IFV5dHRlcmhvZXZlbiB3cm90ZToKPiA+ PiBPbiBNb24sIEp1bCA4LCAyMDE5IGF0IDk6NTggQU0gR2VlcnQgVXl0dGVyaG9ldmVuIDxnZWVy dEBsaW51eC1tNjhrLm9yZz4gd3JvdGU6Cj4gPj4+IE9uIFNhdCwgSnVsIDYsIDIwMTkgYXQgNDow NyBQTSBKYWNvcG8gTW9uZGkgPGphY29wbytyZW5lc2FzQGptb25kaS5vcmc+IHdyb3RlOgo+ID4+ Pj4gQWRkIGRldmljZSB0cmVlIGJpbmRpbmdzIGRvY3VtZW50YXRpb24gZm9yIHRoZSBSZW5lc2Fz IFItQ2FyIERpc3BsYXkKPiA+Pj4+IFVuaXQgQ29sb3IgTWFuYWdlbWVudCBNb2R1bGUuCj4gPj4+ Pgo+ID4+Pj4gQ01NIGlzIHRoZSBpbWFnZSBlbmhhbmNlbWVudCBtb2R1bGUgYXZhaWxhYmxlIG9u IGVhY2ggUi1DYXIgRFUgdmlkZW8KPiA+Pj4+IGNoYW5uZWwgb24gUi1DYXIgR2VuMiBhbmQgR2Vu MyBTb0NzIChWM0ggYW5kIFYzTSBleGNsdWRlZCkuCj4gPj4+Pgo+ID4+Pj4gU2lnbmVkLW9mZi1i eTogSmFjb3BvIE1vbmRpIDxqYWNvcG8rcmVuZXNhc0BqbW9uZGkub3JnPgo+ID4+Pj4gUmV2aWV3 ZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNv bT4KPiA+Pj4KPiA+Pj4gVGhhbmtzIGZvciB5b3VyIHBhdGNoIQo+ID4+Pgo+ID4+Pj4gLS0tIC9k ZXYvbnVsbAo+ID4+Pj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rp c3BsYXkvcmVuZXNhcyxjbW0udHh0Cj4gPj4+PiBAQCAtMCwwICsxLDI1IEBACj4gPj4+PiArKiBS ZW5lc2FzIFItQ2FyIENvbG9yIE1hbmFnZW1lbnQgTW9kdWxlIChDTU0pCj4gPj4+PiArCj4gPj4+ PiArUmVuZXNhcyBSLUNhciBpbWFnZSBlbmhhbmNlbWVudCBtb2R1bGUgY29ubmVjdGVkIHRvIFIt Q2FyIERVIHZpZGVvIGNoYW5uZWxzLgo+ID4+Pj4gKwo+ID4+Pj4gK1JlcXVpcmVkIHByb3BlcnRp ZXM6Cj4gPj4+PiArIC0gY29tcGF0aWJsZTogc2hhbGwgYmUgb25lIG9mOgo+ID4+Pj4gKyAgIC0g InJlbmVzYXMscmNhci1nZW4zLWNtbSIKPiA+Pj4+ICsgICAtICJyZW5lc2FzLHJjYXItZ2VuMi1j bW0iCj4gPj4+Cj4gPj4+IFdoeSBkbyB5b3UgdGhpbmsgeW91IGRvIG5vdCBuZWVkIFNvQy1zcGVj aWZpYyBjb21wYXRpYmxlIHZhbHVlcz8KPiA+Pj4gV2hhdCBpZiB5b3UgZGlzY292ZXIgYSBkaWZm ZXJlbnQgYWNyb3NzIHRoZSBSLUNhciBHZW4zIGxpbmUgdG9tb3Jyb3c/Cj4gPj4+IERvZXMgdGhl IElQIGJsb2NrIGhhdmUgYSB2ZXJzaW9uIHJlZ2lzdGVyPwo+ID4+Cj4gPj4gRG8geW91IGhhdmUg YW4gYW5zd2VyIHRvIHRoZXNlIHF1ZXN0aW9ucz8KPiA+Cj4gPiBJdCBkb2VzIG5vdCBzZWVtIHRv IG1lIHRoYXQgQ01NIGhhcyBhbnkgdmVyc2lvbiByZWdpc3Rlciwgbm9yIHRoZXJlCj4gPiBhcmUg ZGlmZmVyZW5jZXMgYmV0d2VlbiB0aGUgZGlmZmVyZW50IEdlbjMgU29Dcy4uCj4gPgo+ID4gSG93 ZXZlciwgZXZlbiBpZiB3ZSBub3cgZGVmaW5lIGEgc2luZ2xlIGNvbXBhdGlibGUgcHJvcGVydHkg Zm9yCj4gPiBnZW4zL2dlbjIgYW5kIHdlIGxhdGVyIGZpbmQgb3V0IG9uZSBvZiB0aGUgU29DIG5l ZWRzIGEgc29jLXNwZWNpZmljCj4gPiBwcm9wZXJ0eSB3ZSBjYW4gc2FmZWx5IGFkZCBpdCBhbmQg a2VlcCB0aGUgZ2VuZXJpYyBnZW4zL2dlbjIgb25lIGFzCj4gPiBmYWxsYmFjay4uIERvZXMgaXQg d29yayBmb3IgeW91Pwo+IAo+IFVuZm9ydHVuYXRlbHkgdGhhdCB3b24ndCB3b3JrLCBhcyB0aGUg ZXhpc3RpbmcgRFRCcyB3b24ndCBoYXZlIHRoZQo+IHNvYy1zcGVjaWZpYyBjb21wYXRpYmxlIHZh bHVlLgo+IFlvdSBjb3VsZCBzdGlsbCByZXNvcnQgdG8gc29jX2RldmljZV9tYXRjaCgpLCBidXQg aXQgaXMgYmV0dGVyIHRvIGF2b2lkIHRoYXQuCgpXZSd2ZSBoYWQgdGhlIHNhbWUgZGlzY3Vzc2lv biBvdmVyIGFuZCBvdmVyIGZvciBxdWl0ZSBhIGxvbmcgdGltZSA6LSkgSQp3b25kZXIsIG5vdyB0 aGF0IHdlIGhhdmUgaW1wbGVtZW50ZWQgU29DLXNwZWNpZmljIGNvbXBhdGlibGUgdmFsdWVzIGZv cgptYW55IElQIGNvcmVzLCBob3cgbWFueSBvZiB0aGVtIGhhdmUgYWN0dWFsbHkgYmVuZWZpdGVk IGZyb20gaXQgPyBJJ20Kbm90IGNvbnNpZGVyaW5nIElQIGNvcmVzIHdoZXJlIHdlIGtuZXcgZnJv bSB0aGUgc3RhcnQgdGhhdCBlYWNoIFNvQyB3YXMKZGlmZmVyZW50IChzdWNoIGFzIHBpbmN0cmwg b3IgY2xvY2tzIGZvciBpbnN0YW5jZSksIGJ1dCBJUCBjb3JlcyB3aGVyZQp3ZSB0aG91Z2ggYWxs IFNvQ3Mgd291bGQgYmUgaGFuZGxlZCBpbiB0aGUgc2FtZSB3YXkuIEkgYWxzbyB3b3VsZG4ndApj b3VudCBFUy1zcGVjaWZpYyBkaWZmZXJlbmNlcywgYXMgdGhvc2UgYXJlIGhhbmRsZWQgYnkKc29j X2RldmljZV9tYXRjaCgpIGFueXdheS4KCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=