From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v4 00/25] drm: Kirin driver cleanups to prep for Kirin960 support Date: Tue, 20 Aug 2019 22:01:41 +0200 Message-ID: <20190820200141.GA23191@ravnborg.org> References: <20190819230321.56480-1-john.stultz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1D6266E87A for ; Tue, 20 Aug 2019 20:01:46 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190819230321.56480-1-john.stultz@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Stultz Cc: David Airlie , lkml , dri-devel , Xinliang Liu , Rongrong Zou List-Id: dri-devel@lists.freedesktop.org SGkgSm9obi4KCk9uIE1vbiwgQXVnIDE5LCAyMDE5IGF0IDExOjAyOjU2UE0gKzAwMDAsIEpvaG4g U3R1bHR6IHdyb3RlOgo+IFNlbmRpbmcgdGhpcyBvdXQgYWdhaW4sIHRvIGdldCBpdCBiYXNlZCBv biBkcm0tbWlzYy1uZXh0Lgo+IAo+IFRoaXMgcGF0Y2hzZXQgY29udGFpbnMgb25lIGZpeCAoaW4g dGhlIGZyb250LCBzbyBpdHMgZWFzaWVyIHRvCj4gZXZlbnR1YWxseSBiYWNrcG9ydCksIGFuZCBh IHNlcmllcyBvZiBjaGFuZ2VzIGZyb20gWWlQaW5nIHRvCj4gcmVmYWN0b3IgdGhlIGtpcmluIGRy bSBkcml2ZXIgc28gdGhhdCBpdCBjYW4gYmUgdXNlZCBvbiBib3RoCj4ga2lyaW42MjAgYmFzZWQg ZGV2aWNlcyAobGlrZSB0aGUgb3JpZ2luYWwgSGlLZXkgYm9hcmQpIGFzIHdlbGwKPiBhcyBraXJp bjk2MCBiYXNlZCBkZXZpY2VzIChsaWtlIHRoZSBIaUtleTk2MCBib2FyZCkuCj4gCj4gVGhlIGZ1 bGwga2lyaW45NjAgZHJtIHN1cHBvcnQgaXMgc3RpbGwgYmVpbmcgcmVmYWN0b3JlZCwgYnV0IGFz Cj4gdGhpcyBiYXNlIGtpcmluIHJld29yayB3YXMgZ2V0dGluZyB0byBiZSBzdWJzdGFudGlhbCwg SSB3YW50ZWQKPiB0byBzZW5kIG91dCB0aGUgZmlyc3QgY2h1bmssIHNvIHRoYXQgdGhlIHJldmll dyBidXJkZW4gd2Fzbid0Cj4gb3ZlcndoZWxtaW5nLgo+IAo+IFRoZSBmdWxsIEhpS2V5OTYwIHBh dGNoIHN0YWNrIGNhbiBiZSBmb3VuZCBoZXJlOgo+ICAgaHR0cHM6Ly9naXQubGluYXJvLm9yZy9w ZW9wbGUvam9obi5zdHVsdHovYW5kcm9pZC1kZXYuZ2l0L2xvZy8/aD1kZXYvaGlrZXk5NjAtbWFp bmxpbmUtV0lQCj4gCj4gdGhhbmtzCj4gLWpvaG4KPiAKPiAKPiBOZXcgaW4gdjQ6Cj4gKiBSZWJh c2VkIHRvIGRybS1taXNjLW5leHQsIG1pbm9yIHR3ZWFrcyB0byBtZXJnZSBjaGFuZ2VzCj4gKiBE cm9wcGVkICJkcm06IGtpcmluOiBHZXQgcmlkIG9mIGRybVAuaCBpbmNsdWRlcyIgYXMgc2ltaWxh ciBjaGFuZ2UKPiAgIHdhcyBhbHJlYWR5IGluIGRybS1taXNjIG5leHQKPiAqIEFkZGVkIGFja2Vk LWJ5IHRhZyBmcm9tIFhpbmxpYW5nCgpUaGVyZSB3YXMgc29tZSBjaGVja3BhdGNoIG5vaXNlcyBp biBzb21lIG9mIHRoZSBwYXRjaGVzIC0gcGxlYXNlIHZlcmlmeQp3aXRoICItLXN0cmljdCIuCk1v c3RseSBhbGlnbm1lbnQgb2YgcGFyYW1ldGVycyB3aXRoIG9wZW4gcGFyYW50ZXNpcwpTYW1wbGUg LSBidXQgdGhlcmUgd2FzIHNpbWlsYXIgaXNzdWVzIGluIG90aGVyIHBhdGNoZXM6Cgo4Nzg4YjU5 ZGVjYzggKEhFQUQgLT4gZHJtLW1pc2MtbmV4dCkgZHJtOiBraXJpbjogTW92ZSBhZGUgZHJtIGlu aXQgdG8ga2lyaW4gZHJtIGRydgotOjIwODogQ0hFQ0s6UEFSRU5USEVTSVNfQUxJR05NRU5UOiBB bGlnbm1lbnQgc2hvdWxkIG1hdGNoIG9wZW4gcGFyZW50aGVzaXMKIzIwODogRklMRTogZHJpdmVy cy9ncHUvZHJtL2hpc2lsaWNvbi9raXJpbi9raXJpbl9kcm1fZHJ2LmM6NDE6CitzdGF0aWMgaW50 IGtpcmluX2RybV9jcnRjX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGRybV9j cnRjICpjcnRjLAorCQkJCXN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAoKLToyNDQ6IENIRUNLOlBB UkVOVEhFU0lTX0FMSUdOTUVOVDogQWxpZ25tZW50IHNob3VsZCBtYXRjaCBvcGVuIHBhcmVudGhl c2lzCiMyNDQ6IEZJTEU6IGRyaXZlcnMvZ3B1L2RybS9oaXNpbGljb24va2lyaW4va2lyaW5fZHJt X2Rydi5jOjc3OgorCXJldCA9IGRybV91bml2ZXJzYWxfcGxhbmVfaW5pdChkZXYsIHBsYW5lLCAx LCBkYXRhLT5wbGFuZV9mdW5jcywKKwkJCQlkYXRhLT5jaGFubmVsX2Zvcm1hdHMsCgotOjI3MTog Q0hFQ0s6UEFSRU5USEVTSVNfQUxJR05NRU5UOiBBbGlnbm1lbnQgc2hvdWxkIG1hdGNoIG9wZW4g cGFyZW50aGVzaXMKIzI3MTogRklMRTogZHJpdmVycy9ncHUvZHJtL2hpc2lsaWNvbi9raXJpbi9r aXJpbl9kcm1fZHJ2LmM6MTA0Ogorc3RhdGljIGludCBraXJpbl9kcm1fcHJpdmF0ZV9pbml0KHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYsCisJCQkJY29uc3Qgc3RydWN0IGtpcmluX2RybV9kYXRhICpk cml2ZXJfZGF0YSkKCgoKCkFuZCB0aGVuIHRoZSBidWlsZCBmYWlsZWQgbGlrZSB0aGlzOgogTEQg W01dICBkcml2ZXJzL2dwdS9kcm0vaGlzaWxpY29uL2tpcmluL2tpcmluLWRybS5vCmFhcmNoNjQt bGludXgtZ251LWxkOiBkcml2ZXJzL2dwdS9kcm0vaGlzaWxpY29uL2tpcmluL2R3X2RybV9kc2ku bzogaW4gZnVuY3Rpb24gYGluaXRfbW9kdWxlJzoKZHdfZHJtX2RzaS5jOiguaW5pdC50ZXh0KzB4 MCk6IG11bHRpcGxlIGRlZmluaXRpb24gb2YgYGluaXRfbW9kdWxlJzsgZHJpdmVycy9ncHUvZHJt L2hpc2lsaWNvbi9raXJpbi9raXJpbl9kcm1fZHJ2Lm86a2lyaW5fZHJtX2Rydi5jOiguaW5pdC50 ZXh0KzB4MCk6IGZpcnN0IGRlZmluZWQgaGVyZQphYXJjaDY0LWxpbnV4LWdudS1sZDogZHJpdmVy cy9ncHUvZHJtL2hpc2lsaWNvbi9raXJpbi9kd19kcm1fZHNpLm86IGluIGZ1bmN0aW9uIGBjbGVh bnVwX21vZHVsZSc6CmR3X2RybV9kc2kuYzooLmV4aXQudGV4dCsweDApOiBtdWx0aXBsZSBkZWZp bml0aW9uIG9mIGBjbGVhbnVwX21vZHVsZSc7IGRyaXZlcnMvZ3B1L2RybS9oaXNpbGljb24va2ly aW4va2lyaW5fZHJtX2Rydi5vOmtpcmluX2RybV9kcnYuYzooLmV4aXQudGV4dCsweDApOiBmaXJz dCBkZWZpbmVkIGhlcmUKbWFrZVszXTogKioqIFsvaG9tZS9zYW0vZHJtL2xpbnV4LmdpdC9zY3Jp cHRzL01ha2VmaWxlLmJ1aWxkOjQ2NDogZHJpdmVycy9ncHUvZHJtL2hpc2lsaWNvbi9raXJpbi9r aXJpbi1kcm0ub10gRXJyb3IgMQptYWtlWzJdOiAqKiogWy9ob21lL3NhbS9kcm0vbGludXguZ2l0 L3NjcmlwdHMvTWFrZWZpbGUuYnVpbGQ6NDkwOiBkcml2ZXJzL2dwdS9kcm0vaGlzaWxpY29uL2tp cmluXSBFcnJvciAyCm1ha2VbMV06ICoqKiBbL2hvbWUvc2FtL2RybS9saW51eC5naXQvTWFrZWZp bGU6MTc3NjogZHJpdmVycy9ncHUvZHJtL2hpc2lsaWNvbi9dIEVycm9yIDIKbWFrZVsxXTogTGVh dmluZyBkaXJlY3RvcnkgJy9ob21lL3NhbS9kcm0vbGludXguZ2l0Ly5idWlsZC9hcm02NC1hbGxt b2Rjb25maWcnCm1ha2U6ICoqKiBbTWFrZWZpbGU6MTc5OiBzdWItbWFrZV0gRXJyb3IgMgoKSXQg d2FzIGEgc2ltcGxlIGFsbG1vZGNvbmZpZyBidWlsZCB3aGVyZSBJIGRpZDoKCm1ha2UgZHJpdmVy cy9ncHUvZHJtL2hpc2lsaWNvbi8KClBsZWFzZSBmaXggYW5kIHJlc2VuZC4gSSBkaWQgbm90IGxv b2sgZnVydGhlci4KCglTYW0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B15B4C3A589 for ; Tue, 20 Aug 2019 20:01:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C89322DD3 for ; Tue, 20 Aug 2019 20:01:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730851AbfHTUBs (ORCPT ); Tue, 20 Aug 2019 16:01:48 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:60864 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729950AbfHTUBs (ORCPT ); Tue, 20 Aug 2019 16:01:48 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 2BC9F20094; Tue, 20 Aug 2019 22:01:43 +0200 (CEST) Date: Tue, 20 Aug 2019 22:01:41 +0200 From: Sam Ravnborg To: John Stultz Cc: lkml , Rongrong Zou , Xinliang Liu , David Airlie , Daniel Vetter , dri-devel Subject: Re: [PATCH v4 00/25] drm: Kirin driver cleanups to prep for Kirin960 support Message-ID: <20190820200141.GA23191@ravnborg.org> References: <20190819230321.56480-1-john.stultz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190819230321.56480-1-john.stultz@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=KKAkSRfTAAAA:8 a=Wes08NWIifAUlHyeTIUA:9 a=CjuIK1q_8ugA:10 a=cvBusfyB2V15izCimMoJ:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John. On Mon, Aug 19, 2019 at 11:02:56PM +0000, John Stultz wrote: > Sending this out again, to get it based on drm-misc-next. > > This patchset contains one fix (in the front, so its easier to > eventually backport), and a series of changes from YiPing to > refactor the kirin drm driver so that it can be used on both > kirin620 based devices (like the original HiKey board) as well > as kirin960 based devices (like the HiKey960 board). > > The full kirin960 drm support is still being refactored, but as > this base kirin rework was getting to be substantial, I wanted > to send out the first chunk, so that the review burden wasn't > overwhelming. > > The full HiKey960 patch stack can be found here: > https://git.linaro.org/people/john.stultz/android-dev.git/log/?h=dev/hikey960-mainline-WIP > > thanks > -john > > > New in v4: > * Rebased to drm-misc-next, minor tweaks to merge changes > * Dropped "drm: kirin: Get rid of drmP.h includes" as similar change > was already in drm-misc next > * Added acked-by tag from Xinliang There was some checkpatch noises in some of the patches - please verify with "--strict". Mostly alignment of parameters with open parantesis Sample - but there was similar issues in other patches: 8788b59decc8 (HEAD -> drm-misc-next) drm: kirin: Move ade drm init to kirin drm drv -:208: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #208: FILE: drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c:41: +static int kirin_drm_crtc_init(struct drm_device *dev, struct drm_crtc *crtc, + struct drm_plane *plane, -:244: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #244: FILE: drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c:77: + ret = drm_universal_plane_init(dev, plane, 1, data->plane_funcs, + data->channel_formats, -:271: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #271: FILE: drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c:104: +static int kirin_drm_private_init(struct drm_device *dev, + const struct kirin_drm_data *driver_data) And then the build failed like this: LD [M] drivers/gpu/drm/hisilicon/kirin/kirin-drm.o aarch64-linux-gnu-ld: drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.o: in function `init_module': dw_drm_dsi.c:(.init.text+0x0): multiple definition of `init_module'; drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.o:kirin_drm_drv.c:(.init.text+0x0): first defined here aarch64-linux-gnu-ld: drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.o: in function `cleanup_module': dw_drm_dsi.c:(.exit.text+0x0): multiple definition of `cleanup_module'; drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.o:kirin_drm_drv.c:(.exit.text+0x0): first defined here make[3]: *** [/home/sam/drm/linux.git/scripts/Makefile.build:464: drivers/gpu/drm/hisilicon/kirin/kirin-drm.o] Error 1 make[2]: *** [/home/sam/drm/linux.git/scripts/Makefile.build:490: drivers/gpu/drm/hisilicon/kirin] Error 2 make[1]: *** [/home/sam/drm/linux.git/Makefile:1776: drivers/gpu/drm/hisilicon/] Error 2 make[1]: Leaving directory '/home/sam/drm/linux.git/.build/arm64-allmodconfig' make: *** [Makefile:179: sub-make] Error 2 It was a simple allmodconfig build where I did: make drivers/gpu/drm/hisilicon/ Please fix and resend. I did not look further. Sam