From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] tst_res: Print errno number in addition to error name
Date: Wed, 21 Aug 2019 10:36:50 +0200 [thread overview]
Message-ID: <20190821083650.GA26334@rei.lan> (raw)
In-Reply-To: <87y2znuf0a.fsf@rpws.prws.suse.cz>
Hi!
> >> > > It appears we are atleast missing ENOTSUPP (524) which is probably returned by
> >> > > create_timer for some alarm clocks on none x86 arches. This isn't entirely
> >> > > clear, but what is clear is that it would help to know what the error number
> >> > > is without using strace.
> >> >
> >> > Can we please also patch the lib/errnos.h so that the ENOTSUPP is
> >> > included there as well?
> >>
> >> Not sure if we should do that since it(from google) says ENOTSUPP is
> >> not intended to used in userland.
>
> I suppose we could print a warning/fail if any error value over 512
> (ERESTARTSYS) is seen by tst_res(). We can define these error numbers in
> user land for debugging purposes.
Sounds good to me, I wouldn't do it a fail, even simple TINFO message
that would say that we got unexpected errno.
And we should btw do that for the tst_strerrno() as well.
> > Looks like there are two of these ENOTSUP and ENOTSUPP so the syscall
> > returning ENOTSUPP is a bug itself since it should return ENOTSUP. Also
> > btw ENOTSUP == EOPNOTSUPP and we do have EOPNOTSUPP in errnos.h.
>
> I think there is quite a lot of stuff missing. Maybe it is time to
> create a script for generating this list?
We can but I would just commit the resulting header to LTP since the
list will not change frequently or at all.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-08-21 8:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 13:36 [LTP] [PATCH] tst_res: Print errno number in addition to error name Richard Palethorpe
2019-08-20 7:38 ` Li Wang
2019-08-20 9:55 ` Cyril Hrubis
2019-08-20 9:56 ` Cyril Hrubis
2019-08-20 10:10 ` Li Wang
2019-08-20 10:28 ` Cyril Hrubis
2019-08-20 10:20 ` Li Wang
2019-08-20 10:27 ` Cyril Hrubis
2019-08-21 7:57 ` Richard Palethorpe
2019-08-21 8:36 ` Cyril Hrubis [this message]
2019-09-10 13:00 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821083650.GA26334@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.