From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E78AC3A59E for ; Wed, 21 Aug 2019 09:20:53 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2891D204EC for ; Wed, 21 Aug 2019 09:20:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="SK/0nijr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2891D204EC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i0Mn3-0002BI-Nq; Wed, 21 Aug 2019 09:20:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i0Mn2-0002BD-5a for xen-devel@lists.xenproject.org; Wed, 21 Aug 2019 09:20:24 +0000 X-Inumbo-ID: e73a20ec-c3f4-11e9-8980-bc764e2007e4 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e73a20ec-c3f4-11e9-8980-bc764e2007e4; Wed, 21 Aug 2019 09:20:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1566379223; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=BK2UfPfQnsAdpwWahhn9/K+61xT4PsE2aBOjJXllKHk=; b=SK/0nijrUdDCe9fs1DIlze6ZzdVZYctovmA++0j702F2MAb4iuuH9zQ1 bQIt3sljkzOfKvSwyXWYBm2KQ+LxxnVkUxJOuhuSSgX15ZpMdccr1klH/ Jz9eVWCcu6LSHG8jYggVqtXH69CwIbUg4mwKpgIAHTcTZ86ySGrYcLgSq I=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: Dre/avdhM7+LkeeYNgXPxCnkXilAmFPsNzT4qdmjCyNlv3RbAuMOhVn8Hnt589TC2ULQAyStmJ wztSwrqA0slgsaYkaxu90dU3UyfmxOHqd0ywcZ+98kK+RjFO9FYLuJIE8r0tRR/Gn7YVBB4lqB b6iSUVXUkjPwrJUtVz621eni4MLaOxm7efr/gQJaNhCkecfQ5HGEJ5VuHoNh6x87n95f+58EuQ 1tNsyO2VabwmwuQl/amP+KFPELiUvI3GQAooAUS887cQnyBt9uPiTpot6St8gekcuXoRKO+e2D PLI= X-SBRS: 2.7 X-MesageID: 4731850 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,412,1559534400"; d="scan'208";a="4731850" From: Anthony PERARD To: Date: Wed, 21 Aug 2019 10:20:19 +0100 Message-ID: <20190821092020.17952-2-anthony.perard@citrix.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190821092020.17952-1-anthony.perard@citrix.com> References: <20190821092020.17952-1-anthony.perard@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 1/2] xen-bus: Fix backend state transition on device reset X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , xen-devel@lists.xenproject.org, Stefano Stabellini , qemu-stable@nongnu.org, Paul Durrant Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" V2hlbiBhIGZyb250ZW5kIHdhbnQgdG8gcmVzZXQgaXRzIHN0YXRlIGFuZCB0aGUgYmFja2VuZCBv bmUsIGl0IHN0YXJ0CndpdGggc2V0dGluZyAiQ2xvc2luZyIsIHRoZW4gd2FpdCBmb3IgdGhlIGJh Y2tlbmQgKFFFTVUpIHRvIGRvIHRoZSBzYW1lLgoKQnV0IHdoZW4gUUVNVSBpcyBzZXR0aW5nICJD bG9zaW5nIiB0byBpdHMgc3RhdGUsIGl0IHRyaWdnZXIgYW4gZXZlbnQKKHhlbnN0b3JlIHdhdGNo KSB0aGF0IHJlLWV4ZWN1dGUgeGVuX2RldmljZV9iYWNrZW5kX2NoYW5nZWQoKSBhbmQgc2V0CnRo ZSBiYWNrZW5kIHN0YXRlIHRvICJDbG9zZWQiLiBRRU1VIHNob3VsZCB3YWl0IGZvciB0aGUgZnJv bnRlbmQgdG8Kc2V0ICJDbG9zZWQiIGJlZm9yZSBkb2luZyB0aGUgc2FtZS4KCkJlZm9yZSBzZXR0 aW5nICJDbG9zZWQiIHRvIHRoZSBiYWNrZW5kX3N0YXRlLCB3ZSBhcmUgYWxzbyBnb2luZyB0bwpj aGVjayBpZiB0aGUgZnJvbnRlbmQgd2FzIHJlc3BvbnNpYmxlIGZvciB0aGUgdHJhbnNpdGlvbiB0 byAiQ2xvc2luZyIuCgpGaXhlczogYjZhZjg5MjZmYjg1OGM0ZjE0MjZlNWFjYjJjZmMxZjA1ODBl Yzk4YQpTaWduZWQtb2ZmLWJ5OiBBbnRob255IFBFUkFSRCA8YW50aG9ueS5wZXJhcmRAY2l0cml4 LmNvbT4KLS0tCkNjOiBxZW11LXN0YWJsZUBub25nbnUub3JnCi0tLQogaHcveGVuL3hlbi1idXMu YyB8IDQgKysrLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigt KQoKZGlmZiAtLWdpdCBhL2h3L3hlbi94ZW4tYnVzLmMgYi9ody94ZW4veGVuLWJ1cy5jCmluZGV4 IGU0MDUwMDI0MmQuLjk4MmVjYTQ1MzMgMTAwNjQ0Ci0tLSBhL2h3L3hlbi94ZW4tYnVzLmMKKysr IGIvaHcveGVuL3hlbi1idXMuYwpAQCAtNTQwLDkgKzU0MCwxMSBAQCBzdGF0aWMgdm9pZCB4ZW5f ZGV2aWNlX2JhY2tlbmRfY2hhbmdlZCh2b2lkICpvcGFxdWUpCiAgICAgLyoKICAgICAgKiBJZiB0 aGUgdG9vbHN0YWNrIChvciB1bnBsdWcgcmVxdWVzdCBjYWxsYmFjaykgaGFzIHNldCB0aGUgYmFj a2VuZAogICAgICAqIHN0YXRlIHRvIENsb3NpbmcsIGJ1dCB0aGVyZSBpcyBubyBhY3RpdmUgZnJv bnRlbmQgKGkuZS4gdGhlCi0gICAgICogc3RhdGUgaXMgbm90IENvbm5lY3RlZCkgdGhlbiBzZXQg dGhlIGJhY2tlbmQgc3RhdGUgdG8gQ2xvc2VkLgorICAgICAqIHN0YXRlIGlzIG5vdCBDb25uZWN0 ZWQgb3IgQ2xvc2luZykgdGhlbiBzZXQgdGhlIGJhY2tlbmQgc3RhdGUKKyAgICAgKiB0byBDbG9z ZWQuCiAgICAgICovCiAgICAgaWYgKHhlbmRldi0+YmFja2VuZF9zdGF0ZSA9PSBYZW5idXNTdGF0 ZUNsb3NpbmcgJiYKKyAgICAgICAgeGVuZGV2LT5mcm9udGVuZF9zdGF0ZSAhPSBYZW5idXNTdGF0 ZUNsb3NpbmcgJiYKICAgICAgICAgeGVuZGV2LT5mcm9udGVuZF9zdGF0ZSAhPSBYZW5idXNTdGF0 ZUNvbm5lY3RlZCkgewogICAgICAgICB4ZW5fZGV2aWNlX2JhY2tlbmRfc2V0X3N0YXRlKHhlbmRl diwgWGVuYnVzU3RhdGVDbG9zZWQpOwogICAgIH0KLS0gCkFudGhvbnkgUEVSQVJECgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxp bmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5w cm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 819EDC3A59E for ; Wed, 21 Aug 2019 09:21:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C50D204EC for ; Wed, 21 Aug 2019 09:21:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="dzNc5o+n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C50D204EC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0Mo2-0003MP-Fa for qemu-devel@archiver.kernel.org; Wed, 21 Aug 2019 05:21:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36330) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0Mn6-0002NO-Uq for qemu-devel@nongnu.org; Wed, 21 Aug 2019 05:20:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0Mn5-0007m5-TM for qemu-devel@nongnu.org; Wed, 21 Aug 2019 05:20:28 -0400 Received: from esa6.hc3370-68.iphmx.com ([216.71.155.175]:7419) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i0Mn5-0007iC-LH; Wed, 21 Aug 2019 05:20:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1566379227; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=BK2UfPfQnsAdpwWahhn9/K+61xT4PsE2aBOjJXllKHk=; b=dzNc5o+nTt70S3GIToqrIr1/+IfDW538isrj+W8exeKUu4H37ojD/a+O RlQZJHqmj43SyKiZROKOWnZYllgsvQKzDT2b2UOeGu4b9aBGVYGNbzhWa 84ijbGOMRXWIYHd2KF83rb40zQpZetY7V+F+X+ercbIEkJvJrdrntk90g c=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: Dre/avdhM7+LkeeYNgXPxCnkXilAmFPsNzT4qdmjCyNlv3RbAuMOhVn8Hnt589TC2ULQAyStmJ wztSwrqA0slgsaYkaxu90dU3UyfmxOHqd0ywcZ+98kK+RjFO9FYLuJIE8r0tRR/Gn7YVBB4lqB b6iSUVXUkjPwrJUtVz621eni4MLaOxm7efr/gQJaNhCkecfQ5HGEJ5VuHoNh6x87n95f+58EuQ 1tNsyO2VabwmwuQl/amP+KFPELiUvI3GQAooAUS887cQnyBt9uPiTpot6St8gekcuXoRKO+e2D PLI= X-SBRS: 2.7 X-MesageID: 4731850 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,412,1559534400"; d="scan'208";a="4731850" From: Anthony PERARD To: Date: Wed, 21 Aug 2019 10:20:19 +0100 Message-ID: <20190821092020.17952-2-anthony.perard@citrix.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190821092020.17952-1-anthony.perard@citrix.com> References: <20190821092020.17952-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-Received-From: 216.71.155.175 Subject: [Qemu-devel] [PATCH 1/2] xen-bus: Fix backend state transition on device reset X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , xen-devel@lists.xenproject.org, Stefano Stabellini , qemu-stable@nongnu.org, Paul Durrant Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" When a frontend want to reset its state and the backend one, it start with setting "Closing", then wait for the backend (QEMU) to do the same. But when QEMU is setting "Closing" to its state, it trigger an event (xenstore watch) that re-execute xen_device_backend_changed() and set the backend state to "Closed". QEMU should wait for the frontend to set "Closed" before doing the same. Before setting "Closed" to the backend_state, we are also going to check if the frontend was responsible for the transition to "Closing". Fixes: b6af8926fb858c4f1426e5acb2cfc1f0580ec98a Signed-off-by: Anthony PERARD --- Cc: qemu-stable@nongnu.org --- hw/xen/xen-bus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c index e40500242d..982eca4533 100644 --- a/hw/xen/xen-bus.c +++ b/hw/xen/xen-bus.c @@ -540,9 +540,11 @@ static void xen_device_backend_changed(void *opaque) /* * If the toolstack (or unplug request callback) has set the backend * state to Closing, but there is no active frontend (i.e. the - * state is not Connected) then set the backend state to Closed. + * state is not Connected or Closing) then set the backend state + * to Closed. */ if (xendev->backend_state == XenbusStateClosing && + xendev->frontend_state != XenbusStateClosing && xendev->frontend_state != XenbusStateConnected) { xen_device_backend_set_state(xendev, XenbusStateClosed); } -- Anthony PERARD